From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by sourceware.org (Postfix) with ESMTPS id 34D0E3858D38 for ; Tue, 13 Jun 2023 21:50:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34D0E3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-3f9a81da5d7so91961cf.0 for ; Tue, 13 Jun 2023 14:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686693009; x=1689285009; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1PRSn4sHVzfQOeMWoR1OfKSo2B6i6uk+RdyMtnV/onM=; b=B3LLQMB29V7SQvM02/qzlEFV1nAhYIZI/1TF90U3CqUEh2MzxIw0ppo3MosCy2kUjs iO9RLkz4fP2CU7Bxm38nJNXFmctlkQeqgRvP7sGdXXWmdNqh/RHsA7Z6+aJAqdaAA3Z9 mmPDTyI9LO/tL2eVNbbp6wjQwkAfV09/9JkgmQitlJglWuKPB72gPUnO+TROPW/MDv2Z eGZLySKxiorhnk4MWkSfBp7dKltGlKeuGhtkwRn09TApm5hOdojBIG8fpKO4zTdIJLed ooX7BKWgZOnYhzU4gLQ7BQAcEmQyxw5sNRk8FWQ5+Da+7jPTQCBmvh3+ycZwbHk2qEPi 6ERg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686693009; x=1689285009; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1PRSn4sHVzfQOeMWoR1OfKSo2B6i6uk+RdyMtnV/onM=; b=er1a/7EkWt28YcejVZq+YOCeFELlG5Cg4LsVNsyBcy8yU1kddb89truuFF3DC7gIxH S7hUDf35KlPxwMwtx1Ao0ikXEs2pkH0XbtccJ0Vr/oVPl20UdGaVU4fgyJtIi0niPCQt s8YTCGHym7cJ2lvCPXkc0Y20JNdq9XUzqbDylenZDN6vzRkxdMyL0LAz95TZe9j2Sr/E JNr/fD04DvxrOCTLNfgovkKhBtXjbEOhQ/nctXa06hEL+P2zzHkuTlFwACreLLuWjxyU mmyZBixvuhQ4ySge0YndvvF33ryUkdP+tZs1euN0FEhoHsf6XRn+Fum5ba16yZ3m2Ahl NP9w== X-Gm-Message-State: AC+VfDxPrAYfAl0CUACOUDGl2enEJcNEfTfZAwrvPKxgIybU+8z5qqTe FAntOFXxxueX9HwBTW1YX1fmWtGINNtaHPhCGSSuwQ== X-Google-Smtp-Source: ACHHUZ7eFwBlz4RXZsbeK2S30V59sOj08qLbr79eGxs+Z6Kt1NZBQh5kQjwm1z3r0Aw6o5gn64Wk+DWJYl4rsa0UCHg= X-Received: by 2002:ac8:5704:0:b0:3f8:8c06:c53b with SMTP id 4-20020ac85704000000b003f88c06c53bmr90135qtw.0.1686693009436; Tue, 13 Jun 2023 14:50:09 -0700 (PDT) MIME-Version: 1.0 References: <20230613032823.264347-1-maskray@google.com> In-Reply-To: From: Fangrui Song Date: Tue, 13 Jun 2023 14:49:58 -0700 Message-ID: Subject: Re: [PATCH v3] i386: Allow -mlarge-data-threshold with -mcmodel=large To: Jan Beulich Cc: gcc-patches@gcc.gnu.org, Florian Weimer , "H.J. Lu" , Jan Hubicka , Michael Matz , Uros Bizjak Content-Type: multipart/alternative; boundary="000000000000ac838805fe09d181" X-Spam-Status: No, score=-18.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000ac838805fe09d181 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jun 12, 2023 at 11:16=E2=80=AFPM Jan Beulich wr= ote: > On 13.06.2023 05:28, Fangrui Song wrote: > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/i386/large-data.c > > @@ -0,0 +1,13 @@ > > +/* { dg-do compile } */ > > +/* { dg-require-effective-target lp64 } */ > > +/* { dg-options "-O2 -mcmodel=3Dlarge -mlarge-data-threshold=3D4" } */ > > +/* { dg-final { scan-assembler ".lbss" } } */ > > +/* { dg-final { scan-assembler ".bss" } } */ > > +/* { dg-final { scan-assembler ".ldata" } } */ > > +/* { dg-final { scan-assembler ".data" } } */ > > +/* { dg-final { scan-assembler ".lrodata" } } */ > > +/* { dg-final { scan-assembler ".rodata" } } */ > > Aren't these regex-es, and hence the dots all need escaping or enclosing > in square brackets? > > Jan > Good catch! I am not familiar with dg-* directives... I can send a v4, but I'd like to know whether there are other comments. (I don't have git write permission for gcc.) --=20 =E5=AE=8B=E6=96=B9=E7=9D=BF --000000000000ac838805fe09d181--