From: Uros Bizjak <ubizjak@gmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [PATCH]: Remove #ifdef PCC_BITFIELD_TYPE_MATTERS check from dwarf2out.c
Date: Wed, 05 Dec 2018 20:56:00 -0000 [thread overview]
Message-ID: <CAFULd4Y+EO0s119iLUrT84gqdNRspnmLYG7HYAnyqHm5V_C=Ww@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
This macro is always defined through defaults.h. We can remove #ifdef
check from dwarf2out.c
2018-12-05 Uros Bizjak <ubizjak@gmail.com>
* dwarf2out.c (field_byte_offset): Remove
#ifdef PCC_BITFIELD_TYPE_MATTERS check.
Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
OK for mainline?
Uros.
[-- Attachment #2: p.diff.txt --]
[-- Type: text/plain, Size: 804 bytes --]
Index: dwarf2out.c
===================================================================
--- dwarf2out.c (revision 266788)
+++ dwarf2out.c (working copy)
@@ -18985,7 +18985,6 @@ field_byte_offset (const_tree decl, struct vlr_con
if (TREE_CODE (DECL_FIELD_BIT_OFFSET (decl)) != INTEGER_CST)
return NULL;
-#ifdef PCC_BITFIELD_TYPE_MATTERS
/* We used to handle only constant offsets in all cases. Now, we handle
properly dynamic byte offsets only when PCC bitfield type doesn't
matter. */
@@ -19100,7 +19099,6 @@ field_byte_offset (const_tree decl, struct vlr_con
tree_result = wide_int_to_tree (sizetype, object_offset_in_bytes);
}
else
-#endif /* PCC_BITFIELD_TYPE_MATTERS */
tree_result = byte_position (decl);
if (ctx->variant_part_offset != NULL_TREE)
next reply other threads:[~2018-12-05 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 20:56 Uros Bizjak [this message]
2018-12-05 23:44 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4Y+EO0s119iLUrT84gqdNRspnmLYG7HYAnyqHm5V_C=Ww@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).