From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 1A0793858D1E for ; Sat, 22 Jul 2023 17:16:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A0793858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-98dfb3f9af6so489887166b.2 for ; Sat, 22 Jul 2023 10:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690046178; x=1690650978; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YSLK2QmeYj3hbd1mMlEvnbred0xV4JrlVPrkFe25Kfo=; b=GAG9mPPX/HUpT0pdTGRM/jkWUkmDNbxEVBqx39vBrl9pONit+spUqdbmZ7N/GAJSM9 VM36ABrGpI9qfZIk/xVeFWGjiPz/iXOvsrM8PLvEgQmnGnW6M1P/A3Z7aizH+l7i3RvG qIG1VwYUcXzCcrxGe3ppJXh9SkSLwMDpiSNHFe64PCwjxhoPk3dGyvlzCBfzETxrse9y qYLLfswAHzDa5ZgyquB//gZCn+iePHQExjKIHUyi3DZeCvpkrY1rYPhgPqgZ6bvzNVJK aE1Hc/atLelEGbhyg4nFIe7pL2MgmZGbh6oNCN9KrAfb3DSeIpSxorcAkI0jftwz4ePt 3stA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690046178; x=1690650978; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YSLK2QmeYj3hbd1mMlEvnbred0xV4JrlVPrkFe25Kfo=; b=lurWEuRJAPcXHKHoL9tUS6bU2tXZF8Ewa3MDaJuVu0ZR4+7/WkxF1uicubA9UqEnYo IXjQ6j5i62sw8YkRz7dCnvo1h8GXxrvGAlaXOKDTatbg4y0BC2lkyGrYfjdVyPpYDnq7 4DWlDs27/huuKA7vl0L4+k9n5tTWUM3zw84BBK+iDZXSsZpanRG4OipF4L+TatM9ogtC jqk+Eo+uTgHskD+FQuBWoqyad9zZJIx7snA5My0tPRlB+w0RnpjG20d58ry7sVnfNe6y 4CLHmse6HPr6JoKWMQCYak02NFONdhwW/JqPcAJyhThbgmM0Ulw043aeTxEUwJe9kXyX pe8Q== X-Gm-Message-State: ABy/qLZtFdq+cfF1f97wBeP61Oj4AEcpdWGmGgDiLU28BrP27LFC1d1r Rju7ZyjLoBHPcyRAUjUXOcdxZ1ZM9P8MNSial5TgbfF4 X-Google-Smtp-Source: APBJJlG0JvVchvWzDYfxzksgmdN6+fcA0B/fQD1AthcW7P0LRWwEWwilxpDE61nKwgxNEQjYW1CQjjdvTuaS+Wv64lM= X-Received: by 2002:a17:906:3118:b0:991:d727:6977 with SMTP id 24-20020a170906311800b00991d7276977mr4883351ejx.38.1690046178207; Sat, 22 Jul 2023 10:16:18 -0700 (PDT) MIME-Version: 1.0 References: <00c701d9bcb2$733bcdc0$59b36940$@nextmovesoftware.com> In-Reply-To: <00c701d9bcb2$733bcdc0$59b36940$@nextmovesoftware.com> From: Uros Bizjak Date: Sat, 22 Jul 2023 19:16:13 +0200 Message-ID: Subject: Re: [x86 PATCH] Use QImode for offsets in zero_extract/sign_extract in i386.md To: Roger Sayle Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,MEDICAL_SUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Jul 22, 2023 at 5:37=E2=80=AFPM Roger Sayle wrote: > > > As suggested by Uros, this patch changes the ZERO_EXTRACTs and SIGN_EXTRA= CTs > in i386.md to consistently use QImode for bit offsets (i.e. third and fou= rth > operands), matching the use of QImode for bit counts in shifts and rotate= s. > > There's no change in functionality, and the new patterns simply ensure th= at > we continue to generate the same code (match revised patterns) as before. > > This patch has been tested on x86_64-pc-linux-gnu with make bootstrap > and make -k check, both with and without --target_board=3Dunix{-m32} > with no new failures. Ok for mainline? > > > 2023-07-22 Roger Sayle > > gcc/ChangeLog > * config/i386/i386.md (extv): Use QImode for offsets. > (extzv): Likewise. > (insv): Likewise. > (*testqi_ext_3): Likewise. > (*btr_2): Likewise. > (define_split): Likewise. > (*btsq_imm): Likewise. > (*btrq_imm): Likewise. > (*btcq_imm): Likewise. > (define_peephole2 x3): Likewise. > (*bt): Likewise > (*bt_mask): New define_insn_and_split. > (*jcc_bt): Use QImode for offsets. > (*jcc_bt_1): Delete obsolete pattern. > (*jcc_bt_mask): Use QImode offsets. > (*jcc_bt_mask_1): Likewise. > (define_split): Likewise. > (*bt_setcqi): Likewise. > (*bt_setncqi): Likewise. > (*bt_setnc): Likewise. > (*bt_setncqi_2): Likewise. > (*bt_setc_mask): New define_insn_and_split. > (bmi2_bzhi_3): Use QImode offsets. > (*bmi2_bzhi_3): Likewise. > (*bmi2_bzhi_3_1): Likewise. > (*bmi2_bzhi_3_1_ccz): Likewise. > (@tbm_bextri_): Likewise. OK. Thanks, Uros. > > > Thanks, > Roger > -- >