public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH, i386]: Fix PR 72843, ICE in lra_set_insn_recog_data
@ 2016-08-09 15:40 Uros Bizjak
  0 siblings, 0 replies; only message in thread
From: Uros Bizjak @ 2016-08-09 15:40 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

Hello!

Insn predicates have to allow all constraints during LRA, not only
after reload_completed is true.

2016-08-09  Uros Bizjak  <ubizjak@gmail.com>

    PR target/72843
    * config/i386/i386.md (*movtf_internal): Use
    lra_in_progress || reload_completed instead of !can_create_pseudo_p
    in the insn constraint.
    (*movxf_internal): Ditto.
    (*movdf_internal): Ditto.
    (*movsf_internal): Ditto.

Bootstrapped and regression tested on x86_64-linux-gnu {,-m32} and
committed to mainline.

The patch will be backported to to other release branches after a week.

Uros.

[-- Attachment #2: p.diff.txt --]
[-- Type: text/plain, Size: 1830 bytes --]

Index: config/i386/i386.md
===================================================================
--- config/i386/i386.md	(revision 239247)
+++ config/i386/i386.md	(working copy)
@@ -3119,7 +3119,7 @@
 	(match_operand:TF 1 "general_operand"	   "C ,vm,v,*roF,*rC"))]
   "(TARGET_64BIT || TARGET_SSE)
    && !(MEM_P (operands[0]) && MEM_P (operands[1]))
-   && (!can_create_pseudo_p ()
+   && (lra_in_progress || reload_completed
        || !CONST_DOUBLE_P (operands[1])
        || ((optimize_function_for_size_p (cfun)
 	    || (ix86_cmodel == CM_LARGE || ix86_cmodel == CM_LARGE_PIC))
@@ -3205,7 +3205,7 @@
 	(match_operand:XF 1 "general_operand"
 	 "fm,f,G,roF,r , *roF,*r,F ,C,roF,rF"))]
   "!(MEM_P (operands[0]) && MEM_P (operands[1]))
-   && (!can_create_pseudo_p ()
+   && (lra_in_progress || reload_completed
        || !CONST_DOUBLE_P (operands[1])
        || ((optimize_function_for_size_p (cfun)
 	    || (ix86_cmodel == CM_LARGE || ix86_cmodel == CM_LARGE_PIC))
@@ -3278,7 +3278,7 @@
 	(match_operand:DF 1 "general_operand"
     "Yf*fm,Yf*f,G   ,roF,r ,*roF,*r,F ,rm,rC,C ,F ,C,v,m,v,C ,*x,m ,*x,Yj,r ,roF,rF,rmF,rC"))]
   "!(MEM_P (operands[0]) && MEM_P (operands[1]))
-   && (!can_create_pseudo_p ()
+   && (lra_in_progress || reload_completed
        || !CONST_DOUBLE_P (operands[1])
        || ((optimize_function_for_size_p (cfun)
 	    || (ix86_cmodel == CM_LARGE || ix86_cmodel == CM_LARGE_PIC))
@@ -3480,7 +3480,7 @@
 	(match_operand:SF 1 "general_operand"
 	  "Yf*fm,Yf*f,G   ,rmF,rF,C,v,m,v,Yj,r  ,*y ,m  ,*y,*Yn,r   ,rmF,rF"))]
   "!(MEM_P (operands[0]) && MEM_P (operands[1]))
-   && (!can_create_pseudo_p ()
+   && (lra_in_progress || reload_completed
        || !CONST_DOUBLE_P (operands[1])
        || ((optimize_function_for_size_p (cfun)
 	    || (ix86_cmodel == CM_LARGE || ix86_cmodel == CM_LARGE_PIC))

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-09 15:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-09 15:40 [PATCH, i386]: Fix PR 72843, ICE in lra_set_insn_recog_data Uros Bizjak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).