From: Uros Bizjak <ubizjak@gmail.com>
To: "Peryt, Sebastian" <sebastian.peryt@intel.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"Lu, Hongjiu" <hongjiu.lu@intel.com>
Subject: Re: [Patch][x86, backport] Backport to GCC-7 vzeroupper patches
Date: Wed, 29 Nov 2017 09:55:00 -0000 [thread overview]
Message-ID: <CAFULd4Y1emJi6EKjUhgVqBr=6897K+Jw9=Y+Ehk2h4jRXqNuiw@mail.gmail.com> (raw)
In-Reply-To: <17623B198193D741876BD81A6E3AE5AD3C5A1237@irsmsx111.ger.corp.intel.com>
On Wed, Nov 29, 2017 at 10:39 AM, Peryt, Sebastian
<sebastian.peryt@intel.com> wrote:
> Hi,
>
> I'd like to ask for backporting to GCC-7 branch vzeroupper generation patches from trunk,
> that are resolving 3 PRs:
> PR target/82941
> PR target/82942
> PR target/82990
>
> Two patches were combined into one and rebased. Bootstraped and tested.
> Is it ok for merge?
>
> Changelog:
>
> Fix PR82941 and PR82942 by adding proper vzeroupper generation on SKX.
> Add X86_TUNE_EMIT_VZEROUPPER to indicate if vzeroupper instruction should
> be inserted before a transfer of control flow out of the function. It is
> turned on by default unless we are tuning for KNL. Users can always use
> -mzeroupper or -mno-zeroupper to override X86_TUNE_EMIT_VZEROUPPER.
>
> 2017-11-29 Sebastian Peryt <sebastian.peryt@intel.com>
> H.J. Lu <hongjiu.lu@intel.com>
>
> gcc/
> Bakcported from trunk
> PR target/82941
> PR target/82942
> PR target/82990
> * config/i386/i386.c (pass_insert_vzeroupper): Remove
> TARGET_AVX512F check from gate condition.
> (ix86_check_avx256_register): Changed to ...
> (ix86_check_avx_upper_register): ... this. Add extra check for
> VALID_AVX512F_REG_OR_XI_MODE.
> (ix86_avx_u128_mode_needed): Changed
> ix86_check_avx256_register to ix86_check_avx_upper_register.
> (ix86_check_avx256_stores): Changed to ...
> (ix86_check_avx_upper_stores): ... this. Changed
> ix86_check_avx256_register to ix86_check_avx_upper_register.
> (ix86_avx_u128_mode_after): Changed
> avx_reg256_found to avx_upper_reg_found. Changed
> ix86_check_avx256_stores to ix86_check_avx_upper_stores.
> (ix86_avx_u128_mode_entry): Changed
> ix86_check_avx256_register to ix86_check_avx_upper_register.
> (ix86_avx_u128_mode_exit): Ditto.
> (ix86_option_override_internal): Set MASK_VZEROUPPER if
> neither -mzeroupper nor -mno-zeroupper is used and
> TARGET_EMIT_VZEROUPPER is set.
> * config/i386/i386.h: (host_detect_local_cpu): New define.
> (TARGET_EMIT_VZEROUPPER): New.
> * config/i386/x86-tune.def: Add X86_TUNE_EMIT_VZEROUPPER.
>
> 2017-11-29 Sebastian Peryt <sebastian.peryt@intel.com>
> H.J. Lu <hongjiu.lu@intel.com>
>
> gcc/testsuite/
> Backported from trunk
> PR target/82941
> PR target/82942
> PR target/82990
> * gcc.target/i386/pr82941-1.c: New test.
> * gcc.target/i386/pr82941-2.c: Likewise.
> * gcc.target/i386/pr82942-1.c: Likewise.
> * gcc.target/i386/pr82942-2.c: Likewise.
> * gcc.target/i386/pr82990-1.c: Likewise.
> * gcc.target/i386/pr82990-2.c: Likewise.
> * gcc.target/i386/pr82990-3.c: Likewise.
> * gcc.target/i386/pr82990-4.c: Likewise.
> * gcc.target/i386/pr82990-5.c: Likewise.
> * gcc.target/i386/pr82990-6.c: Likewise.
> * gcc.target/i386/pr82990-7.c: Likewise.
OK.
Thanks,
Uros.
prev parent reply other threads:[~2017-11-29 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 9:45 Peryt, Sebastian
2017-11-29 9:55 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4Y1emJi6EKjUhgVqBr=6897K+Jw9=Y+Ehk2h4jRXqNuiw@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongjiu.lu@intel.com \
--cc=sebastian.peryt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).