From: Uros Bizjak <ubizjak@gmail.com>
To: "Koval, Julia" <julia.koval@intel.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Kirill Yukhin <kirill.yukhin@gmail.com>
Subject: Re: [x86][patch] Add -march=cannonlake.
Date: Sun, 12 Nov 2017 16:32:00 -0000 [thread overview]
Message-ID: <CAFULd4Y2ocXRyKLJ_+FLZPVfxv+AmoayiDCzUTkztj417JJiUA@mail.gmail.com> (raw)
In-Reply-To: <4E89A029A0F8D443B436A5167BA3C53F42ACE2CC@IRSMSX101.ger.corp.intel.com>
On Sat, Nov 11, 2017 at 10:10 PM, Koval, Julia <julia.koval@intel.com> wrote:
> Hi Uros,
> I fixed comments.
> Btw, I haven't found skylake-avx512 in driver-i386.c at all. Is it intended or should I add it?
It looks like an oversight to me. If there are no "skylake-avx512"
model, then the driver goes through "This is unknown ..." for
-march=native and hopefully chooses the next most appropriate choice.
Please add "skylake-avx512" in a follow-up patch.
> Thanks,
> Julia
>
> gcc/
> * config.gcc: Add -march=cannonlake.
> * config/i386/driver-i386.c (host_detect_local_cpu): Detect cannonlake.
> * config/i386/i386-c.c (ix86_target_macros_internal): Handle cannonlake.
> * config/i386/i386.c (processor_costs): Add m_CANNONLAKE.
> (PTA_CANNONLAKE): New.
> (processor_target_table): Add cannonlake.
> (ix86_option_override_internal): Ditto.
> (fold_builtin_cpu): Ditto.
> (get_builtin_code_for_version): Handle cannonlake.
> (M_INTEL_COREI7_CANNONLAKE): New.
> * config/i386/i386.h (TARGET_CANNONLAKE, PROCESSOR_CANNONLAKE): New.
> * doc/invoke.texi: Add -march=cannonlake.
> gcc/testsuite/
> * gcc.target/i386/funcspec-56.inc: Handle new march.
> * g++.dg/ext/mv16.C: Ditto.
> libgcc/
> * config/i386/cpuinfo.c (get_intel_cpu): Handle cannonlake.
> * config/i386/cpuinfo.h (processor_subtypes): Add INTEL_COREI7_CANNONLAKE.
OK.
Thanks,
Uros.
next prev parent reply other threads:[~2017-11-12 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 8:08 Koval, Julia
2017-11-08 19:51 ` Uros Bizjak
2017-11-11 22:03 ` Koval, Julia
2017-11-12 16:32 ` Uros Bizjak [this message]
2017-11-13 10:32 ` Koval, Julia
2017-11-13 11:53 ` Uros Bizjak
-- strict thread matches above, loose matches on Subject: below --
2017-11-08 8:06 Koval, Julia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4Y2ocXRyKLJ_+FLZPVfxv+AmoayiDCzUTkztj417JJiUA@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=julia.koval@intel.com \
--cc=kirill.yukhin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).