public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] libstdc++: Skip 91371.cc for x32.
@ 2020-03-13 19:38 Uros Bizjak
  2020-03-16 11:42 ` Jonathan Wakely
  0 siblings, 1 reply; 2+ messages in thread
From: Uros Bizjak @ 2020-03-13 19:38 UTC (permalink / raw)
  To: gcc-patches; +Cc: libstdc++

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

x32 does not support MS ABI, skip testcases that require it.

2020-03-13  Uroš Bizjak  <ubizjak@gmail.com>

    * testsuite/20_util/bind/91371.cc: Skip for x32.
    * testsuite/20_util/is_function/91371.cc: Ditto.
    * testsuite/20_util/is_member_function_pointer/91371.cc: Ditto.
    * testsuite/20_util/is_object/91371.cc: Ditto.

Tested on x86_64-linux-gnu {,-mx32}.

Fixes -mx32 libstdc++ failures in [1].

OK for mainline?

[1] https://gcc.gnu.org/pipermail/gcc-testresults/2020-March/556130.html

Uros.

[-- Attachment #2: t.diff.txt --]
[-- Type: text/plain, Size: 2351 bytes --]

diff --git a/libstdc++-v3/testsuite/20_util/bind/91371.cc b/libstdc++-v3/testsuite/20_util/bind/91371.cc
index a076177ff73..5c872f14148 100644
--- a/libstdc++-v3/testsuite/20_util/bind/91371.cc
+++ b/libstdc++-v3/testsuite/20_util/bind/91371.cc
@@ -15,7 +15,7 @@
 // with this library; see the file COPYING3.  If not see
 // <http://www.gnu.org/licenses/>.
 
-// { dg-do compile { target i?86-*-* x86_64-*-* } }
+// { dg-do compile { target { { i?86-*-* x86_64-*-* } && { ! x32 } } } }
 // { dg-require-effective-target c++11 }
 
 #include <functional>
diff --git a/libstdc++-v3/testsuite/20_util/is_function/91371.cc b/libstdc++-v3/testsuite/20_util/is_function/91371.cc
index eccb3e0c121..700ee60aafd 100644
--- a/libstdc++-v3/testsuite/20_util/is_function/91371.cc
+++ b/libstdc++-v3/testsuite/20_util/is_function/91371.cc
@@ -15,7 +15,7 @@
 // with this library; see the file COPYING3.  If not see
 // <http://www.gnu.org/licenses/>.
 
-// { dg-do compile { target i?86-*-* x86_64-*-* } }
+// { dg-do compile { target { { i?86-*-* x86_64-*-* } && { ! x32 } } } }
 // { dg-require-effective-target c++11 }
 
 #include <type_traits>
diff --git a/libstdc++-v3/testsuite/20_util/is_member_function_pointer/91371.cc b/libstdc++-v3/testsuite/20_util/is_member_function_pointer/91371.cc
index ace05e041c3..376be9e116e 100644
--- a/libstdc++-v3/testsuite/20_util/is_member_function_pointer/91371.cc
+++ b/libstdc++-v3/testsuite/20_util/is_member_function_pointer/91371.cc
@@ -15,7 +15,7 @@
 // with this library; see the file COPYING3.  If not see
 // <http://www.gnu.org/licenses/>.
 
-// { dg-do compile { target i?86-*-* x86_64-*-* } }
+// { dg-do compile { target { { i?86-*-* x86_64-*-* } && { ! x32 } } } }
 // { dg-require-effective-target c++11 }
 
 #include <type_traits>
diff --git a/libstdc++-v3/testsuite/20_util/is_object/91371.cc b/libstdc++-v3/testsuite/20_util/is_object/91371.cc
index 8387cdbed9e..6fc3fd85d2e 100644
--- a/libstdc++-v3/testsuite/20_util/is_object/91371.cc
+++ b/libstdc++-v3/testsuite/20_util/is_object/91371.cc
@@ -15,7 +15,7 @@
 // with this library; see the file COPYING3.  If not see
 // <http://www.gnu.org/licenses/>.
 
-// { dg-do compile { target i?86-*-* x86_64-*-* } }
+// { dg-do compile { target { { i?86-*-* x86_64-*-* } && { ! x32 } } } }
 // { dg-require-effective-target c++11 }
 
 #include <type_traits>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libstdc++: Skip 91371.cc for x32.
  2020-03-13 19:38 [PATCH] libstdc++: Skip 91371.cc for x32 Uros Bizjak
@ 2020-03-16 11:42 ` Jonathan Wakely
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2020-03-16 11:42 UTC (permalink / raw)
  To: Uros Bizjak; +Cc: gcc-patches, libstdc++

On 13/03/20 20:38 +0100, Uros Bizjak via Libstdc++ wrote:
>x32 does not support MS ABI, skip testcases that require it.
>
>2020-03-13  Uroš Bizjak  <ubizjak@gmail.com>
>
>    * testsuite/20_util/bind/91371.cc: Skip for x32.
>    * testsuite/20_util/is_function/91371.cc: Ditto.
>    * testsuite/20_util/is_member_function_pointer/91371.cc: Ditto.
>    * testsuite/20_util/is_object/91371.cc: Ditto.
>
>Tested on x86_64-linux-gnu {,-mx32}.
>
>Fixes -mx32 libstdc++ failures in [1].
>
>OK for mainline?

OK, thanks.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-16 11:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-13 19:38 [PATCH] libstdc++: Skip 91371.cc for x32 Uros Bizjak
2020-03-16 11:42 ` Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).