From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102143 invoked by alias); 22 Jan 2019 08:46:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102051 invoked by uid 89); 22 Jan 2019 08:46:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=D*localhost, HX-Received:Tue, UD:golang.org, golangorg X-HELO: mail-it1-f182.google.com Received: from mail-it1-f182.google.com (HELO mail-it1-f182.google.com) (209.85.166.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Jan 2019 08:46:30 +0000 Received: by mail-it1-f182.google.com with SMTP id g76so20218732itg.2 for ; Tue, 22 Jan 2019 00:46:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=mUyEX7/6a2f5CKS+COySdTcZhsgJ9eaIgbk3TUy2XTk=; b=fCRzRBLBLdh3jwZHba+CVR5oel86SvODMVwzW2VxHDH7L8/FvT7JZrTKkzVpgzLo10 ACxhjWKfcwLEJMF7K2+A0ml35ElrvC+t/ovOvzyeR0CspftcwJZKtHIAtTDsUuvdJ58M WL344tg3WkDTSP5nU/DRoj5lSlrNLkWPqxGP7bILX8JWCH+2wvyExJxtnAGY5JtrBI9y +UwBOSL7NMey3/oVk25Ok2+UfSEwoWXVcAYWMjdXkaLdlloWifVTP3lVHL3yPrPNv8dR S0YEYylqdw8aekb62ms7PvD66T2l+jGuUCsZ+j1EIOhu2oAiJzESvGEAgqYZLRUNysTu XsUA== MIME-Version: 1.0 From: Uros Bizjak Date: Tue, 22 Jan 2019 08:46:00 -0000 Message-ID: Subject: Re: libgo patch committed: Update to Go1.12beta2 To: Ian Taylor Cc: "gcc-patches@gcc.gnu.org" , gofrontend-dev@googlegroups.com Content-Type: multipart/mixed; boundary="0000000000006d0bd20580080346" X-SW-Source: 2019-01/txt/msg01266.txt.bz2 --0000000000006d0bd20580080346 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-length: 1349 Hello! > I have committed a patch to update libgo to the Go 1.12beta2 release. > > As usual this sort of update is too large to include all changes in > this e-mail. I've included changes to gccgo-specific files below. > > Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed > to mainline. Attached patch is needed to prevent panic on alphaec68-linux-gnu when building test harness in gotools directory. It substitutes one instance of hardcoded "gc" with build.Default.Compiler in place where archSizes are determined. Please note that there are other similar cases, which don't trigger panics for me, but are suspicious, too: [uros@localhost golang.org]$ grep -R "\"gc\"" * x/tools/go/analysis/unitchecker/unitchecker.go: Sizes: types.SizesFor("gc", build.Default.GOARCH), // assume gccgo =E2=89=A1 gc? x/tools/go/analysis/passes/asmdecl/asmdecl.go: arch.sizes =3D types.SizesFor("gc", arch.name) x/tools/go/analysis/passes/asmdecl/asmdecl.go: arch.sizes =3D types.SizesFor("gc", "amd64") x/tools/go/analysis/passes/printf/types.go:var archSizes =3D types.SizesFor("gc", build.Default.GOARCH) x/tools/go/analysis/passes/cgocall/cgocall.go: Sizes: types.SizesFor("gc", build.Default.GOARCH), Patch was regression tested on alphaev68-linux-gnu, and fixes a bunch of panics in gotools directory. Uros. --0000000000006d0bd20580080346 Content-Type: text/plain; charset="US-ASCII"; name="g.diff.txt" Content-Disposition: attachment; filename="g.diff.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jr7ijy640 Content-length: 749 ZGlmZiAtLWdpdCBhL2xpYmdvL2dvL2dvbGFuZy5vcmcveC90b29scy9nby9h bmFseXNpcy9wYXNzZXMvc2hpZnQvc2hpZnQuZ28gYi9saWJnby9nby9nb2xh bmcub3JnL3gvdG9vbHMvZ28vYW5hbHlzaXMvcGFzc2VzL3NoaWZ0L3NoaWZ0 LmdvCmluZGV4IDU2YjE1MGIyYjEzMi4uYmViMGIxMjRiMGU1IDEwMDY0NAot LS0gYS9saWJnby9nby9nb2xhbmcub3JnL3gvdG9vbHMvZ28vYW5hbHlzaXMv cGFzc2VzL3NoaWZ0L3NoaWZ0LmdvCisrKyBiL2xpYmdvL2dvL2dvbGFuZy5v cmcveC90b29scy9nby9hbmFseXNpcy9wYXNzZXMvc2hpZnQvc2hpZnQuZ28K QEAgLTEyNSw0ICsxMjUsNCBAQCB2YXIgKAogCXVpbnRwdHJCaXRTaXplID0g OCAqIGFyY2hTaXplcy5TaXplb2YodHlwZXMuVHlwW3R5cGVzLlVpbnRwdHJd KQogKQogCi12YXIgYXJjaFNpemVzID0gdHlwZXMuU2l6ZXNGb3IoImdjIiwg YnVpbGQuRGVmYXVsdC5HT0FSQ0gpCit2YXIgYXJjaFNpemVzID0gdHlwZXMu U2l6ZXNGb3IoYnVpbGQuRGVmYXVsdC5Db21waWxlciwgYnVpbGQuRGVmYXVs dC5HT0FSQ0gpCg== --0000000000006d0bd20580080346--