From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107424 invoked by alias); 30 Jun 2017 06:40:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 107355 invoked by uid 89); 30 Jun 2017 06:40:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=hello! X-HELO: mail-vk0-f52.google.com Received: from mail-vk0-f52.google.com (HELO mail-vk0-f52.google.com) (209.85.213.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Jun 2017 06:40:10 +0000 Received: by mail-vk0-f52.google.com with SMTP id r125so61724565vkf.1 for ; Thu, 29 Jun 2017 23:40:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=MHl6re1fljUuUo+I5r2po+UAZ1s+RUwa9MSEFhnuGBo=; b=nX3TjH4y4Qdwz7hNtUJjKGrezIN9rabMugBUpFBfq8k3ULLFYCbTfqx21QtXAhLy4w AuBb5v8cKoPKtv9jw048revXrlWEyOgHgKIXI06U0OaQNVzJzXBDx+3ubtDlTrUxS4dD jIBbTnn+sevLQktsbu7dA2roJEyJt1R4UANZvzKADuH7LgouC9AGUoEEhV1z+eyC4Jab w1V7om45oBG/qLpLQ7t7WpRSbgDTyOAglzXYIeY4yrpi3KrZgLqGMs/A2UkftMn4osGr iBtmMoazSMPxFfyvSzfTLBZVZL8R5d0Y9auNmlLJ7sFtxf+ftaq5SmBaBNK6bLi1X0v8 3eOQ== X-Gm-Message-State: AKS2vOyStTbZLpFq3rMnxw48KUcPkd4Tn1DNcQBNfhVN6sopZjx9RMzY HLv+Eq4vhjsIRgzJv8wZXHlr0So5sOKb X-Received: by 10.31.47.211 with SMTP id v202mr11302215vkv.4.1498804808712; Thu, 29 Jun 2017 23:40:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.69.9 with HTTP; Thu, 29 Jun 2017 23:40:08 -0700 (PDT) From: Uros Bizjak Date: Fri, 30 Jun 2017 06:40:00 -0000 Message-ID: Subject: Re: gotools patch committed: Test runtime, misc/cgo/{test,testcarchive} To: "gcc-patches@gcc.gnu.org" Cc: Ian Taylor , "gofrontend-dev@googlegroups.com" Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-06/txt/msg02352.txt.bz2 Hello! > This patch to the gotools Makefile adds tests to `make check`. We now > test the runtime package using the newly built go tool, and test that > cgo works by running the misc/cgo/test and misc/cgo/testcarchive > tests. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. > Committed to mainline. There are several failures on non-split targets, e.g.: FAIL: TestCgoHandlesWlORIGIN go_test.go:267: running testgo [build origin] go_test.go:286: standard error: go_test.go:287: # origin cc1: error: '-fsplit-stack' requires assembler support for CFI directives cc1: error: '-fsplit-stack' is not supported by this compiler configuration and: FAIL: TestCgoCrashHandler crash_test.go:70: building testprogcgo []: exit status 2 # _/home/uros/git/gcc/libgo/go/runtime/testdata/testprogcgo cc1: error: '-fsplit-stack' requires assembler support for CFI directives cc1: error: '-fsplit-stack' is not supported by this compiler configuration As evident from TestBuildDryRunWithCgo dump, -fsplit-stack argument is added unconditionally to the compile flags. Uros.