From: Uros Bizjak <ubizjak@gmail.com>
To: gcc-patches@gcc.gnu.org
Cc: Jakub Jelinek <jakub@redhat.com>,
Hans-Peter Nilsson <hp@bitrange.com>,
Eric Botcazou <ebotcazou@adacore.com>,
Alexandre Oliva <aoliva@redhat.com>
Subject: Re: [RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver
Date: Wed, 28 Nov 2012 09:50:00 -0000 [thread overview]
Message-ID: <CAFULd4YEM+ff1L35+0b0WYB=g6wryLR-YZo9FTr0FPbN2Z7S8g@mail.gmail.com> (raw)
In-Reply-To: <CAFULd4avuNgOTCXSrMg96AADL+M83C0QjTRXs69PhTdF8BOEMQ@mail.gmail.com>
On Tue, Nov 27, 2012 at 8:29 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>> As long as volatile asms and UNSPEC_VOLATILE insns (aka.
>> barriers) are handled the same way and consistently throughout
>> gcc, I'm fine. It seems your patch does that, so thanks!
>>
>> > But the question is also what effects your patch can have e.g. on RTL DSE.
>>
>> Looks like the patch caused a bootstrap for s390x.
>>
>> Eagerly awaiting a PR for that, but whoever is interested
>> on that, please try Jakub's patch first...
>>
>> > 2012-11-26 Jakub Jelinek <jakub@redhat.com>
>> >
>> > PR debug/36728
>> > PR debug/55467
>> > * cselib.c (cselib_process_insn): If cselib_preserve_constants,
>> > don't reset table and exit early on volatile insns and setjmp.
>> > Reset table afterwards on setjmp.
>> >
>> > * gcc.dg/guality/pr36728-1.c: Include "../nop.h", make sure the asm
>> > are non-empty and add dependency between the first and second asm.
>> > * gcc.dg/guality/pr36728-2.c: Likewise.
>> > * gcc.dg/guality/pr36728-3.c: New test.
>> > * gcc.dg/guality/pr36728-4.c: New test.
>
> I have hit the same ICE on alpha-linux-gnu bootstrap. Jakub's patch
> fixes the ICE, and allows bootstrap to pass well into stage2 now.
> However, it takes ~10 hours for full bootstrap+regtest to finish, will
> report back tomorrow morning (CET).
The results look OK [1]. Please note that I didn't patch the testsuite.
[1] http://gcc.gnu.org/ml/gcc-testresults/2012-11/msg02335.html
Uros.
next prev parent reply other threads:[~2012-11-28 9:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 19:30 Uros Bizjak
2012-11-28 9:50 ` Uros Bizjak [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-12 4:49 Hans-Peter Nilsson
2012-11-12 8:28 ` Eric Botcazou
2012-11-19 3:54 ` Hans-Peter Nilsson
2012-11-19 9:35 ` Eric Botcazou
2012-11-26 3:30 ` Hans-Peter Nilsson
2012-11-27 11:44 ` Hans-Peter Nilsson
2012-11-27 12:04 ` Jakub Jelinek
2012-11-27 12:27 ` Hans-Peter Nilsson
2012-11-27 13:32 ` Jakub Jelinek
2012-11-27 17:39 ` Eric Botcazou
2012-11-27 18:20 ` Jakub Jelinek
2012-12-01 0:03 ` Eric Botcazou
2012-11-28 20:10 ` Richard Sandiford
2012-11-28 20:46 ` Richard Henderson
2012-11-28 13:44 ` Hans-Peter Nilsson
2012-11-28 13:56 ` Jakub Jelinek
2012-11-28 20:53 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4YEM+ff1L35+0b0WYB=g6wryLR-YZo9FTr0FPbN2Z7S8g@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=aoliva@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@bitrange.com \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).