From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15985 invoked by alias); 28 Nov 2012 09:50:25 -0000 Received: (qmail 15973 invoked by uid 22791); 28 Nov 2012 09:50:25 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_ZJ X-Spam-Check-By: sourceware.org Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Nov 2012 09:50:17 +0000 Received: by mail-pa0-f47.google.com with SMTP id fa10so4131776pad.20 for ; Wed, 28 Nov 2012 01:50:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.194.101 with SMTP id hv5mr56356820pbc.121.1354096217239; Wed, 28 Nov 2012 01:50:17 -0800 (PST) Received: by 10.66.246.232 with HTTP; Wed, 28 Nov 2012 01:50:17 -0800 (PST) In-Reply-To: References: Date: Wed, 28 Nov 2012 09:50:00 -0000 Message-ID: Subject: Re: [RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver From: Uros Bizjak To: gcc-patches@gcc.gnu.org Cc: Jakub Jelinek , Hans-Peter Nilsson , Eric Botcazou , Alexandre Oliva Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg02296.txt.bz2 On Tue, Nov 27, 2012 at 8:29 PM, Uros Bizjak wrote: >> As long as volatile asms and UNSPEC_VOLATILE insns (aka. >> barriers) are handled the same way and consistently throughout >> gcc, I'm fine. It seems your patch does that, so thanks! >> >> > But the question is also what effects your patch can have e.g. on RTL DSE. >> >> Looks like the patch caused a bootstrap for s390x. >> >> Eagerly awaiting a PR for that, but whoever is interested >> on that, please try Jakub's patch first... >> >> > 2012-11-26 Jakub Jelinek >> > >> > PR debug/36728 >> > PR debug/55467 >> > * cselib.c (cselib_process_insn): If cselib_preserve_constants, >> > don't reset table and exit early on volatile insns and setjmp. >> > Reset table afterwards on setjmp. >> > >> > * gcc.dg/guality/pr36728-1.c: Include "../nop.h", make sure the asm >> > are non-empty and add dependency between the first and second asm. >> > * gcc.dg/guality/pr36728-2.c: Likewise. >> > * gcc.dg/guality/pr36728-3.c: New test. >> > * gcc.dg/guality/pr36728-4.c: New test. > > I have hit the same ICE on alpha-linux-gnu bootstrap. Jakub's patch > fixes the ICE, and allows bootstrap to pass well into stage2 now. > However, it takes ~10 hours for full bootstrap+regtest to finish, will > report back tomorrow morning (CET). The results look OK [1]. Please note that I didn't patch the testsuite. [1] http://gcc.gnu.org/ml/gcc-testresults/2012-11/msg02335.html Uros.