From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44779 invoked by alias); 20 Sep 2017 14:13:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 44744 invoked by uid 89); 20 Sep 2017 14:13:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Enforcment, enforcment X-HELO: mail-it0-f48.google.com Received: from mail-it0-f48.google.com (HELO mail-it0-f48.google.com) (209.85.214.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Sep 2017 14:13:31 +0000 Received: by mail-it0-f48.google.com with SMTP id d123so2613545ith.3 for ; Wed, 20 Sep 2017 07:13:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=eKXyvUu6le1szdd5A+IcdIEAkdfYmgELqYD5FrUnwls=; b=hvotrkLSRWYnWRu12Epq9dID89DKP9tNmjngrtsyqgb4cVCM09VY7NzX1V9n1AooR9 VqtrMV58u2TTeVd/Lddfmu8cwmxR2M3eEY1iTwTECIjYXI2YrzuzIunsLH81mVa5t/fl bR1OSKKX/pAfC6GV0Zv/5mWnKmHeTBrM2jCLiejusgkNYZflQ2Gbmzu1yFFnk6vkaxXL ca8LA0pXt1akZpvjXCrHPdWGi4UlW6trOmKfxWfXYW2p9JIOUyZHTVrcjdadipj7WSI+ GNnzJ929JQOG3/U5TLtYSdCW/iC8QxCJtzsO/tqdcNmzCVrZpwNq/SExjDs9CdxShwO2 mePg== X-Gm-Message-State: AHPjjUgnmr//2JGdlX39Srkm5/GU4ZKu4cINgqhdQPOyYPOs+0nxtFY5 TJVYcLHfDJnsEXaBB0jIGS9yrK3tVUjO8jROVuA= X-Google-Smtp-Source: AOwi7QD/Nreg7hkB7OtY8PsZhurdd8xZ+uO166BcDphTKLZnIF1pfgPsvwAptWTCiNXzN6ut9EXLRkb+puoHH1si+mY= X-Received: by 10.36.181.79 with SMTP id j15mr3449482iti.78.1505916809291; Wed, 20 Sep 2017 07:13:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.137.252 with HTTP; Wed, 20 Sep 2017 07:13:28 -0700 (PDT) In-Reply-To: References: From: Uros Bizjak Date: Wed, 20 Sep 2017 14:13:00 -0000 Message-ID: Subject: Re: 0005-Part-5.-Add-x86-CET-documentation To: "Tsimbalist, Igor V" Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-09/txt/msg01361.txt.bz2 On Wed, Sep 20, 2017 at 11:20 AM, Tsimbalist, Igor V wrote: > Uros, could you please review this patch as it's a part of x86 specific changes you have reviewed already. Please proofread and spell-check the text. There are grammatical errors, e.g.: +When compiled with the @option{-finstrument-control-flow} option +the ENDBR instruction also inserted at addresses to which indirect and typos, such as: +control-flow trasfer can happen. English is not my tongue, but these two popped out immediately. Other than that, -a program security by checking a target address of control-flow +a program security by checking target addresses of control-flow Spurious change. +@option{mshstk} options. Each of these options enables coresponding Missing dash, and a typo. +This option instructs the compiler to use only indirect branch tracking +(indirect calls and jumps) support from x86 Control-flow Enforcment Typo. +Technology (CET) implementation, see also @code{-mcet} option. The +option has effect only if @code{-finstrument-control-flow} option is +specified. The option @code{-mibt} is on by default when @code{-mcet} +option is specified. Please use @option{} for options. +This option instructs compiler to use only shadow stack (return address +tracking) support from x86 Control-flow Enforcment Technology (CET) +implementation, see also @code{-mcet} option. The option has effect +only if @code{-finstrument-control-flow} option is specified. The +option @code{-mshstk} is on by default when @code{-mcet} option is +specified. Also in the above text. Uros.