public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Uros Bizjak <ubizjak@gmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: David Malcolm <dmalcolm@redhat.com>, Bernd Schmidt <bschmidt@redhat.com>
Subject: Re: [PATCH] testsuite/lib/multline.exp: show test name and line numbers
Date: Tue, 29 Dec 2015 09:17:00 -0000	[thread overview]
Message-ID: <CAFULd4YG4fGkPzjNfciuWx3w+vHy1z9j-YY+azdhXUCBvUzWOA@mail.gmail.com> (raw)

Hello!

> Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu;
> I compared the results against a control build (of r231445), and
> the results were unchanged, other than the expected changes from
> the above, leading to
> - 92 PASS results changing name within g++.sum
> - 7 PASS results changing name within each of obj-c++.sum
>   and objc.sum, and
> - 125 PASS results changing name within gcc.sum.
>
> OK for trunk for gcc 6?
>
> gcc/testsuite/ChangeLog:
> * lib/multiline.exp (_multiline_expected_outputs): Update comment.
> (dg-end-multiline-output): Capture line numbers within
> _multiline_expected_outputs.
> (handle-multiline-outputs): Access global $testname_with_flags
> and add it as a prefix to pass/fail results.  Extract line numbers
> from $_multiline_expected_outputs and print them within pass/fail
> results, replacing the printing of $index.  Consolidate the
> string prefix shared between pass/fail into a new local: $title.

It looks that this new functionality doesn't handle conditional
compilation, when

/* { dg-do compile { target { ! ia32 } } } */

is added to the testcase, such as in recently changed
gcc.target/i386/pr68473-1.c.

The directive is passed to the next testcase, leading to spurious
testsuite failures [1] in unrelated testcases.

[1] https://gcc.gnu.org/ml/gcc-testresults/2015-12/msg02761.html

Uros.

             reply	other threads:[~2015-12-29  9:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29  9:17 Uros Bizjak [this message]
2016-01-07 12:11 ` Bernd Schmidt
2016-01-07 12:23   ` Uros Bizjak
2016-01-09  0:30     ` [PATCH] PR testsuite/69181: ensure expected multiline outputs is cleared per-test David Malcolm
2016-01-09  2:07       ` Bernd Schmidt
2016-01-12 19:34         ` David Malcolm
2016-01-13  6:21           ` Jeff Law
  -- strict thread matches above, loose matches on Subject: below --
2015-12-10 14:37 [PATCH] testsuite/lib/multline.exp: show test name and line numbers David Malcolm
2015-12-10 17:04 ` Bernd Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFULd4YG4fGkPzjNfciuWx3w+vHy1z9j-YY+azdhXUCBvUzWOA@mail.gmail.com \
    --to=ubizjak@gmail.com \
    --cc=bschmidt@redhat.com \
    --cc=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).