public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Uros Bizjak <ubizjak@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] i386: Correct *vec_extractv2si_zext_mem
Date: Sat, 16 Feb 2019 19:07:00 -0000	[thread overview]
Message-ID: <CAFULd4YHjy0VdwsZr0=bPckfAJ9_6Mn1cPyjBdyRj2q_1dAdWQ@mail.gmail.com> (raw)
In-Reply-To: <20190216154826.14413-1-hjl.tools@gmail.com>

On 2/16/19, H.J. Lu <hjl.tools@gmail.com> wrote:
> The second and third alternatives in *vec_extractv2si_zext_mem don't
> require MMX.  But the second one requires SSE2.
>
> 	* config/i386/mmx.md (*vec_extractv2si_zext_mem): Doesn't require
> 	MMX.  Add isa attribute.

OK.

Thanks,
Uros.

> ---
>  gcc/config/i386/mmx.md | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md
> index c1e0f2c411e..b566cc80020 100644
> --- a/gcc/config/i386/mmx.md
> +++ b/gcc/config/i386/mmx.md
> @@ -1354,13 +1354,14 @@
>  	  (vec_select:SI
>  	    (match_operand:V2SI 1 "memory_operand" "o,o,o")
>  	    (parallel [(match_operand:SI 2 "const_0_to_1_operand")]))))]
> -  "TARGET_64BIT && TARGET_MMX"
> +  "TARGET_64BIT"
>    "#"
>    "&& reload_completed"
>    [(set (match_dup 0) (zero_extend:DI (match_dup 1)))]
>  {
>    operands[1] = adjust_address (operands[1], SImode, INTVAL (operands[2]) *
> 4);
> -})
> +}
> +  [(set_attr "isa" "*,sse2,*")])
>
>  (define_expand "vec_extractv2sisi"
>    [(match_operand:SI 0 "register_operand")
> --
> 2.20.1
>
>

      reply	other threads:[~2019-02-16 19:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-16 15:48 H.J. Lu
2019-02-16 19:07 ` Uros Bizjak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFULd4YHjy0VdwsZr0=bPckfAJ9_6Mn1cPyjBdyRj2q_1dAdWQ@mail.gmail.com' \
    --to=ubizjak@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).