public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Uros Bizjak <ubizjak@gmail.com>
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [x86 PATCH] Allow SCmode and DImode to be tieable on TARGET_64BIT.
Date: Mon, 30 May 2022 22:13:54 +0200	[thread overview]
Message-ID: <CAFULd4YJG151_0+gkB9zM+a3+c8mshE6X+s1K33FXvzizqKDkQ@mail.gmail.com> (raw)
In-Reply-To: <CAFULd4afvMmQ_oM1U9-0gt-TFuhPRHnoxQpXk8_4u7EZY=73aQ@mail.gmail.com>

On Mon, May 30, 2022 at 10:12 PM Uros Bizjak <ubizjak@gmail.com> wrote:
>
> On Mon, May 30, 2022 at 3:22 PM Roger Sayle <roger@nextmovesoftware.com> wrote:
> >
> >
> > This patch is a form of insurance policy in case my patch for PR 7061 runs
> > into problems on non-x86 targets; the middle-end can add an extra check
> > that the backend is happy placing SCmode and DImode values in the same
> > register, before creating a SUBREG.  Unfortunately, ix86_modes_tieable_p
> > currently claims this is not allowed(?), even though the default target
> > hook for modes_tieable_p is to always return true [i.e. false can be
> > used to specifically prohibit bad combinations], and the x86_64 ABI
> > passes SCmode values in DImode registers!.  This makes the backend's
> > modes_tiable_p hook a little more forgiving, and additionally enables
> > interconversion between SCmode and V2SFmode, and between DCmode and
> > VD2Fmode, which opens interesting opportunities in the future.
> >
> > I believe there should currently be no code generation differences
> > with this change.  This patch has been tested on x86_64-pc-linux-gnu
> > with make bootstrap and make -k check, both with and without
> > --target_board=unix{-m32}, with no new failures.  Ok for mainline?
> >
> >
> > 2022-05-30  Roger Sayle  <roger@nextmovesoftware.com>
> >
> > gcc/ChangeLog
> >         * config/i386/i386.cc (ix86_modes_tieable_p): Allow SCmode to be
> >         tieable with DImode on TARGET_64BIT, and SCmode tieable with
> >         V2SFmode, and DCmode with V2DFmode.
>
> I *think* this is OK, but hard to say for sure without some testcases.
> Please note that x86_64 ABI passes SDmode in two separate XMM
> registers.

I meant DCmode here.

Uros.

      reply	other threads:[~2022-05-30 20:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-30 13:22 Roger Sayle
2022-05-30 20:12 ` Uros Bizjak
2022-05-30 20:13   ` Uros Bizjak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFULd4YJG151_0+gkB9zM+a3+c8mshE6X+s1K33FXvzizqKDkQ@mail.gmail.com \
    --to=ubizjak@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=roger@nextmovesoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).