From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by sourceware.org (Postfix) with ESMTPS id 504C938582B6 for ; Tue, 21 Jun 2022 07:06:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 504C938582B6 Received: by mail-qv1-xf2b.google.com with SMTP id p31so19060883qvp.5 for ; Tue, 21 Jun 2022 00:06:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4nLwfd5Mu8dNXWpWgA1UQKiW4HKI819DwSKuNl4r7ng=; b=s/R+N8QD9e5PlylKYa4q5E1Q8/bNxkdP5niBIcXDZsPupng1T+GBQI2tyYnSwTh0Po jTY3tdg7eRug+CXEXoxazYb4l060gSKq9rH3/dIT+3HX84PlWcm8VOx84a3frjH8JYe1 m57eTPKMA29pbeMwv/CR9ElKT1g3chLrravCmAcJ28W4viumGdsHcJYasv+/wNi9qAHi p/mZvWiApOswTv4Fxtwqkqu0PFwVHF01qZ7DrHLQOkE5y8p20tcvLXYhWpWSVylS6hrO 1HxMBHXVnojsxoXrgZR6PYAnBJKwDk3FRuAejJmsQybiGbSMzaXrkT59c7l78yMRqe4i xO4g== X-Gm-Message-State: AJIora/SAW4DIwUo4btR9OvKA0eoJrXiHB5z4XtjuUEkGGLg798XPj6K 59Tnc1LOjgkW02r97+9MGwDbHEwXNj9Ljqcaj1I= X-Google-Smtp-Source: AGRyM1t6COda1S21D+vK3nUAhg+iAn/HnfGrvxQxF3rHLtTNFUJqNpe9phF+kPFIxGV3DgpEnTY5izdNAxXa8LsNBow= X-Received: by 2002:ac8:5756:0:b0:306:721b:b19f with SMTP id 22-20020ac85756000000b00306721bb19fmr22571117qtx.54.1655795187692; Tue, 21 Jun 2022 00:06:27 -0700 (PDT) MIME-Version: 1.0 References: <20220620080442.735284-1-haochen.jiang@intel.com> In-Reply-To: From: Uros Bizjak Date: Tue, 21 Jun 2022 09:06:16 +0200 Message-ID: Subject: Re: [PATCH] i386: Add syscall to enable AMX for latest kernels To: "Jiang, Haochen" Cc: "gcc-patches@gcc.gnu.org" , "Liu, Hongtao" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2022 07:06:30 -0000 On Tue, Jun 21, 2022 at 4:23 AM Jiang, Haochen wrote: > > > -----Original Message----- > > From: Uros Bizjak > > Sent: Monday, June 20, 2022 10:54 PM > > To: Jiang, Haochen > > Cc: gcc-patches@gcc.gnu.org; Liu, Hongtao > > Subject: Re: [PATCH] i386: Add syscall to enable AMX for latest kernels > > > > On Mon, Jun 20, 2022 at 10:04 AM Haochen Jiang > > wrote: > > > > > > From: "Jiang, Haochen" > > > > > > Hi all, > > > > > > We need syscall to enable AMX for kernels>=5.4. It is missing in > > > current amx tests, which will cause test fail. > > > > So this new code is only valid for linux & co? > > Thanks for reminding me for that, I only test on linux since the header file is only in linux. > > Just updated a patch wrapping with a macro not to change the behavior on windows. I think you want __linux__ there, not __unix__. Uros. > > Regtested on x86_64-pc-linux-gnu. > > Thx, > Haochen > > > > Uros. > > > > > > > > This patch aims to add them to fix this bug. > > > > > > BRs, > > > Haochen > > > > > > gcc/testsuite/ChangeLog: > > > > > > * gcc.target/i386/amx-check.h (request_perm_xtile_data): > > > New function to check if AMX is usable and enable AMX. > > > (main): Run test if AMX is usable. > > > --- > > > gcc/testsuite/gcc.target/i386/amx-check.h | 24 > > > +++++++++++++++++++++++ > > > 1 file changed, 24 insertions(+) > > > > > > diff --git a/gcc/testsuite/gcc.target/i386/amx-check.h > > > b/gcc/testsuite/gcc.target/i386/amx-check.h > > > index 434b0e59703..92ed8669304 100644 > > > --- a/gcc/testsuite/gcc.target/i386/amx-check.h > > > +++ b/gcc/testsuite/gcc.target/i386/amx-check.h > > > @@ -4,11 +4,22 @@ > > > #include > > > #include > > > #include > > > +#include > > > +#include > > > #ifdef DEBUG > > > #include > > > #endif > > > #include "cpuid.h" > > > > > > +#define XFEATURE_XTILECFG 17 > > > +#define XFEATURE_XTILEDATA 18 > > > +#define XFEATURE_MASK_XTILECFG (1 << XFEATURE_XTILECFG) > > > +#define XFEATURE_MASK_XTILEDATA (1 << XFEATURE_XTILEDATA) > > > +#define XFEATURE_MASK_XTILE (XFEATURE_MASK_XTILECFG | > > XFEATURE_MASK_XTILEDATA) > > > + > > > +#define ARCH_GET_XCOMP_PERM 0x1022 > > > +#define ARCH_REQ_XCOMP_PERM 0x1023 > > > + > > > /* TODO: The tmm emulation is temporary for current > > > AMX implementation with no tmm regclass, should > > > be changed in the future. */ > > > @@ -44,6 +55,18 @@ typedef struct __tile > > > /* Stride (colum width in byte) used for tileload/store */ #define > > > _STRIDE 64 > > > > > > +/* We need syscall to use amx functions */ int > > > +request_perm_xtile_data() { > > > + unsigned long bitmask; > > > + > > > + if (syscall (SYS_arch_prctl, ARCH_REQ_XCOMP_PERM, > > XFEATURE_XTILEDATA) || > > > + syscall (SYS_arch_prctl, ARCH_GET_XCOMP_PERM, &bitmask)) > > > + return 0; > > > + > > > + return (bitmask & XFEATURE_MASK_XTILE) != 0; } > > > + > > > /* Initialize tile config by setting all tmm size to 16x64 */ void > > > init_tile_config (__tilecfg_u *dst) { @@ -186,6 +209,7 @@ main () > > > #ifdef AMX_BF16 > > > && __builtin_cpu_supports ("amx-bf16") #endif > > > + && request_perm_xtile_data () > > > ) > > > { > > > DO_TEST (); > > > -- > > > 2.18.2 > > >