From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-396426-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 127712 invoked by alias); 30 Apr 2015 06:12:26 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 127699 invoked by uid 89); 30 Apr 2015 06:12:26 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-oi0-f42.google.com
Received: from mail-oi0-f42.google.com (HELO mail-oi0-f42.google.com) (209.85.218.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 30 Apr 2015 06:12:25 +0000
Received: by oign205 with SMTP id n205so40182461oig.2        for <gcc-patches@gcc.gnu.org>; Wed, 29 Apr 2015 23:12:23 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.202.83.202 with SMTP id h193mr2096645oib.56.1430374343049; Wed, 29 Apr 2015 23:12:23 -0700 (PDT)
Received: by 10.60.147.170 with HTTP; Wed, 29 Apr 2015 23:12:22 -0700 (PDT)
In-Reply-To: <CABtf2+TqLWgJr5od3pETcV3W7ZQ7-sm9zQXjVc6z0MBhGwGuZQ@mail.gmail.com>
References: <CAFULd4anFuykMh6ZmDhJ7QM_5enEpR=1p=S5n5gRgcHHpR1zmA@mail.gmail.com>	<CABtf2+Q-fqDMUwCBY5WdoRYnyOh+MOB9G8HQh9+e3U_wHRjpoQ@mail.gmail.com>	<CAFULd4b9B5LD1khwkefwnLfarjJMMTayS=_uxaheiXPhjGj3CQ@mail.gmail.com>	<CAFULd4Y4KnrkzuSKxsdkmHuMmZ-qzQvjR80BB44AP-SEiq=RLQ@mail.gmail.com>	<CABtf2+Rnjp7f+wHUpn_E2dti-CkYTMk28puyH-EL1=5ep-brKA@mail.gmail.com>	<CABtf2+TqLWgJr5od3pETcV3W7ZQ7-sm9zQXjVc6z0MBhGwGuZQ@mail.gmail.com>
Date: Thu, 30 Apr 2015 06:40:00 -0000
Message-ID: <CAFULd4YbMsxuOQko2jy7LdxiL0Ob=fR5v4qCXOEM80iPHE=1cA@mail.gmail.com>
Subject: Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)
From: Uros Bizjak <ubizjak@gmail.com>
To: Caroline Tice <cmtice@google.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, Jeff Law <law@redhat.com>, 	Richard Henderson <rth@redhat.com>
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2015-04/txt/msg01966.txt.bz2

On Wed, Apr 29, 2015 at 11:22 PM, Caroline Tice <cmtice@google.com> wrote:
> Here is a new patch to update the cold name partition so that it will
> only be treated like a function name and be given a size on the
> architectures that specifically define macros for such.
>
> I also updated the test case to try to only test on the appropriate
> architectures.  I am not sure I got the target triples correct for
> this, so I would appreciate some extra attention to that in the
> review.  I have tested this new patch on my workstation and it works
> as intended.  I am in the process of bootstrapping with the new patch.
> Assuming that the bootstrap passes, is this ok to commit?
>
> -- Caroline Tice
> cmtice@google.com
>
> ChangeLog (gcc):
>
> 2015-04-29  Caroline Tice  <cmtice@google.com>
>
>         PR 65929
>         * config/elfos.h (ASM_DECLARE_COLD_FUNCTION_NAME): New macro definition.
>         (ASM_DECLARE_COLD_FUNCTION_SIZE): New macro definition.
>         * final.c (final_scan_insn):  Use ASM_DECLARE_COLD_FUNCTION_NAME
>         instead of ASM_DECLARE_FUNCTION_NAME for cold partition name.
>         * varasm.c (assemble_end_function):  Use ASM_DECLARE_COLD_FUNCTION_SIZE
>         instead of ASM_DECLARE_FUNCTION_SIZE for cold partition size.
>
> ChangeLog (testsuite):
>
> 2015-04-29  Caroline Tice  <cmtice@google.com>
>
>        PR  65929
>         * gcc.dg/tree-prof/cold_partition_label.c:  Only check for cold
>         partition size on certain targets.

Documentation for new macros is missing (please see doc/tm.texi.in).

Uros.