public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Uros Bizjak <ubizjak@gmail.com>
To: liuhongt <hongtao.liu@intel.com>
Cc: gcc-patches@gcc.gnu.org, crazylht@gmail.com, hjl.tools@gmail.com
Subject: Re: [PATCH 1/2] Don't issue vzeroupper for vzeroupper call_insn.
Date: Tue, 27 Jun 2023 08:04:53 +0200	[thread overview]
Message-ID: <CAFULd4Ych9cxnzT9AdYi=bjngWAiuiH8pgEsDApAX4_eDxqJhQ@mail.gmail.com> (raw)
In-Reply-To: <20230627055312.2881827-1-hongtao.liu@intel.com>

On Tue, Jun 27, 2023 at 7:55 AM liuhongt <hongtao.liu@intel.com> wrote:
>
> Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}.
> Ok for trunk?
>
> gcc/ChangeLog:
>
>         PR target/82735
>         * config/i386/i386.cc (ix86_avx_u127_mode_needed): Don't emit
>         vzeroupper for vzeroupper call_insn.
>
> gcc/testsuite/ChangeLog:
>
>         * gcc.target/i386/avx-vzeroupper-30.c: New test.
> ---
>  gcc/config/i386/i386.cc                           |  5 +++--
>  gcc/testsuite/gcc.target/i386/avx-vzeroupper-30.c | 15 +++++++++++++++
>  2 files changed, 18 insertions(+), 2 deletions(-)
>  create mode 100644 gcc/testsuite/gcc.target/i386/avx-vzeroupper-30.c
>
> diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
> index 0761965344b..caca74d6dec 100644
> --- a/gcc/config/i386/i386.cc
> +++ b/gcc/config/i386/i386.cc
> @@ -14489,8 +14489,9 @@ ix86_avx_u128_mode_needed (rtx_insn *insn)
>          modes wider than 256 bits.  It's only safe to issue a
>          vzeroupper if all SSE registers are clobbered.  */
>        const function_abi &abi = insn_callee_abi (insn);
> -      if (!hard_reg_set_subset_p (reg_class_contents[SSE_REGS],
> -                                 abi.mode_clobbers (V4DImode)))
> +      if (vzeroupper_pattern (PATTERN (insn), VOIDmode)
> +         || !hard_reg_set_subset_p (reg_class_contents[SSE_REGS],
> +                                    abi.mode_clobbers (V4DImode)))
>         return AVX_U128_ANY;

You also want to check for vzeroall_pattern here.

OK with the above change.

Thanks,
Uros.

>
>        return AVX_U128_CLEAN;
> diff --git a/gcc/testsuite/gcc.target/i386/avx-vzeroupper-30.c b/gcc/testsuite/gcc.target/i386/avx-vzeroupper-30.c
> new file mode 100644
> index 00000000000..c1c9baa8fc4
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/i386/avx-vzeroupper-30.c
> @@ -0,0 +1,15 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -mavx -mvzeroupper -dp" } */
> +
> +#include <immintrin.h>
> +
> +extern __m256 x, y;
> +
> +void
> +foo ()
> +{
> +  x = y;
> +  _mm256_zeroupper ();
> +}
> +
> +/* { dg-final { scan-assembler-times "avx_vzeroupper" 1 } } */
> --
> 2.39.1.388.g2fc9e9ca3c
>

  parent reply	other threads:[~2023-06-27  6:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27  5:53 liuhongt
2023-06-27  5:53 ` [PATCH 2/2] Make option mvzeroupper independent of optimization level liuhongt
2023-06-27  6:05   ` Uros Bizjak
2023-06-27  6:08     ` Hongtao Liu
2023-06-27  6:11       ` Uros Bizjak
2023-06-27  6:04 ` Uros Bizjak [this message]
2023-06-27  6:07   ` [PATCH 1/2] Don't issue vzeroupper for vzeroupper call_insn Hongtao Liu
2023-06-27  6:11     ` Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFULd4Ych9cxnzT9AdYi=bjngWAiuiH8pgEsDApAX4_eDxqJhQ@mail.gmail.com' \
    --to=ubizjak@gmail.com \
    --cc=crazylht@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=hongtao.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).