From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by sourceware.org (Postfix) with ESMTPS id 215CE386C583 for ; Tue, 28 Jun 2022 06:53:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 215CE386C583 Received: by mail-qv1-xf33.google.com with SMTP id u14so16078981qvv.2 for ; Mon, 27 Jun 2022 23:53:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pph43ArfgXIb78MFMMLvkx6l9Le38argKkUyyYWD3xw=; b=hTYNDRMWrUdnIplHq+Vaks6SQPAZfFTSv11JDDFA1BarIQJDyEqeWgzaWBhVvrDbnB 79dAdFkA7LVqimpQ0tDA3JPqVcyBadHUwmGzl8+zvqnk/x5phQCdwpbQDGRRKQMmoCGX Ax/+IdprVQgGHefE5uR3GIObaREs5s6hFfmz/cYzY4pvt7AbO78rNTPw5weGfW52bs5y NjcZunyawJKctn4SfdjwGf1G/VirHwo80So6Vbk/jY7bUPSmfaiqLpZJmM4RYV1XHhxF a6IOzbiM7HZnVQGERqWwnp1v7AxvkIOaCfVd7/8EV+d2/45ClPdHLs2HePSRpEJRSRzh 13qw== X-Gm-Message-State: AJIora9AX4K6iAx24JhhFKjaOCvAEU0PlPsFedXGtRyqDj3UhJC7Ge2B Q1+G5yqAMk3N18HML1104ZCUqQ8Lv6U1SHpafq0= X-Google-Smtp-Source: AGRyM1vQD0JemdqfrqP166sii66TV3Hx28OqLnzMjPAMhKb+BgvV7qXfwERTsaVs6ECWEojzbK5D/0McGH0Oxz0BUIU= X-Received: by 2002:a05:622a:ce:b0:305:a10:4464 with SMTP id p14-20020a05622a00ce00b003050a104464mr12017457qtw.5.1656399211465; Mon, 27 Jun 2022 23:53:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Uros Bizjak Date: Tue, 28 Jun 2022 08:53:20 +0200 Message-ID: Subject: Re: [PATCH] testsuite/ix86: SSE2 is a prereq to _Float16 use To: Jan Beulich Cc: "gcc-patches@gcc.gnu.org" , Jan Hubicka , Kirill Yukhin , Hongtao Liu Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 06:53:33 -0000 On Tue, Jun 28, 2022 at 8:49 AM Jan Beulich wrote: > > When enabling AVX512FP via attribute or pragma, the _Float16 type would > remain unavailable when at initialization time SSE2 wouldn't be seen as > available for use. While this may hint at a wider underlying issue (like > the feature, the type may want providing dynamically, albeit this may be > challenging in particular for functions returning _Float16 yet having > the attribute specified after their return type), for now simply make > SSE2 available when targeting ix86. > > gcc/testsuite/ > > * gcc.target/i386/avx512fp16-reduce-op-2.c: Force SSE2 for i?86. > * gcc.target/i386/pr99464.c: Likewise. OK. Thanks, Uros. > > --- a/gcc/testsuite/gcc.target/i386/avx512fp16-reduce-op-2.c > +++ b/gcc/testsuite/gcc.target/i386/avx512fp16-reduce-op-2.c > @@ -1,5 +1,6 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -mprefer-vector-width=512 -fdump-tree-optimized" } */ > +/* { dg-additional-options "-msse2" { target i?86-*-* } } */ > > /* { dg-final { scan-tree-dump-times "\.REDUC_PLUS" 3 "optimized" } } */ > /* { dg-final { scan-tree-dump-times "\.REDUC_MIN" 3 "optimized" } } */ > --- a/gcc/testsuite/gcc.target/i386/pr99464.c > +++ b/gcc/testsuite/gcc.target/i386/pr99464.c > @@ -1,6 +1,7 @@ > /* PR target/99464 */ > /* { dg-do compile } */ > /* { dg-options "-O2" } */ > +/* { dg-additional-options "-msse2" { target i?86-*-* } } */ > > #pragma GCC target("arch=cannonlake") >