public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Uros Bizjak <ubizjak@gmail.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	Rainer Orth <ro@cebitec.uni-bielefeld.de>,
		Eric Botcazou <ebotcazou@adacore.com>,
	"H. J. Lu" <hjl.tools@gmail.com>,
		Jonathan Yong <10walls@gmail.com>,
	bug-hurd@gnu.org, debian-bsd@lists.debian.org
Subject: [PATCH, i386]: --enable-frame-pointer for cygwin and mingw
Date: Mon, 13 May 2019 10:16:00 -0000	[thread overview]
Message-ID: <CAFULd4YmrSczmXrXkS8TuWDmeVtKAEA0YSDgkxo1EZMh0NA8ug@mail.gmail.com> (raw)
In-Reply-To: <87zhnwdkaa.fsf@euler.schwinge.homeip.net>

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

On Thu, May 9, 2019 at 11:55 AM Thomas Schwinge <thomas@codesourcery.com> wrote:

> On Sun, 10 Feb 2019 20:51:39 +0100, Uros Bizjak <ubizjak@gmail.com> wrote:
> > On Fri, Feb 8, 2019 at 1:24 PM Uros Bizjak <ubizjak@gmail.com> wrote:
> > > Attached patch fixes --enable-frame-pointer handling [...]
>
> ACK.
>
> > Please note that this fix will re-enable frame pointer for all targets
> > but linux* or darwin[[8912]]. However, since builds for e.g. cygwin
> > and mingw survived just well without frame pointers in the mean time,
> > we should probably list these targets as targets without frame
> > pointers by default.
>
> I agree, this would cause the least surprise, to simply keep the previous
> default of '--disable-frame-pointer'.  Until such a global change is
> agreed on, and made...

I plan to commit the attached patch later today.

2019-05-13  Uroš Bizjak  <ubizjak@gmail.com>

    PR target/89221
    * configure.ac (--enable-frame-pointer):
    Disable by default for cygwin and mingw.
    * configure: Regenerate.

Uros.

[-- Attachment #2: p.diff.txt --]
[-- Type: text/plain, Size: 884 bytes --]

diff --git a/gcc/configure b/gcc/configure
index 947d263a6174..3cab176e5018 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -12197,7 +12197,7 @@ if test "${enable_frame_pointer+set}" = set; then :
 else
 
 case $target_os in
-linux* | gnu* | darwin[8912]*)
+linux* | gnu* | darwin[8912]* | cygwin* | mingw*)
   # Enable -fomit-frame-pointer by default for these systems with DWARF2.
   enable_frame_pointer=no
   ;;
diff --git a/gcc/configure.ac b/gcc/configure.ac
index bfcdf526e446..264f36fb78a8 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -1884,7 +1884,7 @@ AC_ARG_ENABLE(frame-pointer,
 		[enable -fno-omit-frame-pointer by default for x86])], [],
 [
 case $target_os in
-linux* | gnu* | darwin[[8912]]*)
+linux* | gnu* | darwin[[8912]]* | cygwin* | mingw*)
   # Enable -fomit-frame-pointer by default for these systems with DWARF2.
   enable_frame_pointer=no
   ;;

      reply	other threads:[~2019-05-13 10:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 12:25 [PATCH, i386]: Fix PR89221, --enable-frame-pointer does not work as intended Uros Bizjak
2019-02-10 19:52 ` [PATCH v2, " Uros Bizjak
2019-02-11  8:25   ` Rainer Orth
2019-05-06 15:00     ` Uros Bizjak
2019-05-09  9:55   ` [committed] [PR89221] Continue to default to '--disable-frame-pointer' for x86 GNU systems (was: [PATCH v2, i386]: Fix PR89221, --enable-frame-pointer does not work as intended) Thomas Schwinge
2019-05-13 10:16     ` Uros Bizjak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFULd4YmrSczmXrXkS8TuWDmeVtKAEA0YSDgkxo1EZMh0NA8ug@mail.gmail.com \
    --to=ubizjak@gmail.com \
    --cc=10walls@gmail.com \
    --cc=bug-hurd@gnu.org \
    --cc=debian-bsd@lists.debian.org \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=ro@cebitec.uni-bielefeld.de \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).