Re: [Patch] PR71017 - libgcc/config/i386/cpuinfo.c:346:17: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'

Re: [Patch] PR71017 - libgcc/config/i386/cpuinfo.c:346:17: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'

[Uros Bizjak]

Hello!

> The following patch fixes errors of the kind
>
> libgcc/config/i386/cpuinfo.c:260:17: runtime error: left shift of 1 by 31 places cannot be
>  represented in type ‘int'
>
> 2017-01-07  Dominique d'Humieres  <dominiq@lps.ens.fr>
>
>         PR target/71017
>         * config/i386/cpuid.h: Fix undefined behavior.

> Is it OK for trunk/branches?

OK.

Thanks,
Uros.

Re: [Patch] PR71017 - libgcc/config/i386/cpuinfo.c:346:17: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'

[Dominique d'Humières]

> Le 9 janv. 2017 à 20:37, Uros Bizjak <ubizjak@gmail.com> a écrit :
> 
> Hello!
> 
>> The following patch fixes errors of the kind
>> 
>> libgcc/config/i386/cpuinfo.c:260:17: runtime error: left shift of 1 by 31 places cannot be
>> represented in type ‘int'
>> 
>> 2017-01-07  Dominique d'Humieres  <dominiq@lps.ens.fr>
>> 
>>        PR target/71017
>>        * config/i386/cpuid.h: Fix undefined behavior.
> 
>> Is it OK for trunk/branches?
> 
> OK.
> 
> Thanks,
> Uros.

Thanks, committed on the trunk as revision r244248. Is it OK for the 5 and 6 branches?

Dominique

Fwd: [Patch] PR71017 - libgcc/config/i386/cpuinfo.c:346:17: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'

[Uros Bizjak]

On Mon, Jan 9, 2017 at 11:05 PM, Dominique d'Humières
<dominiq@lps.ens.fr> wrote:

>
> > Le 9 janv. 2017 à 20:37, Uros Bizjak <ubizjak@gmail.com> a écrit :
> >
> > Hello!
> >
> >> The following patch fixes errors of the kind
> >>
> >> libgcc/config/i386/cpuinfo.c:260:17: runtime error: left shift of 1 by 31 places cannot be
> >> represented in type ‘int'
> >>
> >> 2017-01-07  Dominique d'Humieres  <dominiq@lps.ens.fr>
> >>
> >>        PR target/71017
> >>        * config/i386/cpuid.h: Fix undefined behavior.
> >
> >> Is it OK for trunk/branches?
>
>
> Thanks, committed on the trunk as revision r244248. Is it OK for the 5 and 6 branches?

Yes, but please wait a couple of days if any problem arises with patch
in mainline.

Uros.

[Patch] PR71017 - libgcc/config/i386/cpuinfo.c:346:17: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'

[Dominique d'Humières]

The following patch fixes errors of the kind

libgcc/config/i386/cpuinfo.c:260:17: runtime error: left shift of 1 by 31 places cannot be represented in type ‘int'

2017-01-07  Dominique d'Humieres  <dominiq@lps.ens.fr>

        PR target/71017
        * config/i386/cpuid.h: Fix undefined behavior.

--- ../_clean/gcc/config/i386/cpuid.h	2017-01-01 17:39:04.000000000 +0100
+++ gcc/config/i386/cpuid.h	2017-01-05 15:22:31.000000000 +0100
@@ -91,7 +91,7 @@
 #define bit_AVX512CD	(1 << 28)
 #define bit_SHA		(1 << 29)
 #define bit_AVX512BW	(1 << 30)
-#define bit_AVX512VL	(1 << 31)
+#define bit_AVX512VL	(1u << 31)
 
 /* %ecx */
 #define bit_PREFETCHWT1	  (1 << 0)

Is it OK for trunk/branches?

TIA

Dominique