From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117840 invoked by alias); 29 Apr 2015 21:07:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117831 invoked by uid 89); 29 Apr 2015 21:07:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f47.google.com Received: from mail-oi0-f47.google.com (HELO mail-oi0-f47.google.com) (209.85.218.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 29 Apr 2015 21:07:52 +0000 Received: by oica37 with SMTP id a37so32619331oic.0 for ; Wed, 29 Apr 2015 14:07:50 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.211.129 with SMTP id k123mr778048oig.43.1430341669928; Wed, 29 Apr 2015 14:07:49 -0700 (PDT) Received: by 10.60.147.170 with HTTP; Wed, 29 Apr 2015 14:07:49 -0700 (PDT) In-Reply-To: References: Date: Wed, 29 Apr 2015 21:22:00 -0000 Message-ID: Subject: Re: [PATCH, i386]: Fix PR 65871, bzhi builtin/intrinsic wrongly assumes bzhi instruction doesn't set the ZF flag From: Uros Bizjak To: "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary=001a113df41425157d0514e35f36 X-SW-Source: 2015-04/txt/msg01932.txt.bz2 --001a113df41425157d0514e35f36 Content-Type: text/plain; charset=UTF-8 Content-length: 735 On Wed, Apr 29, 2015 at 9:02 PM, Uros Bizjak wrote: > Hello! > > Attached patch implements a CCZ-only setting pattern for a couple of > BMI[,2] intrinsics. These two insns are three operand instructions, and some peephole2 patterns were not prepared for this. Please note that clobbered register can be different than input registers. Attached patch fixes this omission. 2015-04-29 Uros Bizjak PR target/65871 * config/i386/i386.md (*bmi_bextr__cczonly): New pattern. (*bmi2_bzhi_3_1_cczonly): Ditto. (setcc+movzbl peephole2): Check also clobbered reg. (setcc+andl peephole2): Ditto. Tested on x86_64-linux-gnu {,-m32} and committed to mainline SVN. Uros. --001a113df41425157d0514e35f36 Content-Type: text/plain; charset=US-ASCII; name="p.diff.txt" Content-Disposition: attachment; filename="p.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i938hnno1 Content-length: 1546 SW5kZXg6IGNvbmZpZy9pMzg2L2kzODYubWQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gY29uZmlnL2kzODYvaTM4Ni5tZAkocmV2aXNpb24gMjIyNTkw KQorKysgY29uZmlnL2kzODYvaTM4Ni5tZAkod29ya2luZyBjb3B5KQpAQCAt MTE1NjcsNyArMTE1NjcsOSBAQAogCSh6ZXJvX2V4dGVuZCAobWF0Y2hfZHVw IDEpKSldCiAgICIocGVlcDJfcmVnX2RlYWRfcCAoMywgb3BlcmFuZHNbMV0p CiAgICAgfHwgb3BlcmFuZHNfbWF0Y2hfcCAob3BlcmFuZHNbMV0sIG9wZXJh bmRzWzNdKSkKLSAgICYmICEgcmVnX292ZXJsYXBfbWVudGlvbmVkX3AgKG9w ZXJhbmRzWzNdLCBvcGVyYW5kc1swXSkiCisgICAmJiAhIHJlZ19vdmVybGFw X21lbnRpb25lZF9wIChvcGVyYW5kc1szXSwgb3BlcmFuZHNbMF0pCisgICAm JiAhIChHRVRfQ09ERSAob3BlcmFuZHNbNF0pID09IENMT0JCRVIKKwkgJiYg cmVnX21lbnRpb25lZF9wIChvcGVyYW5kc1szXSwgb3BlcmFuZHNbNF0pKSIK ICAgWyhwYXJhbGxlbCBbKHNldCAobWF0Y2hfZHVwIDUpIChtYXRjaF9kdXAg MCkpCiAJICAgICAgKG1hdGNoX2R1cCA0KV0pCiAgICAoc2V0IChzdHJpY3Rf bG93X3BhcnQgKG1hdGNoX2R1cCA2KSkKQEAgLTExNjEwLDcgKzExNjEyLDkg QEAKIAkgICAgICAoY2xvYmJlciAocmVnOkNDIEZMQUdTX1JFRykpXSldCiAg ICIocGVlcDJfcmVnX2RlYWRfcCAoMywgb3BlcmFuZHNbMV0pCiAgICAgfHwg b3BlcmFuZHNfbWF0Y2hfcCAob3BlcmFuZHNbMV0sIG9wZXJhbmRzWzNdKSkK LSAgICYmICEgcmVnX292ZXJsYXBfbWVudGlvbmVkX3AgKG9wZXJhbmRzWzNd LCBvcGVyYW5kc1swXSkiCisgICAmJiAhIHJlZ19vdmVybGFwX21lbnRpb25l ZF9wIChvcGVyYW5kc1szXSwgb3BlcmFuZHNbMF0pCisgICAmJiAhIChHRVRf Q09ERSAob3BlcmFuZHNbNF0pID09IENMT0JCRVIKKwkgJiYgcmVnX21lbnRp b25lZF9wIChvcGVyYW5kc1szXSwgb3BlcmFuZHNbNF0pKSIKICAgWyhwYXJh bGxlbCBbKHNldCAobWF0Y2hfZHVwIDUpIChtYXRjaF9kdXAgMCkpCiAJICAg ICAgKG1hdGNoX2R1cCA0KV0pCiAgICAoc2V0IChzdHJpY3RfbG93X3BhcnQg KG1hdGNoX2R1cCA2KSkK --001a113df41425157d0514e35f36--