From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ubizjak@gmail.com>
Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com
 [IPv6:2607:f8b0:4864:20::72b])
 by sourceware.org (Postfix) with ESMTPS id 3842B38515FF
 for <gcc-patches@gcc.gnu.org>; Thu, 25 Mar 2021 13:46:06 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3842B38515FF
Received: by mail-qk1-x72b.google.com with SMTP id 7so1739802qka.7
 for <gcc-patches@gcc.gnu.org>; Thu, 25 Mar 2021 06:46:06 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=NUkOnAMONA2IzPzGKGuB/yMbliJ3L44bFZxgk5lBQqc=;
 b=nndZ0vGcYA3W8Mhnlp/ch9e7pnMAlA9c2M4ZhfW1EEjPvgYQlrKCgnDdC+CmnEdWBm
 iWaKdQiooyG4cAHj/TLX8j4Sg598oKNQ8o2Ejd+cVn2rHj7zWVPtyRcd99tP31yt29jc
 cuWusKWyafxnZbPUvZF8hd2aAqI2IMwtkMm7CaS7PwMY/wIO2krAb4+ZdX1ru2KtiVqr
 6jr5RHr8Hnk5Jut5yrVmaheHfKvqtVz+/yB/Qc1phvKadJnSrbJZr0/CXU0HHaP4fUA/
 KJ1/a0otJgLd4ODJFXyhqOYhetT0TZr5mf2Dd5n2HM8XOSAErCoYYDtWwQcekHnmJTxE
 R/7g==
X-Gm-Message-State: AOAM531ci7jU7ovPdVA7i2HecjbZL8V1sdC6sXWe6b9qHk9ePDVz7fEA
 OQf4alFrpCrecmTLJ9XfpWrf1vEQX4t9n2IE3Y4=
X-Google-Smtp-Source: ABdhPJySl05VhmZm5AzLgGQafIYaKLGvfd2+2TtPnyki7sRRlC1ejdoTk049zg0ZZa/aTenm8dn2/+XU8rsyGXd3BPk=
X-Received: by 2002:a37:bb42:: with SMTP id l63mr1758586qkf.127.1616679965732; 
 Thu, 25 Mar 2021 06:46:05 -0700 (PDT)
MIME-Version: 1.0
References: <20210324172344.153078-1-hjl.tools@gmail.com>
 <CAFULd4bsXwvuTKFRQeEPaBw98+Q7pRvvOE6BNUgRJzxif9FEpw@mail.gmail.com>
In-Reply-To: <CAFULd4bsXwvuTKFRQeEPaBw98+Q7pRvvOE6BNUgRJzxif9FEpw@mail.gmail.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Thu, 25 Mar 2021 14:45:54 +0100
Message-ID: <CAFULd4YpWfz=fJ8BhDBZGNvtU_CqLKfKOx6cygz6d5uc+8DZ7w@mail.gmail.com>
Subject: Re: [PATCH] x86: Skip ISA check for always_inline in system headers
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
 Jakub Jelinek <jakub@redhat.com>, Richard Biener <rguenther@suse.de>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Mar 2021 13:46:07 -0000

On Thu, Mar 25, 2021 at 7:59 AM Uros Bizjak <ubizjak@gmail.com> wrote:
>
> On Wed, Mar 24, 2021 at 6:23 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > For always_inline in system headers, we don't know if caller's ISAs are
> > compatible with callee's ISAs until much later.  Skip ISA check for
> > always_inline in system headers if caller has target attribute.
> >
> > gcc/
> >
> >         PR target/98209
> >         PR target/99744
> >         * config/i386/i386.c (ix86_can_inline_p): Don't check ISA for
> >         always_inline in system headers.
> >
> > gcc/testsuite/
> >
> >         PR target/98209
> >         PR target/99744
> >         * gcc.target/i386/pr98209.c: New test.
> >         * gcc.target/i386/pr99744-1.c: Likewise.
> >         * gcc.target/i386/pr99744-2.c: Likewise.
>
> LGTM.

It looks to me that this patch needs some more discussion, and the
solution isn't clear at all.

HJ, can you please revert the patch?

Thanks,
Uros.