From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by sourceware.org (Postfix) with ESMTPS id B86A03858C54 for ; Fri, 12 May 2023 17:52:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B86A03858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-61aecee26feso47680956d6.2 for ; Fri, 12 May 2023 10:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683913948; x=1686505948; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=T5mIzsHsc/1ZFexksC4W5Ac3yhHPO061gdhsFBDURUg=; b=njIlTwGVyoIi0nhfez9JmIXsnoKJ1D9k6rMhOqpSC5F41sVHwVKQBguWHYj23saY8p eSXr+wc4hVpX6dwIr8+9QlmgeUY+3Q23vv/yS821ITUICSHVr8uXq1LRY+sQEgFk//1w IBnADe761auTMS50PKrVkv1GhbgbSlhE0OEVU8BBPRAN/F6j5jiI1PEb8HGGj3QieXn4 G80ORbCRdiIm0cMIW0gIYdKN5iqOAnM7UVhI3aKCdjR5oP4yIFlB/fgrs1X+FdrAcyL2 DmcrUU7MJnqWiCwRGvy85qiMWIFOok0XPY5vUJijZTLbxxZ60ZDy0XPce5evWmFxGY1e dyjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683913948; x=1686505948; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=T5mIzsHsc/1ZFexksC4W5Ac3yhHPO061gdhsFBDURUg=; b=TJCMglVXYY9aE+SzV5/1p1tMJ171nvdvUuSB84w4H2a47GkPjQ6mBEUT0CuT7iO5YN 0qFxIJKmbFlnDV+67r5sUA6030+MbrCu/chbyNlNn2rEFnvjyLh86uwR9W3I/JR2r+j9 bPfhc2u+egGYxbRpoZ+ytbv5+ElijkBihOb767dcs1KQFCJyhHqvzzgW/2JMl0WL2ZVS jmNXop8Qwh4f9xybf+L6GMch88W2HIiDYh425RfWAkGdOxf5+LrGK9ApoJC4XYwBtzWY +bJYy4er8TiN7uo/fvIU7URbpXILnf/BjY7VAwsCzeRq3TmYKQ1uZ0gcgkRx75aSPg4x +MOA== X-Gm-Message-State: AC+VfDyMXTtcrxru7vLFYz8YgBD+EVU47IhlN7QTL/Sy0vKmPUwb5pQq lB1fWHXosNU9R89SBCq5cQL0apBABB8Jqutdc5uUJZ4fCmT9lA== X-Google-Smtp-Source: ACHHUZ52Wp3thPpDFX8L6hUYDMhqGjfUSSYZlXpfjAVz7fWEOVb6KVaDtUfxH5tOOSSTpG7vA9LUd6Qws5FkrXP14D8= X-Received: by 2002:a05:6214:62b:b0:621:431e:5409 with SMTP id a11-20020a056214062b00b00621431e5409mr25758337qvx.16.1683913948581; Fri, 12 May 2023 10:52:28 -0700 (PDT) MIME-Version: 1.0 From: Uros Bizjak Date: Fri, 12 May 2023 19:52:17 +0200 Message-ID: Subject: [PATCH] i386: Cleanup ix86_expand_vecop_qihi{,2} To: "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary="000000000000bd0b9c05fb82c4ea" X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000bd0b9c05fb82c4ea Content-Type: text/plain; charset="UTF-8" Some cleanups while looking at these two functions. gcc/ChangeLog: * config/i386/i386-expand.cc (ix86_expand_vecop_qihi2): Also reject ymm instructions for TARGET_PREFER_AVX128. Use generic gen_extend_insn to generate zero/sign extension instructions. Fix comments. (ix86_expand_vecop_qihi): Initialize interleave functions for MULT code only. Fix comments. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Pushed to master. Uros. --000000000000bd0b9c05fb82c4ea Content-Type: text/plain; charset="US-ASCII"; name="p.diff.txt" Content-Disposition: attachment; filename="p.diff.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lhkuvnjg0 ZGlmZiAtLWdpdCBhL2djYy9jb25maWcvaTM4Ni9pMzg2LWV4cGFuZC5jYyBiL2djYy9jb25maWcv aTM4Ni9pMzg2LWV4cGFuZC5jYwppbmRleCA2MzRmZTYxYmE3OS4uOGE4NjllYjNiMzAgMTAwNjQ0 Ci0tLSBhL2djYy9jb25maWcvaTM4Ni9pMzg2LWV4cGFuZC5jYworKysgYi9nY2MvY29uZmlnL2kz ODYvaTM4Ni1leHBhbmQuY2MKQEAgLTIzMTIyLDEyICsyMzEyMiwxMSBAQCBpeDg2X2V4cGFuZF92 ZWNvcF9xaWhpMiAoZW51bSBydHhfY29kZSBjb2RlLCBydHggZGVzdCwgcnR4IG9wMSwgcnR4IG9w MikKIHsKICAgbWFjaGluZV9tb2RlIGhpbW9kZSwgcWltb2RlID0gR0VUX01PREUgKGRlc3QpOwog ICBydHggaG9wMSwgaG9wMiwgaGRlc3Q7Ci0gIHJ0eCAoKmdlbl9leHRlbmQpKHJ0eCwgcnR4KTsK ICAgcnR4ICgqZ2VuX3RydW5jYXRlKShydHgsIHJ0eCk7CiAgIGJvb2wgdW5zX3AgPSAoY29kZSA9 PSBBU0hJRlRSVCkgPyBmYWxzZSA6IHRydWU7CiAKLSAgLyogVGhlcmUncyBubyBWNjRISW1vZGUg bXVsdGlwbGljYXRpb24gaW5zdHJ1Y3Rpb24uICAqLwotICBpZiAocWltb2RlID09IEVfVjY0UUlt b2RlKQorICAvKiBUaGVyZSBhcmUgbm8gVjY0SEltb2RlIGluc3RydWN0aW9ucy4gICovCisgIGlm IChxaW1vZGUgPT0gVjY0UUltb2RlKQogICAgIHJldHVybiBmYWxzZTsKIAogICAvKiB2cG1vdndi IG9ubHkgYXZhaWxhYmxlIHVuZGVyIEFWWDUxMkJXLiAgKi8KQEAgLTIzMTM2LDI2ICsyMzEzNSwy NCBAQCBpeDg2X2V4cGFuZF92ZWNvcF9xaWhpMiAoZW51bSBydHhfY29kZSBjb2RlLCBydHggZGVz dCwgcnR4IG9wMSwgcnR4IG9wMikKICAgaWYgKChxaW1vZGUgPT0gVjhRSW1vZGUgfHwgcWltb2Rl ID09IFYxNlFJbW9kZSkKICAgICAgICYmICFUQVJHRVRfQVZYNTEyVkwpCiAgICAgcmV0dXJuIGZh bHNlOwotICAvKiBOb3QgZ2VuZXJhdGUgem1tIGluc3RydWN0aW9uIHdoZW4gcHJlZmVyIDEyOC8y NTYgYml0IHZlY3RvciB3aWR0aC4gICovCi0gIGlmIChxaW1vZGUgPT0gVjMyUUltb2RlCi0gICAg ICAmJiAoVEFSR0VUX1BSRUZFUl9BVlgxMjggfHwgVEFSR0VUX1BSRUZFUl9BVlgyNTYpKQorICAv KiBEbyBub3QgZ2VuZXJhdGUgeW1tL3ptbSBpbnN0cnVjdGlvbnMgd2hlbgorICAgICB0YXJnZXQg cHJlZmVycyAxMjgvMjU2IGJpdCB2ZWN0b3Igd2lkdGguICAqLworICBpZiAoKHFpbW9kZSA9PSBW MTZRSW1vZGUgJiYgVEFSR0VUX1BSRUZFUl9BVlgxMjgpCisgICAgICB8fCAocWltb2RlID09IFYz MlFJbW9kZSAmJiBUQVJHRVRfUFJFRkVSX0FWWDI1NikpCiAgICAgcmV0dXJuIGZhbHNlOwogCiAg IHN3aXRjaCAocWltb2RlKQogICAgIHsKICAgICBjYXNlIEVfVjhRSW1vZGU6CiAgICAgICBoaW1v ZGUgPSBWOEhJbW9kZTsKLSAgICAgIGdlbl9leHRlbmQgPSB1bnNfcCA/IGdlbl96ZXJvX2V4dGVu ZHY4cWl2OGhpMiA6IGdlbl9leHRlbmR2OHFpdjhoaTI7CiAgICAgICBnZW5fdHJ1bmNhdGUgPSBn ZW5fdHJ1bmN2OGhpdjhxaTI7CiAgICAgICBicmVhazsKICAgICBjYXNlIEVfVjE2UUltb2RlOgog ICAgICAgaGltb2RlID0gVjE2SEltb2RlOwotICAgICAgZ2VuX2V4dGVuZCA9IHVuc19wID8gZ2Vu X3plcm9fZXh0ZW5kdjE2cWl2MTZoaTIgOiBnZW5fZXh0ZW5kdjE2cWl2MTZoaTI7CiAgICAgICBn ZW5fdHJ1bmNhdGUgPSBnZW5fdHJ1bmN2MTZoaXYxNnFpMjsKICAgICAgIGJyZWFrOwogICAgIGNh c2UgRV9WMzJRSW1vZGU6CiAgICAgICBoaW1vZGUgPSBWMzJISW1vZGU7Ci0gICAgICBnZW5fZXh0 ZW5kID0gdW5zX3AgPyBnZW5femVyb19leHRlbmR2MzJxaXYzMmhpMiA6IGdlbl9leHRlbmR2MzJx aXYzMmhpMjsKICAgICAgIGdlbl90cnVuY2F0ZSA9IGdlbl90cnVuY3YzMmhpdjMycWkyOwogICAg ICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKQEAgLTIzMTY1LDggKzIzMTYyLDggQEAgaXg4Nl9leHBh bmRfdmVjb3BfcWloaTIgKGVudW0gcnR4X2NvZGUgY29kZSwgcnR4IGRlc3QsIHJ0eCBvcDEsIHJ0 eCBvcDIpCiAgIGhvcDEgPSBnZW5fcmVnX3J0eCAoaGltb2RlKTsKICAgaG9wMiA9IGdlbl9yZWdf cnR4IChoaW1vZGUpOwogICBoZGVzdCA9IGdlbl9yZWdfcnR4IChoaW1vZGUpOwotICBlbWl0X2lu c24gKGdlbl9leHRlbmQgKGhvcDEsIG9wMSkpOwotICBlbWl0X2luc24gKGdlbl9leHRlbmQgKGhv cDIsIG9wMikpOworICBlbWl0X2luc24gKGdlbl9leHRlbmRfaW5zbiAoaG9wMSwgb3AxLCBoaW1v ZGUsIHFpbW9kZSwgdW5zX3ApKTsKKyAgZW1pdF9pbnNuIChnZW5fZXh0ZW5kX2luc24gKGhvcDIs IG9wMiwgaGltb2RlLCBxaW1vZGUsIHVuc19wKSk7CiAgIGVtaXRfaW5zbiAoZ2VuX3J0eF9TRVQg KGhkZXN0LCBzaW1wbGlmeV9nZW5fYmluYXJ5IChjb2RlLCBoaW1vZGUsCiAJCQkJCQkgICAgICBo b3AxLCBob3AyKSkpOwogICBlbWl0X2luc24gKGdlbl90cnVuY2F0ZSAoZGVzdCwgaGRlc3QpKTsK QEAgLTIzMjg1LDggKzIzMjgyLDkgQEAgaXg4Nl9leHBhbmRfdmVjb3BfcWloaSAoZW51bSBydHhf Y29kZSBjb2RlLCBydHggZGVzdCwgcnR4IG9wMSwgcnR4IG9wMikKICAgcnR4ICgqZ2VuX2loKSAo cnR4LCBydHgsIHJ0eCk7CiAgIHJ0eCBvcDFfbCwgb3AxX2gsIG9wMl9sLCBvcDJfaCwgcmVzX2ws IHJlc19oOwogICBzdHJ1Y3QgZXhwYW5kX3ZlY19wZXJtX2QgZDsKLSAgYm9vbCBvaywgZnVsbF9p bnRlcmxlYXZlOwotICBib29sIHVuc19wID0gZmFsc2U7CisgIGJvb2wgZnVsbF9pbnRlcmxlYXZl ID0gdHJ1ZTsKKyAgYm9vbCB1bnNfcCA9IHRydWU7CisgIGJvb2wgb2s7CiAgIGludCBpOwogCiAg IGlmIChDT05TVF9JTlRfUCAob3AyKQpAQCAtMjMzMDMsMTggKzIzMzAxLDEyIEBAIGl4ODZfZXhw YW5kX3ZlY29wX3FpaGkgKGVudW0gcnR4X2NvZGUgY29kZSwgcnR4IGRlc3QsIHJ0eCBvcDEsIHJ0 eCBvcDIpCiAgICAgewogICAgIGNhc2UgRV9WMTZRSW1vZGU6CiAgICAgICBoaW1vZGUgPSBWOEhJ bW9kZTsKLSAgICAgIGdlbl9pbCA9IGdlbl92ZWNfaW50ZXJsZWF2ZV9sb3d2MTZxaTsKLSAgICAg IGdlbl9paCA9IGdlbl92ZWNfaW50ZXJsZWF2ZV9oaWdodjE2cWk7CiAgICAgICBicmVhazsKICAg ICBjYXNlIEVfVjMyUUltb2RlOgogICAgICAgaGltb2RlID0gVjE2SEltb2RlOwotICAgICAgZ2Vu X2lsID0gZ2VuX2F2eDJfaW50ZXJsZWF2ZV9sb3d2MzJxaTsKLSAgICAgIGdlbl9paCA9IGdlbl9h dngyX2ludGVybGVhdmVfaGlnaHYzMnFpOwogICAgICAgYnJlYWs7CiAgICAgY2FzZSBFX1Y2NFFJ bW9kZToKICAgICAgIGhpbW9kZSA9IFYzMkhJbW9kZTsKLSAgICAgIGdlbl9pbCA9IGdlbl9hdng1 MTJid19pbnRlcmxlYXZlX2xvd3Y2NHFpOwotICAgICAgZ2VuX2loID0gZ2VuX2F2eDUxMmJ3X2lu dGVybGVhdmVfaGlnaHY2NHFpOwogICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgIGdj Y191bnJlYWNoYWJsZSAoKTsKQEAgLTIzMzI3LDYgKzIzMzE5LDI2IEBAIGl4ODZfZXhwYW5kX3Zl Y29wX3FpaGkgKGVudW0gcnR4X2NvZGUgY29kZSwgcnR4IGRlc3QsIHJ0eCBvcDEsIHJ0eCBvcDIp CiAJIGVhY2ggd29yZC4gIFdlIGRvbid0IGNhcmUgd2hhdCBnb2VzIGludG8gdGhlIGhpZ2ggYnl0 ZSBvZiBlYWNoIHdvcmQuCiAJIFJhdGhlciB0aGFuIHRyeWluZyB0byBnZXQgemVybyBpbiB0aGVy ZSwgbW9zdCBjb252ZW5pZW50IGlzIHRvIGxldAogCSBpdCBiZSBhIGNvcHkgb2YgdGhlIGxvdyBi eXRlLiAgKi8KKyAgICAgIHN3aXRjaCAocWltb2RlKQorCXsKKwljYXNlIEVfVjE2UUltb2RlOgor CSAgZ2VuX2lsID0gZ2VuX3ZlY19pbnRlcmxlYXZlX2xvd3YxNnFpOworCSAgZ2VuX2loID0gZ2Vu X3ZlY19pbnRlcmxlYXZlX2hpZ2h2MTZxaTsKKwkgIGJyZWFrOworCWNhc2UgRV9WMzJRSW1vZGU6 CisJICBnZW5faWwgPSBnZW5fYXZ4Ml9pbnRlcmxlYXZlX2xvd3YzMnFpOworCSAgZ2VuX2loID0g Z2VuX2F2eDJfaW50ZXJsZWF2ZV9oaWdodjMycWk7CisJICBmdWxsX2ludGVybGVhdmUgPSBmYWxz ZTsKKwkgIGJyZWFrOworCWNhc2UgRV9WNjRRSW1vZGU6CisJICBnZW5faWwgPSBnZW5fYXZ4NTEy YndfaW50ZXJsZWF2ZV9sb3d2NjRxaTsKKwkgIGdlbl9paCA9IGdlbl9hdng1MTJid19pbnRlcmxl YXZlX2hpZ2h2NjRxaTsKKwkgIGZ1bGxfaW50ZXJsZWF2ZSA9IGZhbHNlOworCSAgYnJlYWs7CisJ ZGVmYXVsdDoKKwkgIGdjY191bnJlYWNoYWJsZSAoKTsKKwl9CisKICAgICAgIG9wMl9sID0gZ2Vu X3JlZ19ydHggKHFpbW9kZSk7CiAgICAgICBvcDJfaCA9IGdlbl9yZWdfcnR4IChxaW1vZGUpOwog ICAgICAgZW1pdF9pbnNuIChnZW5faWwgKG9wMl9sLCBvcDIsIG9wMikpOwpAQCAtMjMzMzYsMTQg KzIzMzQ4LDEzIEBAIGl4ODZfZXhwYW5kX3ZlY29wX3FpaGkgKGVudW0gcnR4X2NvZGUgY29kZSwg cnR4IGRlc3QsIHJ0eCBvcDEsIHJ0eCBvcDIpCiAgICAgICBvcDFfaCA9IGdlbl9yZWdfcnR4IChx aW1vZGUpOwogICAgICAgZW1pdF9pbnNuIChnZW5faWwgKG9wMV9sLCBvcDEsIG9wMSkpOwogICAg ICAgZW1pdF9pbnNuIChnZW5faWggKG9wMV9oLCBvcDEsIG9wMSkpOwotICAgICAgZnVsbF9pbnRl cmxlYXZlID0gcWltb2RlID09IFYxNlFJbW9kZTsKICAgICAgIGJyZWFrOwogCisgICAgY2FzZSBB U0hJRlRSVDoKKyAgICAgIHVuc19wID0gZmFsc2U7CisgICAgICAvKiBGQUxMVEhSVSAqLwogICAg IGNhc2UgQVNISUZUOgogICAgIGNhc2UgTFNISUZUUlQ6Ci0gICAgICB1bnNfcCA9IHRydWU7Ci0g ICAgICAvKiBGQUxMVEhSVSAqLwotICAgIGNhc2UgQVNISUZUUlQ6CiAgICAgICBvcDFfbCA9IGdl bl9yZWdfcnR4IChoaW1vZGUpOwogICAgICAgb3AxX2ggPSBnZW5fcmVnX3J0eCAoaGltb2RlKTsK ICAgICAgIGl4ODZfZXhwYW5kX3NzZV91bnBhY2sgKG9wMV9sLCBvcDEsIHVuc19wLCBmYWxzZSk7 CkBAIC0yMzM2MCwxNiArMjMzNzEsMTUgQEAgaXg4Nl9leHBhbmRfdmVjb3BfcWloaSAoZW51bSBy dHhfY29kZSBjb2RlLCBydHggZGVzdCwgcnR4IG9wMSwgcnR4IG9wMikKICAgICAgIGVsc2UKIAlv cDJfbCA9IG9wMl9oID0gb3AyOwogCi0gICAgICBmdWxsX2ludGVybGVhdmUgPSB0cnVlOwogICAg ICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgIGdjY191bnJlYWNoYWJsZSAoKTsKICAgICB9 CiAKLSAgLyogUGVyZm9ybSB2YXNoci92bHNoci92YXNobC4gICovCiAgIGlmIChjb2RlICE9IE1V TFQKICAgICAgICYmIEdFVF9NT0RFX0NMQVNTIChHRVRfTU9ERSAob3AyKSkgPT0gTU9ERV9WRUNU T1JfSU5UKQogICAgIHsKKyAgICAgIC8qIEV4cGFuZCB2YXNoci92bHNoci92YXNobC4gICovCiAg ICAgICByZXNfbCA9IGdlbl9yZWdfcnR4IChoaW1vZGUpOwogICAgICAgcmVzX2ggPSBnZW5fcmVn X3J0eCAoaGltb2RlKTsKICAgICAgIGVtaXRfaW5zbiAoZ2VuX3J0eF9TRVQgKHJlc19sLApAQCAt MjMzNzksOSArMjMzODksOSBAQCBpeDg2X2V4cGFuZF92ZWNvcF9xaWhpIChlbnVtIHJ0eF9jb2Rl IGNvZGUsIHJ0eCBkZXN0LCBydHggb3AxLCBydHggb3AyKQogCQkJICAgICAgc2ltcGxpZnlfZ2Vu X2JpbmFyeSAoY29kZSwgaGltb2RlLAogCQkJCQkJICAgb3AxX2gsIG9wMl9oKSkpOwogICAgIH0K LSAgLyogUGVyZm9ybWFuY2UgbXVsdC9hc2hyL2xzaHIvYXNobC4gICovCiAgIGVsc2UKICAgICB7 CisgICAgICAvKiBFeHBhbmQgbXVsdC9hc2hyL2xzaHIvYXNobC4gICovCiAgICAgICByZXNfbCA9 IGV4cGFuZF9zaW1wbGVfYmlub3AgKGhpbW9kZSwgY29kZSwgb3AxX2wsIG9wMl9sLCBOVUxMX1JU WCwKIAkJCQkgICAxLCBPUFRBQl9ESVJFQ1QpOwogICAgICAgcmVzX2ggPSBleHBhbmRfc2ltcGxl X2Jpbm9wIChoaW1vZGUsIGNvZGUsIG9wMV9oLCBvcDJfaCwgTlVMTF9SVFgsCkBAIC0yMzQwMSw3 ICsyMzQxMSw3IEBAIGl4ODZfZXhwYW5kX3ZlY29wX3FpaGkgKGVudW0gcnR4X2NvZGUgY29kZSwg cnR4IGRlc3QsIHJ0eCBvcDEsIHJ0eCBvcDIpCiAKICAgaWYgKGZ1bGxfaW50ZXJsZWF2ZSkKICAg ICB7Ci0gICAgICAvKiBGb3IgU1NFMiwgd2UgdXNlZCBhbiBmdWxsIGludGVybGVhdmUsIHNvIHRo ZSBkZXNpcmVkCisgICAgICAvKiBXZSB1c2VkIHRoZSBmdWxsIGludGVybGVhdmUsIHRoZSBkZXNp cmVkCiAJIHJlc3VsdHMgYXJlIGluIHRoZSBldmVuIGVsZW1lbnRzLiAgKi8KICAgICAgIGZvciAo aSA9IDA7IGkgPCBkLm5lbHQ7ICsraSkKIAlkLnBlcm1baV0gPSBpICogMjsK --000000000000bd0b9c05fb82c4ea--