From: Uros Bizjak <ubizjak@gmail.com>
To: Richard Biener <rguenther@suse.de>
Cc: Petr Murzin <petrmurzin1@gmail.com>,
Kirill Yukhin <kirill.yukhin@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] [AVX512F] Add scatter support for vectorizer
Date: Tue, 04 Aug 2015 12:42:00 -0000 [thread overview]
Message-ID: <CAFULd4YwHfjrF1dra57tLa2PknrKb5CCm=TLq0GULgUuUoDP_Q@mail.gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1508041351040.19642@zhemvz.fhfr.qr>
On Tue, Aug 4, 2015 at 2:15 PM, Richard Biener <rguenther@suse.de> wrote:
>> This patch adds scatter support for vectorizer (for AVX512F
>> instructions). Please have a look. Is it OK for trunk?
>
> +/* Target builtin that implements vector scatter operation. */
> +DEFHOOK
> +(builtin_scatter,
> + "",
> + tree,
> + (const_tree vectype, const_tree index_type, int scale),
> + NULL)
>
> please add documentation inline here, like for builtin_gather,
> and let tm.texi be auto-populated.
>
> Note that the i386 changes need target maintainer approval, CCing
> Uros.
As said many times, please don't mix middle-end and target parts into
one patch. Middle-end part (usually algorithmic one) has to be
discussed, reviewed and approved first, and at that stage, the target
part can be used as an implementation example. Only *after* approval
of the middle-end part, target part can be reviewed.
Not to mention that every part has different reviews, so the review of
the patch can stall due to this fact.
Uros.
next prev parent reply other threads:[~2015-08-04 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 11:06 Petr Murzin
2015-08-04 12:15 ` Richard Biener
2015-08-04 12:42 ` Uros Bizjak [this message]
2015-08-21 12:21 ` Petr Murzin
2015-08-26 7:44 ` Richard Biener
2015-08-26 18:46 ` Petr Murzin
2015-08-26 22:15 ` Uros Bizjak
-- strict thread matches above, loose matches on Subject: below --
2015-03-05 10:16 Petr Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4YwHfjrF1dra57tLa2PknrKb5CCm=TLq0GULgUuUoDP_Q@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kirill.yukhin@gmail.com \
--cc=petrmurzin1@gmail.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).