From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by sourceware.org (Postfix) with ESMTPS id EC1713858410 for ; Wed, 17 Nov 2021 07:13:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC1713858410 Received: by mail-qt1-x82d.google.com with SMTP id o17so1781961qtk.1 for ; Tue, 16 Nov 2021 23:13:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aXQTwdj4Y3Li+MDEXVaUWuZZ74Ruth9FXEeGHTVF9KY=; b=GppgSmoaTU7Sf+6dlL0XYl+SCsz+K/ele4uLnedCf6TMqdj4t6lFARvpL6s2a9gVL6 rq64yxQ5d1NZCCkkC/LkIx9Jhwm4fYwf77btvYcf6nb493Aq+fbkSooLSyIl94D159Kn FjmOYe2d69CSvbQ0G8TEXf+5Dm1PGURDm2p5T/0ZgE4ydsXc4AtdkYXDWzMDMwC46Edy 9IA7uN9fHt6WkT5sbvvTwv56FWmJfZzM01Y7sBeJbRq/ddejJFS+5y6m/HzJoSDwr1Yb XdoAEfnSJuGx3iN8U4mLhFf+ajI29TpflojFQB4RGvdAo3rm+xG+VjvJsnQ4dRpCRmNm ZJ8w== X-Gm-Message-State: AOAM533R7XJrHnnqGdHAkL30dtwXM+dmO+PM17/EleolJVEH1gI++YJf 13uCuOOun0+2VEmqNGja6JnuAk44H4o2hmYYt2LGro9nTYU= X-Google-Smtp-Source: ABdhPJyrA+DNP2o20Z2k26wXJCFDwhLmRiacuvMuzOlApX3aqNeIyBiLNFg+HesuGBLKxbSXTEk+aR259ga0jvk4ys8= X-Received: by 2002:ac8:4155:: with SMTP id e21mr14322981qtm.312.1637133192318; Tue, 16 Nov 2021 23:13:12 -0800 (PST) MIME-Version: 1.0 References: <7791d23e4be91943d8c6d0ec56493827011e3b96.1636621345.git.linkw@linux.ibm.com> In-Reply-To: <7791d23e4be91943d8c6d0ec56493827011e3b96.1636621345.git.linkw@linux.ibm.com> From: Uros Bizjak Date: Wed, 17 Nov 2021 08:13:00 +0100 Message-ID: Subject: Re: [PATCH 12/15] i386: Fix non-robust split condition in define_insn_and_split To: Kewen Lin Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Nov 2021 07:13:14 -0000 On Thu, Nov 11, 2021 at 12:25 PM Kewen Lin wrote: > > This patch is to fix some non-robust split conditions in some > define_insn_and_splits, to make each of them applied on top of > the corresponding condition for define_insn part, otherwise the > splitting could perform unexpectedly. > > gcc/ChangeLog: > > * config/i386/i386.md (*add3_doubleword, *addv4_doubleword, > *addv4_doubleword_1, *sub3_doubleword, > *subv4_doubleword, *subv4_doubleword_1, > *add3_doubleword_cc_overflow_1, *divmodsi4_const, > *neg2_doubleword, *tls_dynamic_gnu2_combine_64_): Fix split > condition. OK. Thanks, Uros. > --- > gcc/config/i386/i386.md | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md > index 6eb9de81921..2bd09e502ae 100644 > --- a/gcc/config/i386/i386.md > +++ b/gcc/config/i386/i386.md > @@ -5491,7 +5491,7 @@ (define_insn_and_split "*add3_doubleword" > (clobber (reg:CC FLAGS_REG))] > "ix86_binary_operator_ok (PLUS, mode, operands)" > "#" > - "reload_completed" > + "&& reload_completed" > [(parallel [(set (reg:CCC FLAGS_REG) > (compare:CCC > (plus:DWIH (match_dup 1) (match_dup 2)) > @@ -6300,7 +6300,7 @@ (define_insn_and_split "*addv4_doubleword" > (plus: (match_dup 1) (match_dup 2)))] > "ix86_binary_operator_ok (PLUS, mode, operands)" > "#" > - "reload_completed" > + "&& reload_completed" > [(parallel [(set (reg:CCC FLAGS_REG) > (compare:CCC > (plus:DWIH (match_dup 1) (match_dup 2)) > @@ -6347,7 +6347,7 @@ (define_insn_and_split "*addv4_doubleword_1" > && CONST_SCALAR_INT_P (operands[2]) > && rtx_equal_p (operands[2], operands[3])" > "#" > - "reload_completed" > + "&& reload_completed" > [(parallel [(set (reg:CCC FLAGS_REG) > (compare:CCC > (plus:DWIH (match_dup 1) (match_dup 2)) > @@ -6641,7 +6641,7 @@ (define_insn_and_split "*sub3_doubleword" > (clobber (reg:CC FLAGS_REG))] > "ix86_binary_operator_ok (MINUS, mode, operands)" > "#" > - "reload_completed" > + "&& reload_completed" > [(parallel [(set (reg:CC FLAGS_REG) > (compare:CC (match_dup 1) (match_dup 2))) > (set (match_dup 0) > @@ -6817,7 +6817,7 @@ (define_insn_and_split "*subv4_doubleword" > (minus: (match_dup 1) (match_dup 2)))] > "ix86_binary_operator_ok (MINUS, mode, operands)" > "#" > - "reload_completed" > + "&& reload_completed" > [(parallel [(set (reg:CC FLAGS_REG) > (compare:CC (match_dup 1) (match_dup 2))) > (set (match_dup 0) > @@ -6862,7 +6862,7 @@ (define_insn_and_split "*subv4_doubleword_1" > && CONST_SCALAR_INT_P (operands[2]) > && rtx_equal_p (operands[2], operands[3])" > "#" > - "reload_completed" > + "&& reload_completed" > [(parallel [(set (reg:CC FLAGS_REG) > (compare:CC (match_dup 1) (match_dup 2))) > (set (match_dup 0) > @@ -7542,7 +7542,7 @@ (define_insn_and_split "*add3_doubleword_cc_overflow_1" > (plus: (match_dup 1) (match_dup 2)))] > "ix86_binary_operator_ok (PLUS, mode, operands)" > "#" > - "reload_completed" > + "&& reload_completed" > [(parallel [(set (reg:CCC FLAGS_REG) > (compare:CCC > (plus:DWIH (match_dup 1) (match_dup 2)) > @@ -9000,7 +9000,7 @@ (define_insn_and_split "*divmodsi4_const" > (clobber (reg:CC FLAGS_REG))] > "!optimize_function_for_size_p (cfun)" > "#" > - "reload_completed" > + "&& reload_completed" > [(set (match_dup 0) (match_dup 2)) > (set (match_dup 1) (match_dup 4)) > (parallel [(set (match_dup 0) > @@ -10515,7 +10515,7 @@ (define_insn_and_split "*neg2_doubleword" > (clobber (reg:CC FLAGS_REG))] > "ix86_unary_operator_ok (NEG, mode, operands)" > "#" > - "reload_completed" > + "&& reload_completed" > [(parallel > [(set (reg:CCC FLAGS_REG) > (ne:CCC (match_dup 1) (const_int 0))) > @@ -16898,7 +16898,7 @@ (define_insn_and_split "*tls_dynamic_gnu2_combine_64_" > (clobber (reg:CC FLAGS_REG))] > "TARGET_64BIT && TARGET_GNU2_TLS" > "#" > - "" > + "&& 1" > [(set (match_dup 0) (match_dup 4))] > { > operands[4] = can_create_pseudo_p () ? gen_reg_rtx (ptr_mode) : operands[0]; > -- > 2.27.0 >