From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by sourceware.org (Postfix) with ESMTPS id AB6F33858C52 for ; Wed, 24 May 2023 06:31:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB6F33858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-75affe977abso102997385a.0 for ; Tue, 23 May 2023 23:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684909895; x=1687501895; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Y5eMyqYlrzXZa2HOlMAwW9IU0oOdUSI8e/fHiWnVsNU=; b=UNGRtXl4x691wUpm2uyCTSGzBNnEOfDRNgJqhFNSDbiH7nW4vSevnneLOmEKNc1xJM 5YcnhUiVqzrCSUPyVJaQPPPDK7J3MlY3QrSYtFwos4vBwyKryrmLbhQ+vIBFsjAQf+uT o3gdpy6VSaLThbeNnhiRTsZXNvVo1XGWb+CA2vUIz7C56MYDlavSPRlrWQKXxmUUjhHx 3FnaKMecQdTTxbPJFoX3HuerT1x5iCm3t03+MnqP+8SRFZKsSkcw5o4Lq+Qbp0moUvSL HxssynQpM9kT8/4Ri1XnWsoGEDZom655Dhu2bRdhXXQNhOfm6/2F9YiINEH3Ndbey2UB AiDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684909895; x=1687501895; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y5eMyqYlrzXZa2HOlMAwW9IU0oOdUSI8e/fHiWnVsNU=; b=RXoS/5CpTYHUm8B4cNLxAr7xXPz4HvYVTR4dskg23Uvu1upEPJAnc9pn5UFX1B5NDH CUSBnFw7CKDKS9mcqVw88utVFCrIRInkr/h90IThhPfIWxJ8DhvHFUVT0D15KM/lgABm zrq17KtcRq2Yu5hbnV8nKOivEw2+mZVF0oJDDMXRCpYfqzU7NwQBwHFI2ZPkRhkyVeLl fzpr28ZKqarn2oJz+osaGhVLVgDbLmrO0UPK/abAN1isDyTNqL52uFMm/VEXk9H44/Vr 59e7iXXn6xqGK/0mOvOSZ7WIRuIa7+Il8xoZGcraF+/2pywozL5KJc8L9JYbezl7coVf pMAQ== X-Gm-Message-State: AC+VfDwop5RmY4HFh6yHbJeqbU4BVwAouyjy1g4GB/xhjITbdHSiYz65 G5ppJ/TEqXE65u3XDy+nkYbcXpa1OTIBzezrG+A= X-Google-Smtp-Source: ACHHUZ6Si67Q7uwgevOAfED9i2Pcu15nFAlMzEk0hZHakmVAXJEXazm2jsqNPV7VMG1WAyqvH2SYzXhkLtz+GIzjfYw= X-Received: by 2002:a05:6214:1cc5:b0:625:aa49:9ab1 with SMTP id g5-20020a0562141cc500b00625aa499ab1mr641300qvd.53.1684909894680; Tue, 23 May 2023 23:31:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Uros Bizjak Date: Wed, 24 May 2023 08:31:23 +0200 Message-ID: Subject: Re: [PATCH] [testsuite] [x86] cope with --enable-frame-pointer To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org, Rainer Orth , Mike Stump , Jan Hubicka Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, May 24, 2023 at 7:48=E2=80=AFAM Alexandre Oliva = wrote: > > > Various x86 tests fail if the toolchain is configured with > --enable-frame-pointer, because the unexpected extra insns mess with > the expected asm counts. Add -fomit-frame-pointer so that they can > still pass. > > Bootstrapped on x86_64-linux-gnu. Also tested on ppc- and x86-vx7r2 > with gcc-12. > > for gcc/testsuite/ChangeLog > > * gcc.target/i386/pieces-memcpy-7.c: Add -fomit-frame-pointer. > * gcc.target/i386/pieces-memcpy-8.c: Likewise. > * gcc.target/i386/pieces-memcpy-9.c: Likewise. > * gcc.target/i386/pieces-memset-1.c: Likewise. > * gcc.target/i386/pieces-memset-36.c: Likewise. > * gcc.target/i386/pieces-memset-4.c: Likewise. > * gcc.target/i386/pieces-memset-40.c: Likewise. > * gcc.target/i386/pieces-memset-41.c: Likewise. > * gcc.target/i386/pieces-memset-7.c: Likewise. > * gcc.target/i386/pieces-memset-8.c: Likewise. > * gcc.target/i386/pieces-memset-9.c: Likewise. > * gcc.target/i386/pr102230.c: Likewise. > * gcc.target/i386/pr78103-2.c: Likewise. OK. Thanks, Uros. > --- > gcc/testsuite/gcc.target/i386/pieces-memcpy-7.c | 2 ++ > gcc/testsuite/gcc.target/i386/pieces-memcpy-8.c | 2 ++ > gcc/testsuite/gcc.target/i386/pieces-memcpy-9.c | 2 ++ > gcc/testsuite/gcc.target/i386/pieces-memset-1.c | 2 ++ > gcc/testsuite/gcc.target/i386/pieces-memset-36.c | 2 ++ > gcc/testsuite/gcc.target/i386/pieces-memset-4.c | 2 ++ > gcc/testsuite/gcc.target/i386/pieces-memset-40.c | 2 ++ > gcc/testsuite/gcc.target/i386/pieces-memset-41.c | 2 ++ > gcc/testsuite/gcc.target/i386/pieces-memset-7.c | 2 ++ > gcc/testsuite/gcc.target/i386/pieces-memset-8.c | 2 ++ > gcc/testsuite/gcc.target/i386/pieces-memset-9.c | 2 ++ > gcc/testsuite/gcc.target/i386/pr102230.c | 2 ++ > gcc/testsuite/gcc.target/i386/pr78103-2.c | 2 ++ > 13 files changed, 26 insertions(+) > > diff --git a/gcc/testsuite/gcc.target/i386/pieces-memcpy-7.c b/gcc/testsu= ite/gcc.target/i386/pieces-memcpy-7.c > index 3d248d447ea42..64fd8b4176cec 100644 > --- a/gcc/testsuite/gcc.target/i386/pieces-memcpy-7.c > +++ b/gcc/testsuite/gcc.target/i386/pieces-memcpy-7.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -mno-avx -msse2 -mtune=3Dgeneric" } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > > void > foo (int a1, int a2, int a3, int a4, int a5, int a6, char *dst, char *sr= c) > diff --git a/gcc/testsuite/gcc.target/i386/pieces-memcpy-8.c b/gcc/testsu= ite/gcc.target/i386/pieces-memcpy-8.c > index c13a2beb2f017..fc60c46c58900 100644 > --- a/gcc/testsuite/gcc.target/i386/pieces-memcpy-8.c > +++ b/gcc/testsuite/gcc.target/i386/pieces-memcpy-8.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -mno-avx2 -mavx -mtune=3Dgeneric" } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > > void > foo (int a1, int a2, int a3, int a4, int a5, int a6, char *dst, char *sr= c) > diff --git a/gcc/testsuite/gcc.target/i386/pieces-memcpy-9.c b/gcc/testsu= ite/gcc.target/i386/pieces-memcpy-9.c > index 238f88b275eb7..62fcb6f569204 100644 > --- a/gcc/testsuite/gcc.target/i386/pieces-memcpy-9.c > +++ b/gcc/testsuite/gcc.target/i386/pieces-memcpy-9.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -mavx512f -mtune=3Dgeneric" } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > > void > foo (int a1, int a2, int a3, int a4, int a5, int a6, char *dst, char *sr= c) > diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-1.c b/gcc/testsu= ite/gcc.target/i386/pieces-memset-1.c > index f7487ba9c5b28..0002c6838ab76 100644 > --- a/gcc/testsuite/gcc.target/i386/pieces-memset-1.c > +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-1.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -mno-avx -msse2 -mtune=3Dgeneric -mno-stackrealign"= } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > > extern char *dst; > > diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-36.c b/gcc/tests= uite/gcc.target/i386/pieces-memset-36.c > index d1f1263c7b211..d1bbfa204a7f8 100644 > --- a/gcc/testsuite/gcc.target/i386/pieces-memset-36.c > +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-36.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -mno-avx512f -mavx2 -mtune=3Dgeneric" } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > > extern char *dst; > > diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-4.c b/gcc/testsu= ite/gcc.target/i386/pieces-memset-4.c > index a12b9dda28bd3..8b3f3b00214f8 100644 > --- a/gcc/testsuite/gcc.target/i386/pieces-memset-4.c > +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-4.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -mno-avx -msse2 -mtune=3Dgeneric -mno-stackrealign"= } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > > extern char *dst; > > diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-40.c b/gcc/tests= uite/gcc.target/i386/pieces-memset-40.c > index 4eda73ead5924..37a9dcc8c1ea8 100644 > --- a/gcc/testsuite/gcc.target/i386/pieces-memset-40.c > +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-40.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -mno-avx512f -mavx2 -mtune=3Dsandybridge" } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > > extern char *dst; > > diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-41.c b/gcc/tests= uite/gcc.target/i386/pieces-memset-41.c > index 93df8101e4d0f..d7a27f52983fa 100644 > --- a/gcc/testsuite/gcc.target/i386/pieces-memset-41.c > +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-41.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -mno-avx2 -mavx -mtune=3Dsandybridge -mno-stackreal= ign" } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > > extern char *dst; > > diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-7.c b/gcc/testsu= ite/gcc.target/i386/pieces-memset-7.c > index 0d02877f67b33..56be2991ba63e 100644 > --- a/gcc/testsuite/gcc.target/i386/pieces-memset-7.c > +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-7.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -mno-avx -msse2 -mtune=3Dgeneric -mno-stackrealign"= } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > > extern char *dst; > > diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-8.c b/gcc/testsu= ite/gcc.target/i386/pieces-memset-8.c > index 816d83ea027cf..e4e63b855bcfe 100644 > --- a/gcc/testsuite/gcc.target/i386/pieces-memset-8.c > +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-8.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -mno-avx2 -mavx -mtune=3Dgeneric -mno-stackrealign"= } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > > extern char *dst; > > diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-9.c b/gcc/testsu= ite/gcc.target/i386/pieces-memset-9.c > index 1ead154fe1ed6..d64cf6b464893 100644 > --- a/gcc/testsuite/gcc.target/i386/pieces-memset-9.c > +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-9.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -march=3Dx86-64 -mavx512f -mtune=3Dgeneric" } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > > extern char *dst; > > diff --git a/gcc/testsuite/gcc.target/i386/pr102230.c b/gcc/testsuite/gcc= .target/i386/pr102230.c > index ad37f4f265a9c..2f0fe5268a7e6 100644 > --- a/gcc/testsuite/gcc.target/i386/pr102230.c > +++ b/gcc/testsuite/gcc.target/i386/pr102230.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -mavx512fp16" } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > > typedef _Float16 v4hf __attribute__ ((vector_size (8))); > typedef _Float16 v2hf __attribute__ ((vector_size (4))); > diff --git a/gcc/testsuite/gcc.target/i386/pr78103-2.c b/gcc/testsuite/gc= c.target/i386/pr78103-2.c > index 30f7f98f60a41..0183554389f16 100644 > --- a/gcc/testsuite/gcc.target/i386/pr78103-2.c > +++ b/gcc/testsuite/gcc.target/i386/pr78103-2.c > @@ -1,6 +1,8 @@ > /* PR target/78103 */ > /* { dg-do compile } */ > /* { dg-options "-O2 -mno-lzcnt" } */ > +/* Cope with --enable-frame-pointer. */ > +/* { dg-additional-options "-fomit-frame-pointer" } */ > /* { dg-final { scan-assembler-not {\mmovl\M} } } */ > /* { dg-final { scan-assembler-not {\mxor[lq]\M} } } */ > /* { dg-final { scan-assembler-not {\msubl\M} } } */ > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Disinformation flourishes because many people care deeply about injustice > but very few check the facts. Ask me about