On Tue, Apr 4, 2017 at 9:24 PM, Jakub Jelinek wrote: > Hi! > > aggregate_value_p is called often very early during compilation, e.g. > from allocate_function or during gimplification of a call with lhs. > The problem with that is e.g. that on x86_64 -m64 -mno-sse we can't > include , because the always_inline inline functions > in mmx and 3dnow intrinsic headers return __m64 or take __m64 as arguments > and that in the 64-bit ABI is in SSE register. > > The following patch makes sure we diagnose this only later (e.g. when > expanding a function to RTL or when expanding calls to other functions), > which means we don't diagnose e.g. inline functions that got successfully > inlined (because then there is really no function return in SSE or x87 > reg) or e.g. for builtin calls if they are emitted inline rather than > as a library call (again, I think that is desirable). > I had to tweak a few tests because the reported line changed slightly, > and in the last test add -fno-builtin-fminl, because otherwise fminl > is expanded inline and again there is no call left with the problem. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? No, I think the issue should be fixed in intrinsics. Attached patch solves this problem for me, and also fixes a couple of similar problems (one with -m3dnowa, that is nowadays a regular compile option). The patched intrinsics were tested with combinations of -m{,no-}sse{,2}, -m{,no-}mmx, -m{-no}3dnow{,a}, -m64, and there were no problems with any combination. Uros.