public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH, testsuite]: Compile gcc.dg/20111227-?.c for x86 targets only.
@ 2014-09-03  8:03 Uros Bizjak
  2014-09-03 14:53 ` Mike Stump
  0 siblings, 1 reply; 3+ messages in thread
From: Uros Bizjak @ 2014-09-03  8:03 UTC (permalink / raw)
  To: gcc-patches

Hello!

These testcases were intended to be compiled on x86 targets only [1].

2014-09-03  Uros Bizjak  <ubizjak@gmail.com>

    * gcc.dg/20111227-2.c: Compile only for x86 targets.
    * gcc.dg/20111227-3.c: Ditto.

Tested on x86_64-linux-gnu {-m32} and committed to mainline SVN.

[1] https://gcc.gnu.org/ml/gcc-patches/2012-10/msg02329.html

Uros.

Index: gcc.dg/20111227-2.c
===================================================================
--- gcc.dg/20111227-2.c (revision 214845)
+++ gcc.dg/20111227-2.c (working copy)
@@ -1,6 +1,8 @@
 /* Testcase derived from 20111227-1.c to ensure that REE is combining
    redundant zero extends with zero extend to wider mode.  */
+/* { dg-do compile  { target i?86-*-* x86_64-*-* } } */
 /* { dg-options "-fdump-rtl-ree -O -free" } */
+
 extern void abort (void);

 unsigned short s;
Index: gcc.dg/20111227-3.c
===================================================================
--- gcc.dg/20111227-3.c (revision 214845)
+++ gcc.dg/20111227-3.c (working copy)
@@ -1,5 +1,6 @@
 /* Testcase derived from 20111227-1.c to ensure that REE is combining
    redundant sign extends with sign extend to wider mode.  */
+/* { dg-do compile  { target i?86-*-* x86_64-*-* } } */
 /* { dg-options "-fdump-rtl-ree -O -free" } */

 extern void abort (void);

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH, testsuite]: Compile gcc.dg/20111227-?.c for x86 targets only.
  2014-09-03  8:03 [PATCH, testsuite]: Compile gcc.dg/20111227-?.c for x86 targets only Uros Bizjak
@ 2014-09-03 14:53 ` Mike Stump
  2014-09-03 16:36   ` Uros Bizjak
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Stump @ 2014-09-03 14:53 UTC (permalink / raw)
  To: Uros Bizjak; +Cc: gcc-patches

On Sep 3, 2014, at 1:03 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> These testcases were intended to be compiled on x86 targets only [1].

Not a bug deal, but would a git mv bla gcc.target/i386 be more appropriate?

> 2014-09-03  Uros Bizjak  <ubizjak@gmail.com>
> 
>    * gcc.dg/20111227-2.c: Compile only for x86 targets.
>    * gcc.dg/20111227-3.c: Ditto.

> +/* { dg-do compile  { target i?86-*-* x86_64-*-* } } */

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH, testsuite]: Compile gcc.dg/20111227-?.c for x86 targets only.
  2014-09-03 14:53 ` Mike Stump
@ 2014-09-03 16:36   ` Uros Bizjak
  0 siblings, 0 replies; 3+ messages in thread
From: Uros Bizjak @ 2014-09-03 16:36 UTC (permalink / raw)
  To: Mike Stump; +Cc: gcc-patches

On Wed, Sep 3, 2014 at 4:53 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Sep 3, 2014, at 1:03 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>> These testcases were intended to be compiled on x86 targets only [1].
>
> Not a bug deal, but would a git mv bla gcc.target/i386 be more appropriate?

I have considered this option, but the functionality we are testing
here is not specific to x86. It just happens that the test depends on
certain insn patterns, and these are implemented only in x86 for now.
It is pointless to compile the test for other targets, OTOH - there is
no reason that some less known or future target won't be able to pass
this testcase.

Uros.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-03 16:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-03  8:03 [PATCH, testsuite]: Compile gcc.dg/20111227-?.c for x86 targets only Uros Bizjak
2014-09-03 14:53 ` Mike Stump
2014-09-03 16:36   ` Uros Bizjak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).