From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26789 invoked by alias); 12 Feb 2014 08:20:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 26778 invoked by uid 89); 12 Feb 2014 08:20:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f47.google.com Received: from mail-oa0-f47.google.com (HELO mail-oa0-f47.google.com) (209.85.219.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 12 Feb 2014 08:20:40 +0000 Received: by mail-oa0-f47.google.com with SMTP id m1so10540439oag.34 for ; Wed, 12 Feb 2014 00:20:38 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.182.22.18 with SMTP id z18mr11188133obe.42.1392193238123; Wed, 12 Feb 2014 00:20:38 -0800 (PST) Received: by 10.182.137.136 with HTTP; Wed, 12 Feb 2014 00:20:37 -0800 (PST) In-Reply-To: References: <20140211192802.GA26305@intel.com> Date: Wed, 12 Feb 2014 08:20:00 -0000 Message-ID: Subject: Re: PATCH: PR target/60151: HAVE_AS_GOTOFF_IN_DATA is mis-detected on x86-64 From: Uros Bizjak To: "H.J. Lu" Cc: Rainer Orth , GCC Patches Content-Type: multipart/mixed; boundary=001a11332d166ae08b04f2313f36 X-SW-Source: 2014-02/txt/msg00749.txt.bz2 --001a11332d166ae08b04f2313f36 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 900 On Tue, Feb 11, 2014 at 9:41 PM, H.J. Lu wrote: >>>>> HAVE_AS_GOTOFF_IN_DATA defines a 32-bit assembler feature, we need to >>>>> pass --32 to assembler. Otherwise, we get the wrong result on x86-64. >>>>> We already pass --32 to assembler on x86. It should be OK to do it >>>>> in configure. OK for trunk? >>>> >>>> This would break Solaris/x86 with as configurations, where this test >>>> currently passes, but would fail since as doesn't understand --32. >>>> >>> >>> How about passing --32 to as only for Linux? OK to install? >> >> I'd rather do it for gas instead, which can be used on non-Linux >> systems, too. >> > > Sure. Here is the new patch. OK to install? Attached is slightly changed patch that follows established configure.ac code formatting. Please check if this version works for you. The patch is OK for mainline and release branches. Thanks, Uros. --001a11332d166ae08b04f2313f36 Content-Type: text/plain; charset=US-ASCII; name="c.diff.txt" Content-Disposition: attachment; filename="c.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hrkbw5rl0 Content-length: 2192 SW5kZXg6IGNvbmZpZ3VyZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBj b25maWd1cmUJKHJldmlzaW9uIDIwNzcxMCkKKysrIGNvbmZpZ3VyZQkod29y a2luZyBjb3B5KQpAQCAtMjUwMjgsNiArMjUwMjgsMTAgQEAKIAogICAgICMg VGhlc2UgdHdvIGFyZSB1c2VkIHVuY29uZGl0aW9uYWxseSBieSBpMzg2Lltj aF07IGl0IGlzIHRvIGJlIGRlZmluZWQKICAgICAjIHRvIDEgaWYgdGhlIGZl YXR1cmUgaXMgcHJlc2VudCwgMCBvdGhlcndpc2UuCisgICAgYXNfaXg4Nl9n b3RvZmZfaW5fZGF0YV9vcHQ9CisgICAgaWYgdGVzdCB4JGdhcyA9IHh5ZXM7 IHRoZW4KKyAgICAgIGFzX2l4ODZfZ290b2ZmX2luX2RhdGFfb3B0PSItLTMy IgorICAgIGZpCiAgICAgeyAkYXNfZWNobyAiJGFzX21lOiR7YXNfbGluZW5v LSRMSU5FTk99OiBjaGVja2luZyBhc3NlbWJsZXIgZm9yIEdPVE9GRiBpbiBk YXRhIiA+JjUKICRhc19lY2hvX24gImNoZWNraW5nIGFzc2VtYmxlciBmb3Ig R09UT0ZGIGluIGRhdGEuLi4gIiA+JjY7IH0KIGlmIHRlc3QgIiR7Z2NjX2N2 X2FzX2l4ODZfZ290b2ZmX2luX2RhdGErc2V0fSIgPSBzZXQ7IHRoZW4gOgpA QCAtMjUwNDQsNyArMjUwNDgsNyBAQAogCW5vcAogCS5kYXRhCiAJLmxvbmcg LkwwQEdPVE9GRicgPiBjb25mdGVzdC5zCi0gICAgaWYgeyBhY190cnk9JyRn Y2NfY3ZfYXMgJGdjY19jdl9hc19mbGFncyAgLW8gY29uZnRlc3QubyBjb25m dGVzdC5zID4mNScKKyAgICBpZiB7IGFjX3RyeT0nJGdjY19jdl9hcyAkZ2Nj X2N2X2FzX2ZsYWdzICRhc19peDg2X2dvdG9mZl9pbl9kYXRhX29wdCAtbyBj b25mdGVzdC5vIGNvbmZ0ZXN0LnMgPiY1JwogICB7IHsgZXZhbCBlY2hvICJc IlwkYXNfbWVcIjoke2FzX2xpbmVuby0kTElORU5PfTogXCIkYWNfdHJ5XCIi OyB9ID4mNQogICAoZXZhbCAkYWNfdHJ5KSAyPiY1CiAgIGFjX3N0YXR1cz0k PwpJbmRleDogY29uZmlndXJlLmFjCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGNvbmZpZ3VyZS5hYwkocmV2aXNpb24gMjA3NzEwKQorKysgY29uZmln dXJlLmFjCSh3b3JraW5nIGNvcHkpCkBAIC0zODY3LDggKzM4NjcsMTMgQEAK IAogICAgICMgVGhlc2UgdHdvIGFyZSB1c2VkIHVuY29uZGl0aW9uYWxseSBi eSBpMzg2LltjaF07IGl0IGlzIHRvIGJlIGRlZmluZWQKICAgICAjIHRvIDEg aWYgdGhlIGZlYXR1cmUgaXMgcHJlc2VudCwgMCBvdGhlcndpc2UuCisgICAg YXNfaXg4Nl9nb3RvZmZfaW5fZGF0YV9vcHQ9CisgICAgaWYgdGVzdCB4JGdh cyA9IHh5ZXM7IHRoZW4KKyAgICAgIGFzX2l4ODZfZ290b2ZmX2luX2RhdGFf b3B0PSItLTMyIgorICAgIGZpCiAgICAgZ2NjX0dBU19DSEVDS19GRUFUVVJF KFtHT1RPRkYgaW4gZGF0YV0sCi0gICAgICAgIGdjY19jdl9hc19peDg2X2dv dG9mZl9pbl9kYXRhLCBbMiwxMSwwXSwsCisgICAgICBnY2NfY3ZfYXNfaXg4 Nl9nb3RvZmZfaW5fZGF0YSwgWzIsMTEsMF0sCisgICAgICBbJGFzX2l4ODZf Z290b2ZmX2luX2RhdGFfb3B0XSwKIFsJLnRleHQKIC5MMDoKIAlub3AK --001a11332d166ae08b04f2313f36--