From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109947 invoked by alias); 26 Jan 2017 11:04:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 109937 invoked by uid 89); 26 Jan 2017 11:04:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-ua0-f177.google.com Received: from mail-ua0-f177.google.com (HELO mail-ua0-f177.google.com) (209.85.217.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Jan 2017 11:04:17 +0000 Received: by mail-ua0-f177.google.com with SMTP id y9so180552130uae.2 for ; Thu, 26 Jan 2017 03:04:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=C6opID5MYeeMOpkD7bSmJQ4zApk1F1CvC/7VusARNm8=; b=AhtYrsoeL6Yo5riOIrDgLtGrjhzPpblXvMo+kVSmv8oUfe5SpenATk0x8o3pTO1aLH RZXer6ykA3741PXXDYaCgHO0knsB2ARWCiZdFwkt0zaMTjhGX355W0Su3ty+l80sfdib 6Ar1tfYcxk9YhFVsNHzpqW6uQNHqXuWNb8j2/pENGXn8AmfflUmDcLcan3lSlWKVbsWS Gqpix/W4D0X1xlSJnh40SxIkCTkTAHv2CkVcktapccaluJRWN7TUeJzFon36+c3B8CJx HYDNY2ccA1d0R3lJi9okHI9I0bFC7T1dVOYVBUhvhIjlTjv+gwQFQZToI5zPWOu4LEgm F15Q== X-Gm-Message-State: AIkVDXLOzPDG1N3ya4Dn8/wniNDMktkgNG4nb9zb2TuO7W81jhdNQNeiHZHmroe0B9yrtsHND+3j+kqVQlMW5A== X-Received: by 10.176.5.134 with SMTP id e6mr1163659uae.108.1485428655802; Thu, 26 Jan 2017 03:04:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.87.11 with HTTP; Thu, 26 Jan 2017 03:04:15 -0800 (PST) In-Reply-To: <20170126110054.GA1867@tucnak> References: <20170119175506.GA5570@ubuntu> <20170120170801.GA3718@ubuntu> <874m0mchdf.fsf@euler.schwinge.homeip.net> <20170126104454.GA55910@ubuntu> <20170126105120.GY1867@tucnak> <20170126110054.GA1867@tucnak> From: Uros Bizjak Date: Thu, 26 Jan 2017 11:18:00 -0000 Message-ID: Subject: Re: [PATCH] Add AVX512 k-mask intrinsics To: Jakub Jelinek Cc: Kirill Yukhin , Thomas Schwinge , Andrew Senkevich , GCC Patches , Richard Biener Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2017-01/txt/msg02031.txt.bz2 On Thu, Jan 26, 2017 at 12:00 PM, Jakub Jelinek wrote: > On Thu, Jan 26, 2017 at 11:54:52AM +0100, Uros Bizjak wrote: >> On Thu, Jan 26, 2017 at 11:51 AM, Jakub Jelinek wrote: >> > On Thu, Jan 26, 2017 at 02:44:56AM -0800, Kirill Yukhin wrote: >> >> Hello Thomas, >> >> On 26 Jan 10:14, Thomas Schwinge wrote: >> >> > I see: >> >> > >> >> > {+FAIL: gcc.target/i386/avx512f-ktestw-2.c (test for excess errors)+} >> >> > {+UNRESOLVED: gcc.target/i386/avx512f-ktestw-2.c compilation failed to produce executable+} >> >> > >> >> > ... because of: >> >> > >> >> > /tmp/ccjv3mX2.s: Assembler messages: >> >> > /tmp/ccjv3mX2.s:26: Error: no such instruction: `ktestw %k1,%k0' >> >> > compiler exited with status 1 >> >> Which version of gas do you use? >> >> It should be OK since v2.25. >> > >> > It is weird, because the test already has: >> > /* { dg-require-effective-target avx512f } */ >> > Perhaps if there are gas versions with partial avx512f support, we need >> > to improve the avx512f effective target test. >> >> This is actually AVX512DQ instruction, please see [1], 3-509. >> >> [1] https://software.intel.com/sites/default/files/managed/ad/01/253666-sdm-vol-2a.pdf > > You're right. But then the tests should be named avx512dq-ktestw-{1,2}.c, > should use -mavx512dq, avx512dq effective target etc. and indeed the > intrinsics shouldn't be in avx512fintrin.h header, but dq, and should not be > enabled for f, but only dq. Yes, all this is needed to fix this oversight (and one more with kaddw), as I proposed a couple of messages earlier. Uros.