From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by sourceware.org (Postfix) with ESMTPS id F21093858D32 for ; Fri, 2 Dec 2022 06:56:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F21093858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2b.google.com with SMTP id d131so1572581ybh.4 for ; Thu, 01 Dec 2022 22:56:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=M+nVgHEMxawxwtSrWX1ngnRQg/0cpQeSu3YBymqgzi4=; b=kn9sU+vYsk15c74GKanqfVd0qQ5km1CJFx+e2upKjBWgW4BqDyw5RNnI/BcWcpcVcr yNaFiA2P0E/WWHP2wHrkxFkRE1KrzxphN66SZteIiV0gqalYw1wY6HajW19YBBo+Rqne mt1Y5zXefqBbz7Mw/v39aGLpvKpkNNRMNuyhbVpDRcQEMXEcgnzz9jDSbrX1ZMAXdu51 w1j2YWx553VJ1PS7BpXnWcnaFMC4dXgtq7VzeAWmefKQat2fNqmUIHFpWFi7oz2iP92f +wtqZZ9vzQN0RgcEaQ/zUBDMoZcI2Sobey0x+HwW/XRpXVtALcOU3IYUCPQJTMwj6+Rs gJ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M+nVgHEMxawxwtSrWX1ngnRQg/0cpQeSu3YBymqgzi4=; b=dHiraSlDTdfksQb0gfejxnkLGX7SSjJvfcKuX2gaf/ALW/rqMONm8jUlzCm5AXZOQU bH21SVvJeRw8Uj6QNSMp2PibZdfABit+xO0C1cjpJE5SJbzgbQyAsoddoi3lyP1xCFnb VDyw1yxjKvGO3xyTXR0k8ebyAo4WTd8x9Va0VtEJggs8raph98DajhC5395zmwVy3BJv W9QDfFjVmP0NOZc+93g5hKojAlZX/qC05I1ZeDxzg+cVNfLJhbwCxCTdNJlYnhn++L94 jP55bIxwOmA6IsyPgfbs41t4t7gl/rZ9oyISqnx7b/thrd1rVZSsYFer7sWYmLahhipl 1A6Q== X-Gm-Message-State: ANoB5plbS0MBJNYNQY+sJQ468MY2pJg0parR1/la1Q1klBg2ygzmC/TH +9ZknZJJ54wb+TcaxHkG3nwwvrBllEwTx/SYiO0= X-Google-Smtp-Source: AA0mqf4cai5kXlVyYHFoKuaksL+QNi5kAT6z7gUOy6xqhvflen5fku64j17xImgHJiSe1DJcwF1k17TvnnznFpc+Vcc= X-Received: by 2002:a25:d250:0:b0:6f4:f4d:c47a with SMTP id j77-20020a25d250000000b006f40f4dc47amr30972225ybg.398.1669964211137; Thu, 01 Dec 2022 22:56:51 -0800 (PST) MIME-Version: 1.0 References: <20221202042606.551350-1-hongtao.liu@intel.com> In-Reply-To: <20221202042606.551350-1-hongtao.liu@intel.com> From: Uros Bizjak Date: Fri, 2 Dec 2022 07:56:40 +0100 Message-ID: Subject: Re: [PATCH] [x86] Improve ix86_expand_fast_convert_bf_to_sf with new extendbfsf2_1. To: liuhongt Cc: gcc-patches@gcc.gnu.org, crazylht@gmail.com, hjl.tools@gmail.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Dec 2, 2022 at 5:26 AM liuhongt wrote: > > After supporting extendbfsf2_1, ix86_expand_fast_convert_bf_to_sf can > be improved with pslld either. > CONST_INT_P is not handled since constant shift can be optimized off. > > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. > Ok for trunk? > > gcc/ChangeLog: > > * config/i386/i386-expand.cc > (ix86_expand_fast_convert_bf_to_sf): Optimized with > extendbfsf2_1 for non-CONST_INT_P operand. Please say: "Use extendbfsf2_1 for nonimmediate operand." > > gcc/testsuite/ChangeLog: > > * gcc.target/i386/cbranchbf4.c: New test. Otherwise OK. Thanks, Uros. > --- > gcc/config/i386/i386-expand.cc | 13 ++++++------- > gcc/testsuite/gcc.target/i386/cbranchbf4.c | 15 +++++++++++++++ > 2 files changed, 21 insertions(+), 7 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/i386/cbranchbf4.c > > diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand.cc > index d26e7e41445..0bc80c4b178 100644 > --- a/gcc/config/i386/i386-expand.cc > +++ b/gcc/config/i386/i386-expand.cc > @@ -24155,14 +24155,13 @@ ix86_expand_fast_convert_bf_to_sf (rtx val) > /* FLOAT_EXTEND simplification will fail if VAL is a sNaN. */ > ret = gen_reg_rtx (SImode); > emit_move_insn (ret, GEN_INT (INTVAL (op) & 0xffff)); > + emit_insn (gen_ashlsi3 (ret, ret, GEN_INT (16))); > + return gen_lowpart (SFmode, ret); > } > - else > - { > - ret = gen_reg_rtx (SImode); > - emit_insn (gen_zero_extendhisi2 (ret, op)); > - } > - emit_insn (gen_ashlsi3 (ret, ret, GEN_INT (16))); > - return gen_lowpart (SFmode, ret); > + > + ret = gen_reg_rtx (SFmode); > + emit_insn (gen_extendbfsf2_1 (ret, force_reg (BFmode, val))); > + return ret; > } > > #include "gt-i386-expand.h" > diff --git a/gcc/testsuite/gcc.target/i386/cbranchbf4.c b/gcc/testsuite/gcc.target/i386/cbranchbf4.c > new file mode 100644 > index 00000000000..8241a0c2165 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/cbranchbf4.c > @@ -0,0 +1,15 @@ > +/* { dg-do compile } */ > +/* { dg-options "-fexcess-precision=16 -O -msse2 -mfpmath=sse" } */ > +/* { dg-final { scan-assembler-times "pslld" 4 } } */ > + > +char > +foo (__bf16 a, __bf16 b) > +{ > + return a > b; > +} > + > +float > +foo1 (__bf16 a, __bf16 b, float c, float d) > +{ > + return a > b ? c : d; > +} > -- > 2.27.0 >