From: Uros Bizjak <ubizjak@gmail.com>
To: Kai Tietz <ktietz70@googlemail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Henderson <rth@redhat.com>
Subject: Re: [PATCH, i386]: Fix recently added sibcall insns and peephole2 patterns
Date: Wed, 18 Jun 2014 13:10:00 -0000 [thread overview]
Message-ID: <CAFULd4Z1bnzf7AvZAxqmOA3mDTB5UJwK=6qVHOWBiP9B-y9Zjg@mail.gmail.com> (raw)
In-Reply-To: <CAEwic4YES86=5-wxP1jS2AJb-GvRmpv98Z+crb2tocLFUEjf+g@mail.gmail.com>
On Wed, Jun 18, 2014 at 2:24 PM, Kai Tietz <ktietz70@googlemail.com> wrote:
> The following change in predicates.md seems to be a bit premature.
> There is still the point about Darwin's PIC issue for unspec-gotpcrel.
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61387
>
> return ANY_QI_REG_P (op);
> })
>
> +;; Return true if OP is a memory operands that can be used in sibcalls.
> (define_predicate "sibcall_memory_operand"
> - (match_operand 0 "memory_operand")
> -{
> - return CONSTANT_P (XEXP (op, 0));
> -})
> + (and (match_operand 0 "memory_operand")
> + (match_test "CONSTANT_P (XEXP (op, 0))")))
>
> as we might to pessimize for Darwin UNSPEC_GOTPCREL at that point.
> In general there is still the question why this issue just happens
> for Darwin, but not for linux. For linux that gotpcrel-code path
> seems not to be hit at all (at least is that what Ians told).
Oh, this part doesn't change any functionality at all. The predicate
is just written in a different way.
Uros.
next prev parent reply other threads:[~2014-06-18 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 10:24 Uros Bizjak
2014-06-18 12:24 ` Kai Tietz
2014-06-18 13:10 ` Uros Bizjak [this message]
2014-06-18 13:11 Dominique Dhumieres
2014-06-18 13:45 ` Kai Tietz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4Z1bnzf7AvZAxqmOA3mDTB5UJwK=6qVHOWBiP9B-y9Zjg@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ktietz70@googlemail.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).