From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-397671-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 69343 invoked by alias); 12 May 2015 15:33:49 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 69298 invoked by uid 89); 12 May 2015 15:33:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2
X-HELO: mail-oi0-f53.google.com
Received: from mail-oi0-f53.google.com (HELO mail-oi0-f53.google.com) (209.85.218.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 12 May 2015 15:33:47 +0000
Received: by oiko83 with SMTP id o83so8977560oik.1        for <gcc-patches@gcc.gnu.org>; Tue, 12 May 2015 08:33:45 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.60.137.201 with SMTP id qk9mr12618039oeb.15.1431444825895; Tue, 12 May 2015 08:33:45 -0700 (PDT)
Received: by 10.60.147.170 with HTTP; Tue, 12 May 2015 08:33:45 -0700 (PDT)
Date: Tue, 12 May 2015 15:47:00 -0000
Message-ID: <CAFULd4Z2R7g=H3cTPfwERuxc9XYnipzeC9ExQHhN8AsN0skGww@mail.gmail.com>
Subject: Re: [PATCH, PR target/65103, 3/3] Change rtx cost for i386 address constants
From: Uros Bizjak <ubizjak@gmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: =?UTF-8?B?0JjQu9GM0Y8g0K3QvdC60L7QstC40Yc=?= <enkovich.gnu@gmail.com>
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2015-05/txt/msg01109.txt.bz2

Hello!

>> 2015-03-10  Ilya Enkovich  <ilya.enkovich@intel.com>
>>
>>         PR target/65103
>>         * config/i386/i386.c (ix86_rtx_costs): We want to propagate
>>         link time constants into adress expressions and therefore set
>>         their cost to 0.
>>
>> gcc/testsuite/
>>
>> 2015-03-10  Ilya Enkovich  <ilya.enkovich@intel.com>
>>
>>         PR target/65103
>>         * gcc.target/i386/pr65103-3.c: New.
>>
>>
>> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
>> index b3971b8..341a157 100644
>> --- a/gcc/config/i386/i386.c
>> +++ b/gcc/config/i386/i386.c
>> @@ -42039,7 +42039,8 @@ ix86_rtx_costs (rtx x, int code_i, int outer_code_i, int opno, int *total,
>>                && !(TARGET_64BIT
>>                     && (GET_CODE (x) == LABEL_REF
>>                         || (GET_CODE (x) == SYMBOL_REF
>> -                           && SYMBOL_REF_LOCAL_P (x)))))
>> +                           && SYMBOL_REF_LOCAL_P (x))))
>> +              && (TARGET_64BIT || GET_CODE (x) != CONST))

Please also add a one-line comment for the new condition.

OK with this change.

Uros.