From: Uros Bizjak <ubizjak@gmail.com>
To: Rainer Orth <ro@cebitec.uni-bielefeld.de>
Cc: gcc-patches@gcc.gnu.org, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH] testsuite: i386: Fix gcc.target/i386/no-callee-saved-1.c etc. on Solaris/x86
Date: Wed, 31 Jan 2024 20:28:40 +0100 [thread overview]
Message-ID: <CAFULd4Z3ZUodu7e3pyWvKqhgziV909gwcsua6LXvRRDcrahW=g@mail.gmail.com> (raw)
In-Reply-To: <yddjznpu0cm.fsf@CeBiTec.Uni-Bielefeld.DE>
On Wed, Jan 31, 2024 at 1:57 PM Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>
> The gcc.target/i386/no-callee-saved-[12].c tests FAIL on Solaris/x86:
>
> FAIL: gcc.target/i386/no-callee-saved-1.c scan-assembler-not push
> FAIL: gcc.target/i386/no-callee-saved-2.c scan-assembler-not push
>
> In both cases, the test expect the Linux/x86 default of
> -fomit-frame-pointer, while Solaris/x86 defaults to
> -fno-omit-frame-pointer.
>
> So this patch explicitly specifies -fomit-frame-pointer.
>
> Tested on i386-pc-solaris2.11 (as and gas) and i686-pc-linux-gnu.
>
> Ok for trunk?
OK.
Thanks,
Uros.
>
> Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
> 2024-01-30 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>
> gcc/testsuite:
> * gcc.target/i386/no-callee-saved-1.c: Add -fomit-frame-pointer to
> dg-options.
> * gcc.target/i386/no-callee-saved-2.c: Likewise.
>
prev parent reply other threads:[~2024-01-31 19:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 12:57 Rainer Orth
2024-01-31 19:28 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4Z3ZUodu7e3pyWvKqhgziV909gwcsua6LXvRRDcrahW=g@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).