From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by sourceware.org (Postfix) with ESMTPS id 853283888816 for ; Fri, 13 May 2022 14:00:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 853283888816 Received: by mail-qt1-x82c.google.com with SMTP id k2so6878066qtp.1 for ; Fri, 13 May 2022 07:00:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BvtDvMLiVcNBTqigbjtR8RW81Eogd5StI8Pnbx8GCjw=; b=q+14R3Ol+MCPSTR6bqtP9YUJ+o5KZLCJ4h+T3RKjZeIkpvU8+QHLvLvzwcyWQSiBnX 3TzUr9wkUQq2eEDyaDre48IeNOfs8f22bdlpfcpu2DvFXtZ03YngCly1OJ+cG15oeyCq E9kEQusrxm24F+OZ+BsjK+XnjLI3h+yf4PSnbJLSEoqipqGn1ke6vv5/MqJICgAYH92b 428cwGdMCBGYHEiG6GBw7io7ASeE14c9pOpgtKEWazg4y1H1uKmBz9+vMRDjHMDfSsJq f2vbNCuanYY8DOd0CHOY+jYCFDz2tRPRAXO9LTGQAhF9pdXe869OJgovZqGJgi3PknFU s/Eg== X-Gm-Message-State: AOAM531kVFk+fQ9KOgtfk1baULDGHfKpJlfY13dz+I5AP2kPwyKD2qZr f2UiASZjN2na+7Ii3uW8d1BZ0VcayU9GK+Nogwc2gAs9KsA= X-Google-Smtp-Source: ABdhPJyhoyhest6T7hvtp5U7cSZ14Csx+4U7aN1GF3M99LnXlsHRrClDJ3k9+S+v1sxS5drogAE4+bHxMlrdlbLHR/o= X-Received: by 2002:ac8:5a82:0:b0:2f3:bac5:6158 with SMTP id c2-20020ac85a82000000b002f3bac56158mr4562821qtc.57.1652450434762; Fri, 13 May 2022 07:00:34 -0700 (PDT) MIME-Version: 1.0 References: <20220513114259.19129-1-hongtao.liu@intel.com> In-Reply-To: <20220513114259.19129-1-hongtao.liu@intel.com> From: Uros Bizjak Date: Fri, 13 May 2022 16:00:23 +0200 Message-ID: Subject: Re: [PATCH] [i386] Fix ICE caused by wrong condition. To: liuhongt Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2022 14:00:37 -0000 On Fri, May 13, 2022 at 1:43 PM liuhongt wrote: > > When d->perm[i] == d->perm[i-1] + 1 and d->perm[i] == nelt, it's not > continuous. It should fail if there's more than 2 continuous areas. > > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. > Ok for trunk? > > > gcc/ChangeLog: > > PR target/105587 > * config/i386/i386-expand.cc > (expand_vec_perm_pslldq_psrldq_por): Fail when (d->perm[i] == > d->perm[i-1] + 1) && d->perm[i] == nelt && start != -1. > > gcc/testsuite/ChangeLog: > > * gcc.target/i386/pr105587.c: New test. LGTM, probably even obvious patch. Thanks, Uros. > --- > gcc/config/i386/i386-expand.cc | 9 ++------- > gcc/testsuite/gcc.target/i386/pr105587.c | 11 +++++++++++ > 2 files changed, 13 insertions(+), 7 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/i386/pr105587.c > > diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand.cc > index 0fd3028c205..806e1f5aaa3 100644 > --- a/gcc/config/i386/i386-expand.cc > +++ b/gcc/config/i386/i386-expand.cc > @@ -20963,7 +20963,8 @@ expand_vec_perm_pslldq_psrldq_por (struct expand_vec_perm_d *d, bool pandn) > start1 = d->perm[0]; > for (i = 1; i < nelt; i++) > { > - if (d->perm[i] != d->perm[i-1] + 1) > + if (d->perm[i] != d->perm[i-1] + 1 > + || d->perm[i] == nelt) > { > if (start2 == -1) > { > @@ -20973,12 +20974,6 @@ expand_vec_perm_pslldq_psrldq_por (struct expand_vec_perm_d *d, bool pandn) > else > return false; > } > - else if (d->perm[i] >= nelt > - && start2 == -1) > - { > - start2 = d->perm[i]; > - end1 = d->perm[i-1]; > - } > } > > clear_op0 = end1 != nelt - 1; > diff --git a/gcc/testsuite/gcc.target/i386/pr105587.c b/gcc/testsuite/gcc.target/i386/pr105587.c > new file mode 100644 > index 00000000000..a5b6ab2a016 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/pr105587.c > @@ -0,0 +1,11 @@ > +#/* { dg-do compile } */ > +/* { dg-options "-O3 -msse2 -mno-ssse3" } */ > + > +extern short arr_108[][4][2][24][12], arr_110[][4][2][24][12]; > +void test() { > + for (unsigned a = 0; a < 2; a += 2) > + for (unsigned b = 4; b < 22; b++) > + for (int c = 1; c < 11; c++) > + arr_110[0][0][a][b][c] = (unsigned char)arr_108[0][0][a][b][c]; > +} > + > -- > 2.18.1 >