From: Uros Bizjak <ubizjak@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] i386: Use OI/TImode in *mov[ot]i_internal_avx with AVX512VL
Date: Tue, 12 Feb 2019 18:03:00 -0000 [thread overview]
Message-ID: <CAFULd4Z965Sck7G5rZsQnSC9x-z6WSMck_L8n72puG6JK+pbBg@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOqJXNPKs_gsXFE4mypqE2rkDc5wTTtGUL9mz2FEGvGaiQ@mail.gmail.com>
On Fri, Feb 8, 2019 at 12:29 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Fri, Feb 8, 2019 at 1:51 AM Uros Bizjak <ubizjak@gmail.com> wrote:
> >
> > On Thu, Feb 7, 2019 at 10:11 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > OImode and TImode moves must be done in XImode to access upper 16
> > > vector registers without AVX512VL. With AVX512VL, we can access
> > > upper 16 vector registers in OImode and TImode.
> > >
> > > PR target/89229
> > > * config/i386/i386.md (*movoi_internal_avx): Set mode to XI for
> > > upper 16 vector registers without TARGET_AVX512VL.
> > > (*movti_internal): Likewise.
> >
> > Please use (not (match_test "...")) instead of (match_test "!...") and
> > put the new test as the first argument of the AND rtx.
> >
> > LGTM with the above change.
>
> This is the patch I am checking in.
HJ,
please revert two PR89229 patches as they introduce a regression.
Uros.
> Thanks.
>
> H.J.
> ---
> OImode and TImode moves must be done in XImode to access upper 16
> vector registers without AVX512VL. With AVX512VL, we can access
> upper 16 vector registers in OImode and TImode.
>
> PR target/89229
> * config/i386/i386.md (*movoi_internal_avx): Set mode to XI for
> upper 16 vector registers without TARGET_AVX512VL.
> (*movti_internal): Likewise.
> ---
> gcc/config/i386/i386.md | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md
> index c1492363bca..3d9141ae450 100644
> --- a/gcc/config/i386/i386.md
> +++ b/gcc/config/i386/i386.md
> @@ -1933,8 +1933,9 @@
> (set_attr "type" "sselog1,sselog1,ssemov,ssemov")
> (set_attr "prefix" "vex")
> (set (attr "mode")
> - (cond [(ior (match_operand 0 "ext_sse_reg_operand")
> - (match_operand 1 "ext_sse_reg_operand"))
> + (cond [(and (not (match_test "TARGET_AVX512VL"))
> + (ior (match_operand 0 "ext_sse_reg_operand")
> + (match_operand 1 "ext_sse_reg_operand")))
> (const_string "XI")
> (and (eq_attr "alternative" "1")
> (match_test "TARGET_AVX512VL"))
> @@ -2012,8 +2013,9 @@
> (set (attr "mode")
> (cond [(eq_attr "alternative" "0,1")
> (const_string "DI")
> - (ior (match_operand 0 "ext_sse_reg_operand")
> - (match_operand 1 "ext_sse_reg_operand"))
> + (and (not (match_test "TARGET_AVX512VL"))
> + (ior (match_operand 0 "ext_sse_reg_operand")
> + (match_operand 1 "ext_sse_reg_operand")))
> (const_string "XI")
> (and (eq_attr "alternative" "3")
> (match_test "TARGET_AVX512VL"))
> --
next prev parent reply other threads:[~2019-02-12 18:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 21:11 H.J. Lu
2019-02-08 9:51 ` Uros Bizjak
2019-02-08 11:29 ` H.J. Lu
2019-02-09 0:31 ` [PATCH] i386: Use EXT_REX_SSE_REG_P in *movoi_internal_avx/movti_internal H.J. Lu
2019-02-09 9:50 ` Uros Bizjak
2019-02-09 9:56 ` Jakub Jelinek
2019-02-09 10:40 ` Jakub Jelinek
2019-02-09 10:51 ` Jakub Jelinek
2019-02-09 12:12 ` H.J. Lu
2019-02-09 12:22 ` Jakub Jelinek
2019-02-09 13:39 ` Jakub Jelinek
2019-02-11 13:11 ` H.J. Lu
2019-02-11 13:15 ` Uros Bizjak
2019-02-11 13:29 ` H.J. Lu
2019-02-11 13:51 ` Uros Bizjak
2019-02-11 14:32 ` H.J. Lu
2019-02-11 15:57 ` Uros Bizjak
2019-02-11 16:03 ` H.J. Lu
2019-02-11 16:24 ` Jakub Jelinek
2019-02-14 2:34 ` [PATCH] i386: Properly encode xmm16-xmm31/ymm16-ymm31 for vector move H.J. Lu
2019-02-11 13:47 ` [PATCH] i386: Use EXT_REX_SSE_REG_P in *movoi_internal_avx/movti_internal Jakub Jelinek
2019-02-12 18:03 ` Uros Bizjak [this message]
2019-02-12 19:01 ` [PATCH] i386: Use OI/TImode in *mov[ot]i_internal_avx with AVX512VL H.J. Lu
2019-02-11 2:35 ` Alan Modra
2019-02-11 7:23 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4Z965Sck7G5rZsQnSC9x-z6WSMck_L8n72puG6JK+pbBg@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).