From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ubizjak@gmail.com>
Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b])
	by sourceware.org (Postfix) with ESMTPS id 4D3D53858D3C
	for <gcc-patches@gcc.gnu.org>; Sun, 16 Oct 2022 17:49:01 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D3D53858D3C
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-yb1-xb2b.google.com with SMTP id k3so10977604ybk.9
        for <gcc-patches@gcc.gnu.org>; Sun, 16 Oct 2022 10:49:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=+JmcKeYb2DFFbTN58yGOre4g7p/y30Wkp6VaAi3cXyY=;
        b=gtu3JxvXwWtDrCAa9VAVvdco9arClq++TIAQYZpgf0YqLLoVYOGlzSvytReqbxmOhW
         Sm35k8TnRp6Cd22rbduX5YLQDaPxIsgVDyBhb7+G//iBCB97yPPQEP5yq4uuCoiMstHL
         849nweBlteoqDWFY6ycEF5TksbQWiM9BsKYlmx4q7ytzBz6I+hewy5C8ngnZdrBke1+2
         4a3AIe0fU7hSTEwF9/BRDYkKCuC6qUDocZMrNxFqVUedDBMm5IMG3COp4zztSaysTV+q
         411BaryJO2MC/2QIj34wqpZk6KNFcgtu3h6WWYBhjAOseIAz/xhlbfqo8kI9TrLx74vl
         dhhQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=+JmcKeYb2DFFbTN58yGOre4g7p/y30Wkp6VaAi3cXyY=;
        b=HhkNG5OXnQNVPlIrL1JeVZITRwMMkf+LmGKcloaCDsGAq4NWWI3ZwpNvvu3WqfPZ18
         cFbQwuIib188onX7XFOpAheRQj2ooKI/5U2uw67vH6G1HXacUEKTp0M6lIfqhN63TOBg
         n6JvPXqZb1SRrwvOLd8nRQAxoc3iq9DN3Of+fiTrC6WiOlr6v0GZzEax6ckPAOaT9RHH
         rXUTPE5ZZp8EjmaJWpieWeXJViK9qnjnZaT6HWBYiSECBDQsybJ9bBBIUAUS/PykxGmT
         BNkdIjks5cwaiWsoF0DAyWQH1TFOXzwiUJl6xZlJ9LNfWFUfIm14VSxAARnki7qqVnWu
         0ygA==
X-Gm-Message-State: ACrzQf0YZSL06eSZ6/loeqJI2I+YiaMvpFhFmnvtBhfqDhMfcSyX3Cn6
	/0mmN2WfEIXeCnfOfiNIRxlteXthYlvML1aQi80=
X-Google-Smtp-Source: AMsMyM4gN0PkmsaK5lIWPKHhcyQmYFU4bPe1DGukrjoEuSmAtTTObm/onb8DPK2tocq7OIttQ37hW1ZO7dJtT/+uy+o=
X-Received: by 2002:a5b:a44:0:b0:6b0:13b:c93b with SMTP id z4-20020a5b0a44000000b006b0013bc93bmr6665282ybq.398.1665942540605;
 Sun, 16 Oct 2022 10:49:00 -0700 (PDT)
MIME-Version: 1.0
References: <DM6PR12MB4795EB24ADE00211DE7155CBE3259@DM6PR12MB4795.namprd12.prod.outlook.com>
In-Reply-To: <DM6PR12MB4795EB24ADE00211DE7155CBE3259@DM6PR12MB4795.namprd12.prod.outlook.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Sun, 16 Oct 2022 19:48:49 +0200
Message-ID: <CAFULd4Z9FggfETr2hdb=Mi0MwzJY+86Lei-=AjW6ThmrTvGdZA@mail.gmail.com>
Subject: Re: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU
To: "Joshi, Tejas Sanjay" <TejasSanjay.Joshi@amd.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, 
	"Kumar, Venkataramanan" <Venkataramanan.Kumar@amd.com>, 
	"honza.hubicka@gmail.com" <honza.hubicka@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Thu, Oct 13, 2022 at 5:33 PM Joshi, Tejas Sanjay
<TejasSanjay.Joshi@amd.com> wrote:
>
> [Public]
>
> Hi all,
>
> PFA, the patch that enables support for the next generation AMD Zen4 CPU via -march=znver4.
> This is a basic enablement patch and as of now the costings, tunings are kept same as znver3.
>
> Good for trunk?

2022-09-28  Tejas Joshi <TejasSanjay.Joshi@amd.com>

gcc/ChangeLog:

    * common/config/i386/cpuinfo.h (get_amd_cpu): Recognize znver4.
    * common/config/i386/i386-common.cc (processor_names): Add znver4.
    (processor_alias_table): Add znver4 and modularize old znvers.
    * common/config/i386/i386-cpuinfo.h (processor_subtypes):
    AMDFAM19H_ZNVER4.
    * config.gcc (x86_64-*-* |...): Likewise.
    * config/i386/driver-i386.cc (host_detect_local_cpu): Let
    -march=native recognize znver4 cpus.
    * config/i386/i386-c.cc (ix86_target_macros_internal): Add znver4.
    * config/i386/i386-options.cc (m_ZNVER4): New definition.
    (m_ZNVER): Include m_ZNVER4.
    (processor_cost_table): Add znver4.
    * config/i386/i386.cc (ix86_reassociation_width): Likewise.
    * gcc/config/i386/i386.h (processor_type): Add PROCESSOR_ZNVER4.
    (PTA_ZNVER1): New definition.
    (PTA_ZNVER2): Likewise.
    (PTA_ZNVER3): Likewise.
    (PTA_ZNVER4): Likewise.
    * config/i386/i386.md (define_attr "cpu"): Add znver4.
    * config/i386/x86-tune-costs.h (znver4_cost): New definition.
    * config/i386/x86-tune-sched.cc (ix86_issue_rate): Add znver4.
    (ix86_adjust_cost): Likewise.
    * config/i386/znver1.md: Add new reservations for znver4.
    * doc/extend.texi: Add details about znver4.
    * doc/invoke.texi: Likewise.

gcc/testsuite/ChangeLog:

    * gcc.target/i386/funcspec-56.inc: Handle new march.
    * g++.target/i386/mv29.C: Likewise.

Although I didn't check all the details of the new scheduler model,
the patch LGTM for mainline.

BTW: Perhaps znver1.md is not the right filename anymore, since it
hosts all four Zen schedulers.

Thanks,
Uros.