From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by sourceware.org (Postfix) with ESMTPS id 856463858413 for ; Mon, 3 Oct 2022 20:41:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 856463858413 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb32.google.com with SMTP id 126so14497248ybw.3 for ; Mon, 03 Oct 2022 13:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=XKmC3O9Zm66s9TELErFNvwcdm0+etR4nczcWrGV+O7A=; b=L9GENtrjJ2PTJ46geT2D4HAA/qGS2XIaRH/tWR1C+ZwgcR1gY43B4sQ5bynAFIcoKX VK/UyX161ONeKkpm/IltDqtPVNp42/lMD7+/gkFCt8phTa4EWGI/wZYMe+mBZc6DIG48 UCPjWbAKrdurfrRQcH9tWZEfZWPEYQP/VnvqXfPTGMCB+Qr4Lj96XjFbb/XZ8tng1qII aG7zO7UavIPS9xJtReDDKEg3Ku0f04j9SHv7QITvbGfb1yD87UIS/GMo9/C9kdjIQnHi SCrMJeZmTZHW3EIZMjg8Qd7EzYPviL/FgN4zUd1AzS4RuRLt+Ln/Wm+ym1M7HetueT2N JeEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=XKmC3O9Zm66s9TELErFNvwcdm0+etR4nczcWrGV+O7A=; b=kXuE9cudeMs5WUuHUvOT+VOwQ01iNJgcCMl1kJZEW07q7elIEDprHlxpPNFaxORLBw 0+Xapq7A63MhssAfoXHnZXurka3j8AwzBIVBHH6KDECDheQ02yeTi6OOMeSGeFxsKR6f Bj5gTD7s7zUnZvQuZbRjpZAflUpW8qvdso7Z5qqNGf+MS6BQUHKto+g7rsEI8p/PIFuC ic/FU+cs2rd1l+PlmStJ53ASh1zLLY9MbcbEL++P0560YpYbM3duMOiJBCZcBxlFvTEW B+BF8t3wxu/TNmHTMQKiSl47f0O4X5u0vlS5iMG0b3A/hcAchGnXqFwEE989zwNx8gUj MzUA== X-Gm-Message-State: ACrzQf34F56m6tbViNGnI3PpTwO8kCruFcfi4ifpHDcZZyPfkSdSplP8 T08vytgNucrykGbN0moKpa8ReASp5ZNHBa/6lqI= X-Google-Smtp-Source: AMsMyM4wg4fqtWXEO700IrN2bHdZA4539wyvZrmyUpN84UbX/l9Du43TvHTNl3K56dikX6vL2HTkm9EyKiovO/KX3J8= X-Received: by 2002:a25:2495:0:b0:6be:22d:deef with SMTP id k143-20020a252495000000b006be022ddeefmr2907217ybk.209.1664829701808; Mon, 03 Oct 2022 13:41:41 -0700 (PDT) MIME-Version: 1.0 References: <20220916184922.3274016-1-slyich@gmail.com> <20221003080456.258fa375@nz> In-Reply-To: <20221003080456.258fa375@nz> From: Uros Bizjak Date: Mon, 3 Oct 2022 22:41:30 +0200 Message-ID: Subject: Re: PING [PATCH] gcc/config/t-i386: add build dependencies on i386-builtin-types.inc To: Sergei Trofimovich Cc: GCC Patches , Sergei Trofimovich Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 3, 2022 at 9:05 AM Sergei Trofimovich via Gcc-patches wrote: > > On Thu, 22 Sep 2022 22:07:52 +0100 > Sergei Trofimovich wrote: > > > On Fri, 16 Sept 2022 at 19:49, Sergei Trofimovich wrote: > > > > > > From: Sergei Trofimovich > > > > > > i386-builtin-types.inc is included indirectly via i386-builtins.h > > > into 4 files: i386.cc i386-builtins.cc i386-expand.cc i386-features.cc > > > > > > Only i386.cc dependency was present in gcc/config/t-i386 makefile. > > > > > > As a result parallel builds occasionally fail as: > > > > > > g++ ... -o i386-builtins.o ... ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc > > > In file included from ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc:92: > > > ../../gcc-13-20220911/gcc/config/i386/i386-builtins.h:25:10: > > > fatal error: i386-builtin-types.inc: No such file or directory > > > 25 | #include "i386-builtin-types.inc" > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > compilation terminated. > > > make[3]: *** [../../gcc-13-20220911/gcc/config/i386/t-i386:54: i386-builtins.o] > > > Error 1 shuffle=1663349189 > > > > > > gcc/ > > > * config/i386/t-i386: Add build-time dependencies against > > > i386-builtin-types.inc to i386-builtins.o, i386-expand.o, > > > i386-features.o. OK. Thanks, Uros. > > > --- > > > gcc/config/i386/t-i386 | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/gcc/config/i386/t-i386 b/gcc/config/i386/t-i386 > > > index 4e2a0efc615..ffdbbdfe8ce 100644 > > > --- a/gcc/config/i386/t-i386 > > > +++ b/gcc/config/i386/t-i386 > > > @@ -62,7 +62,12 @@ i386-features.o: $(srcdir)/config/i386/i386-features.cc > > > $(COMPILE) $< > > > $(POSTCOMPILE) > > > > > > +# i386-builtin-types.inc is included into i386-builtins.h. > > > +# Below are direct users of i386-builtins.h: > > > i386.o: i386-builtin-types.inc > > > +i386-builtins.o: i386-builtin-types.inc > > > +i386-expand.o: i386-builtin-types.inc > > > +i386-features.o: i386-builtin-types.inc > > > > > > i386-builtin-types.inc: s-i386-bt ; @true > > > s-i386-bt: $(srcdir)/config/i386/i386-builtin-types.awk \ > > > -- > > > 2.37.2 > > > > > > > Is it a reasonable approach? Maybe gcc has an equivalent of automake's > > BUILT_SOURCES to avoid explicit tracking of such dependencies? > > > > -- > > Sergei > > > -- > > Sergei