From: Uros Bizjak <ubizjak@gmail.com>
To: Oleg Endo <oleg.endo@t-online.de>
Cc: gcc-patches@gcc.gnu.org, vbyakovl23@gmail.com,
Kaz Kojima <kkojima@rr.iij4u.or.jp>
Subject: Re: [PATCH, middle-end]: Fix mode-switching MODE_EXIT check with __builtin_apply/__builtin_return
Date: Sun, 04 Nov 2012 18:06:00 -0000 [thread overview]
Message-ID: <CAFULd4Z=hwBo7oXVE9j3-JksCFmqYgCR9yqRSADK8z+EY8SeZQ@mail.gmail.com> (raw)
In-Reply-To: <CAFULd4YBNXcH3hYhPb-6h2+UZE_NfqJ9ytKd8cP=7hzVoYWvfg@mail.gmail.com>
On Sun, Nov 4, 2012 at 4:23 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>>>> Patch was bootstrapped and regression tested on x86_64-pc-linux-gnu,
>>>> with vzeroupper patch [1] applied.
>>>>
>>>> I have added SH4 maintainer for possible comments.
>>>
>>> BTW, there are at least two mode-switching SH PRs: 41933 and 49220.
>>> I've tried those test cases with the vzeroupper patch [1] applied.
>>> Unfortunately, it doesn't change the situation of the two PRs.
>>
>> True, this patch fixes very specific case involving __builtin_apply
>> only. Hopefully it doesn't _break_ something on SH.
>
> FYI, the testcase from PR41993 involving __builtin_return inserts
> vzeroupper at correct place, even with "-O0 -mavx -vzeroupper", so the
> ICE seems SH specific. The testcase from PR49220 works OK as well for
> all compile flags I have tried, although YMM registers are not used,
> and consequently no vzerouppers are inserted.
Please see PR41993 for follow-up discussion and possible fix.
Uros.
next prev parent reply other threads:[~2012-11-04 18:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 13:52 Uros Bizjak
2012-11-04 14:58 ` Oleg Endo
2012-11-04 15:03 ` Uros Bizjak
2012-11-04 15:23 ` Uros Bizjak
2012-11-04 18:06 ` Uros Bizjak [this message]
2012-11-05 9:10 ` Kaz Kojima
2012-11-05 9:55 ` Vladimir Yakovlev
2012-11-05 18:07 ` Eric Botcazou
2012-11-05 18:34 ` Uros Bizjak
2012-11-05 18:43 ` Uros Bizjak
2012-11-05 19:07 ` Uros Bizjak
2012-11-05 19:32 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4Z=hwBo7oXVE9j3-JksCFmqYgCR9yqRSADK8z+EY8SeZQ@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kkojima@rr.iij4u.or.jp \
--cc=oleg.endo@t-online.de \
--cc=vbyakovl23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).