* [PATCH, libgo]: Double StackMin size for 64bit non-split-stack targets
@ 2014-12-24 13:17 Uros Bizjak
2015-01-05 16:13 ` Ian Lance Taylor
0 siblings, 1 reply; 2+ messages in thread
From: Uros Bizjak @ 2014-12-24 13:17 UTC (permalink / raw)
To: gcc-patches; +Cc: gofrontend-dev, Ian Taylor
Hello!
The attached patch doubles StackMin size for 64bit non-split-stack
targets. This patch fixes regexp libgo failure (tracked as gcc PR61871
[1]) on alpha-linux-gnu.
--cut here--
Index: runtime/proc.c
===================================================================
--- runtime/proc.c (revision 219035)
+++ runtime/proc.c (working copy)
@@ -51,7 +51,7 @@
#if defined(USING_SPLIT_STACK) && defined(LINKER_SUPPORTS_SPLIT_STACK)
# define StackMin PTHREAD_STACK_MIN
#else
-# define StackMin 2 * 1024 * 1024
+# define StackMin ((sizeof(char *) < 8) ? 2 * 1024 * 1024 : 4 * 1024 * 1024)
#endif
uintptr runtime_stacks_sys;
--cut here--
Bootstrapped and regression tested on alphaev68-linux-gnu.
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61871
Uros.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH, libgo]: Double StackMin size for 64bit non-split-stack targets
2014-12-24 13:17 [PATCH, libgo]: Double StackMin size for 64bit non-split-stack targets Uros Bizjak
@ 2015-01-05 16:13 ` Ian Lance Taylor
0 siblings, 0 replies; 2+ messages in thread
From: Ian Lance Taylor @ 2015-01-05 16:13 UTC (permalink / raw)
To: Uros Bizjak; +Cc: gcc-patches, gofrontend-dev
On Wed, Dec 24, 2014 at 3:44 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>
> The attached patch doubles StackMin size for 64bit non-split-stack
> targets. This patch fixes regexp libgo failure (tracked as gcc PR61871
> [1]) on alpha-linux-gnu.
>
> --cut here--
> Index: runtime/proc.c
> ===================================================================
> --- runtime/proc.c (revision 219035)
> +++ runtime/proc.c (working copy)
> @@ -51,7 +51,7 @@
> #if defined(USING_SPLIT_STACK) && defined(LINKER_SUPPORTS_SPLIT_STACK)
> # define StackMin PTHREAD_STACK_MIN
> #else
> -# define StackMin 2 * 1024 * 1024
> +# define StackMin ((sizeof(char *) < 8) ? 2 * 1024 * 1024 : 4 * 1024 * 1024)
> #endif
>
> uintptr runtime_stacks_sys;
> --cut here--
Thanks. Committed. Sorry for the delay.
Ian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-05 16:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-24 13:17 [PATCH, libgo]: Double StackMin size for 64bit non-split-stack targets Uros Bizjak
2015-01-05 16:13 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).