From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by sourceware.org (Postfix) with ESMTPS id A75EE3858D35 for ; Thu, 7 Mar 2024 09:16:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A75EE3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A75EE3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::234 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709803015; cv=none; b=Y1fASr+4Ua2Es7qb4bqlB/jbii/ReP6JKGIqcmJDrNOFmlWReSyvX4ydC1fBUdZlvM8VhXuY+RIMMxeyO9ILqbNV1yK9lH/Dv8fWEuOb8DAHsOLa6S21lvo8q3l2tAA0cIZ5NLp3iFEbsYv+ctu6AiDNpIstiJ+OqT8/L1pxlgo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709803015; c=relaxed/simple; bh=lKDVnh13C7qMfZmniYS3+CdvrCHTA1JLLWyMqxgt9t8=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=abWSdSM4ZMgj6aBZg4gOSKagcO+FuKmgT6R4NCAa4sboGhmHUibANVKA4UV8SyfvpdESxdGYnbuJNr2AwGAadAea25B5IAx90xMuu32DY4ivVtZTMoWpIEFb/wgM4oWCehG4O7jzPXfJKcWcENxwCXDU4vZhGbPKmLrlQskvyc4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2d288bac3caso7791751fa.2 for ; Thu, 07 Mar 2024 01:16:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709803012; x=1710407812; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=P51Mrpiziij1wR/9+fgJ4AuAAdKlaBnuu4m0ds5rWYo=; b=BKfzbxImmP6ZA9+0XhA8kdvYu+mQgAPItXJUmJjaAIspAUiUBYh2I2PWAw/UVzfRf3 5CbzP/OQBKBQkRQa80zGdIcc3j5wdYtJfCfGdgRVytk7HSYyn0tYwdUqXuYTX9bPKt/w x8Abp4SKvtAkKl/3BRqtofmcqM71EGOFPIC5pRWARL4Yq0sXJr7ZhMnez8a8HIwqGu8q jZbWol8WPJ4yNdCzRjvdE+XqJQ/tos18zror02NyWHeGtINg0vtzwrlUvgATLTCh5MgA Vgg6fM+j3FFtK3PDFWREyitkzk6PNTRMvLbYSCR5ocQyhucHWLfHgtEqKi56lzbizW2w EJgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709803012; x=1710407812; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=P51Mrpiziij1wR/9+fgJ4AuAAdKlaBnuu4m0ds5rWYo=; b=XPLaUgDuT9AX9xWxq9DIOls9L+Igb/lLwjMa4+eJ3UhukqDJsq6i4nqizJmQw2HEZr 593oQG1xakrrutMKOuMKhgB88Te8G+nzwnAxij7lHwuqOMXmteG1bTS2k+7JJ8OT30TA 9iasD8V7zukYpGhtAStlkih2iJZzdDCh5p6gh/+z3I+Rug1A7UBCXWWVRUS2CFsHbmG0 cfdwoqWXfoycfOLX/oeQx5lRb6bjsopXK1GnBBbwm1SDv4nWAtCgfb5dDCmyeatcRaKp zGkvJcnPpDaNOF+7OOS6dDO9SpJmhlB0xIMyiEe1a1gP+cr6qiRhAfHoo33JV9pbogFT PHsQ== X-Gm-Message-State: AOJu0Yyp+aPBsQgHgMReBuuxCRyoSllL10zzBrN4z3A7khtpm+vCcAdJ BzjtnKxAxSKRSu4dHdivsVl0aW9M4vInBxLtZdhJdu8Nt3XL8ZhuGFXj4tiv1o30VTFsROHs+16 d0NZc8ejL4GRZ8sWwQ/EM1vezE/xk3IWsGV20Qg== X-Google-Smtp-Source: AGHT+IF1T6cOgdyU2Gj/hecxYoAWkyAoxC72GDTHkqDeqHCVcyiOWcd6T5TmZcQ/NHhBFk9ZgGIDmt5lW+TDOqPx7Is= X-Received: by 2002:a05:651c:150b:b0:2d3:b37b:6a50 with SMTP id e11-20020a05651c150b00b002d3b37b6a50mr1112396ljf.19.1709803011329; Thu, 07 Mar 2024 01:16:51 -0800 (PST) MIME-Version: 1.0 From: Uros Bizjak Date: Thu, 7 Mar 2024 10:16:39 +0100 Message-ID: Subject: [PATCH v2] combine: Fix ICE in try_combine on pr112494.c [PR112560] To: "gcc-patches@gcc.gnu.org" Cc: Jeff Law , Richard Biener Content-Type: multipart/mixed; boundary="000000000000206e1106130e8976" X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000206e1106130e8976 Content-Type: text/plain; charset="UTF-8" The compiler, configured with --enable-checking=yes,rtl,extra ICEs with: internal compiler error: RTL check: expected elt 0 type 'e' or 'u', have 'E' (rtx unspec) in try_combine, at combine.cc:3237 This is 3236 /* Just replace the CC reg with a new mode. */ 3237 SUBST (XEXP (*cc_use_loc, 0), newpat_dest); 3238 undobuf.other_insn = cc_use_insn; in combine.cc, where *cc_use_loc is (unspec:DI [ (reg:CC 17 flags) ] UNSPEC_PUSHFL) combine assumes CC must be used inside of a comparison and uses XEXP (..., 0) without checking on the RTX type of the argument. Undo the combination if *cc_use_loc is not COMPARISON_P. Also remove buggy and now redundant check for (const 0) RTX as part of the comparison. PR rtl-optimization/112560 gcc/ChangeLog: * combine.cc (try_combine): Reject the combination if *cc_use_loc is not COMPARISON_P. Bootstrapped and regression tested on x86_64-pc-linux-gnu {,-m32}. OK for trunk? Uros. --000000000000206e1106130e8976 Content-Type: text/plain; charset="US-ASCII"; name="p.diff.txt" Content-Disposition: attachment; filename="p.diff.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lth0bufm0 ZGlmZiAtLWdpdCBhL2djYy9jb21iaW5lLmNjIGIvZ2NjL2NvbWJpbmUuY2MKaW5kZXggYTQ0Nzlm OGQ4MzYuLjZkYWM5ZmZjYTg1IDEwMDY0NAotLS0gYS9nY2MvY29tYmluZS5jYworKysgYi9nY2Mv Y29tYmluZS5jYwpAQCAtMzE4NCwxMSArMzE4NCwyMSBAQCB0cnlfY29tYmluZSAocnR4X2luc24g KmkzLCBydHhfaW5zbiAqaTIsIHJ0eF9pbnNuICppMSwgcnR4X2luc24gKmkwLAogCSAgJiYgKGNj X3VzZV9sb2MgPSBmaW5kX3NpbmdsZV91c2UgKFNFVF9ERVNUIChuZXdwYXQpLCBpMywKIAkJCQkJ ICAgICZjY191c2VfaW5zbikpKQogCXsKLQkgIGNvbXBhcmVfY29kZSA9IG9yaWdfY29tcGFyZV9j b2RlID0gR0VUX0NPREUgKCpjY191c2VfbG9jKTsKLQkgIGlmIChpc19hIDxzY2FsYXJfaW50X21v ZGU+IChHRVRfTU9ERSAoaTJkZXN0KSwgJm1vZGUpKQotCSAgICBjb21wYXJlX2NvZGUgPSBzaW1w bGlmeV9jb21wYXJlX2NvbnN0IChjb21wYXJlX2NvZGUsIG1vZGUsCi0JCQkJCQkgICAmb3AwLCAm b3AxKTsKLQkgIHRhcmdldF9jYW5vbmljYWxpemVfY29tcGFyaXNvbiAoJmNvbXBhcmVfY29kZSwg Jm9wMCwgJm9wMSwgMSk7CisJICBpZiAoQ09NUEFSSVNPTl9QICgqY2NfdXNlX2xvYykpCisJICAg IHsKKwkgICAgICBjb21wYXJlX2NvZGUgPSBvcmlnX2NvbXBhcmVfY29kZSA9IEdFVF9DT0RFICgq Y2NfdXNlX2xvYyk7CisJICAgICAgaWYgKGlzX2EgPHNjYWxhcl9pbnRfbW9kZT4gKEdFVF9NT0RF IChpMmRlc3QpLCAmbW9kZSkpCisJCWNvbXBhcmVfY29kZSA9IHNpbXBsaWZ5X2NvbXBhcmVfY29u c3QgKGNvbXBhcmVfY29kZSwgbW9kZSwKKwkJCQkJCSAgICAgICAmb3AwLCAmb3AxKTsKKwkgICAg ICB0YXJnZXRfY2Fub25pY2FsaXplX2NvbXBhcmlzb24gKCZjb21wYXJlX2NvZGUsICZvcDAsICZv cDEsIDEpOworCSAgICB9CisJICBlbHNlCisJICAgIHsKKwkgICAgICBpZiAoZHVtcF9maWxlICYm IChkdW1wX2ZsYWdzICYgVERGX0RFVEFJTFMpKQorCQlmcHJpbnRmIChkdW1wX2ZpbGUsICJDQyBy ZWdpc3RlciBub3QgdXNlZCBpbiBjb21wYXJpc29uLlxuIik7CisJICAgICAgdW5kb19hbGwgKCk7 CisJICAgICAgcmV0dXJuIDA7CisJICAgIH0KIAl9CiAKICAgICAgIC8qIERvIHRoZSByZXN0IG9u bHkgaWYgb3AxIGlzIGNvbnN0MF9ydHgsIHdoaWNoIG1heSBiZSB0aGUKQEAgLTMyMjEsOSArMzIz MSw3IEBAIHRyeV9jb21iaW5lIChydHhfaW5zbiAqaTMsIHJ0eF9pbnNuICppMiwgcnR4X2luc24g KmkxLCBydHhfaW5zbiAqaTAsCiAJCX0KICNlbmRpZgogCSAgICAgIC8qIENhc2VzIGZvciBtb2Rp ZnlpbmcgdGhlIENDLXVzaW5nIGNvbXBhcmlzb24uICAqLwotCSAgICAgIGlmIChjb21wYXJlX2Nv ZGUgIT0gb3JpZ19jb21wYXJlX2NvZGUKLQkJICAvKiA/Pz8gRG8gd2UgbmVlZCB0byB2ZXJpZnkg dGhlIHplcm8gcnR4PyAgKi8KLQkJICAmJiBYRVhQICgqY2NfdXNlX2xvYywgMSkgPT0gY29uc3Qw X3J0eCkKKwkgICAgICBpZiAoY29tcGFyZV9jb2RlICE9IG9yaWdfY29tcGFyZV9jb2RlKQogCQl7 CiAJCSAgLyogUmVwbGFjZSBjY191c2VfbG9jIHdpdGggZW50aXJlIG5ldyBSVFguICAqLwogCQkg IFNVQlNUICgqY2NfdXNlX2xvYywK --000000000000206e1106130e8976--