From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=tb7S=CG=gmail.com=ubizjak@sourceware.org>
Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f])
	by sourceware.org (Postfix) with ESMTPS id 47BBC3858D28
	for <gcc-patches@gcc.gnu.org>; Sun, 18 Jun 2023 11:18:17 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47BBC3858D28
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-qv1-xf2f.google.com with SMTP id 6a1803df08f44-62fe6773c4fso17127326d6.2
        for <gcc-patches@gcc.gnu.org>; Sun, 18 Jun 2023 04:18:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20221208; t=1687087096; x=1689679096;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=mfN6DrH50uQC3f5jvCfw/qvWa7YL2SCBLvj+h4Hzn8o=;
        b=EK2vczAZLqsxRA66dSmWM7j5GDxwowwf/60uB1D0MNVuzWGUx3q76OAo6xuqfS4D1B
         YxYFCptb+9AZblLLmFqdClfu1RoTFJxTF4KKLX/jiXbPBsnM4t2i5BQ1Fyn1OGyEgacl
         sna4Is3Fto0M2JbXSYsqRr1YCfD+dRXde5dQlkGM+P8I9GTSt5VOrNT1Lew4qVJ+yYYT
         QXcZrVi6AAqxNxlVfGdB3n+URNMS0UdQBmgkKVWgvpF4G1/fRERf6fpEXB8fOVrJ2EcN
         YBMeO5jFMN0tzU9MnLi+ylnYNVmp5FQo+fbPm0J73IwDPmhybHTAf/xT+fpOB+Kc1xT2
         4kjg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1687087096; x=1689679096;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=mfN6DrH50uQC3f5jvCfw/qvWa7YL2SCBLvj+h4Hzn8o=;
        b=CuEd2/0I34Q2h+W3JRGPn9ACPxb1N+SfiJa+GinHG/KmPPsZtyK91Ck6izgdHZa36P
         o5QdD9+LtZD2MIaGUD6QLrN13YI+Zs8GazAxpVrWCRLOJd3y41izD31xGydEyBf9rs53
         vvg6e8w0YntCErsPxxE4+mL95Rf7D4LwFot5Wz5aiAZgVPTuQ2bt58g8wTDYVXGU3Avs
         h2k9QPksVKFXfpxdHtE+a73n8MLk6mJ3qT8w3VFiwLFbqWwuEdbXaxeRwqQJF7XbQCmV
         unu9W7l4Oj5RJyY8sgwmaIajZyKGcbHzERWKlH+rmAyXV4fbzMrnzKZVlGMYcVFUsYCP
         ALaQ==
X-Gm-Message-State: AC+VfDxLZVxzCVncisxVBl6hbbcKqbi+sp9hxd7zDh86JVFIyKzjNDi0
	UyuFjz+XDgymF+R79Xeqp/misLk6q6hdvLuxTjU=
X-Google-Smtp-Source: ACHHUZ7yOhdL9nhNJptPUXwanoBs1JJFD+ahtr/5CRJK4oJyo0IPU334ECJsE56esDodUTm016qKGaiLbnGBVOTEfys=
X-Received: by 2002:a05:6214:238d:b0:621:78a:dd84 with SMTP id
 fw13-20020a056214238d00b00621078add84mr7940023qvb.47.1687087096535; Sun, 18
 Jun 2023 04:18:16 -0700 (PDT)
MIME-Version: 1.0
References: <005501d9a1c4$1443cd30$3ccb6790$@nextmovesoftware.com>
In-Reply-To: <005501d9a1c4$1443cd30$3ccb6790$@nextmovesoftware.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Sun, 18 Jun 2023 13:18:06 +0200
Message-ID: <CAFULd4ZDcB_SSgzxf64ArZLC2TTBOK=tQn7Dn7GMEj9hR0RWkw@mail.gmail.com>
Subject: Re: [x86 PATCH] Standardize shift amount constants as QImode.
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Sun, Jun 18, 2023 at 11:05=E2=80=AFAM Roger Sayle <roger@nextmovesoftwar=
e.com> wrote:
>
>
> This clean-up improves consistency within i386.md by using QImode for
> the constant shift count in patterns that specify a mode.
>
> This patch has been tested on x86_64-pc-linux-gnu with make bootstrap
> and make -k check, both with and without --target_board=3Dunix{-m32}
> with no new failures.  Ok for mainline?
>
>
> 2023-06-18  Roger Sayle  <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
>         * config/i386/i386.md (*concat<mode><dwi>3_1): Use QImode
>         for the immediate constant shift count.
>         (*concat<mode><dwi>3_2): Likewise.
>         (*concat<mode><dwi>3_3): Likewise.
>         (*concat<mode><dwi>3_4): Likewise.
>         (*concat<mode><dwi>3_5): Likewise.
>         (*concat<mode><dwi>3_6): Likewise.

OK.

Thanks,
Uros.

>
>
> Thanks,
> Roger
> --
>
>