From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-390799-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 6067 invoked by alias); 29 Jan 2015 14:54:39 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 6047 invoked by uid 89); 29 Jan 2015 14:54:38 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-oi0-f45.google.com
Received: from mail-oi0-f45.google.com (HELO mail-oi0-f45.google.com) (209.85.218.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 29 Jan 2015 14:54:36 +0000
Received: by mail-oi0-f45.google.com with SMTP id g201so27331699oib.4        for <gcc-patches@gcc.gnu.org>; Thu, 29 Jan 2015 06:54:34 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.202.176.4 with SMTP id z4mr524793oie.43.1422543274393; Thu, 29 Jan 2015 06:54:34 -0800 (PST)
Received: by 10.60.159.166 with HTTP; Thu, 29 Jan 2015 06:54:34 -0800 (PST)
In-Reply-To: <20150129144710.GJ1746@tucnak.redhat.com>
References: <CAFULd4ZrCea=qSn_bKGVytZHo7KUwPynGE4-RB9QnHe3k4RRvA@mail.gmail.com>	<20150129144710.GJ1746@tucnak.redhat.com>
Date: Thu, 29 Jan 2015 16:08:00 -0000
Message-ID: <CAFULd4ZEu==tvZs_kTf1F_k2yjsDF5wy81oDWp5OcBb6RmqaWg@mail.gmail.com>
Subject: Re: [PATCH][PR target/15184] Fix for direct byte access on x86
From: Uros Bizjak <ubizjak@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, Jeff Law <law@redhat.com>
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2015-01/txt/msg02621.txt.bz2

On Thu, Jan 29, 2015 at 3:47 PM, Jakub Jelinek <jakub@redhat.com> wrote:

>> > So here's the updated patch which handles all 4 testcases from the PR as well as a couple of my own.
>>
>> @@ -0,0 +1,33 @@
>> +/* PR 15184 first two tests, plus two addition ones.  */
>> +/* { dg-do compile } */
>> +/* { dg-options "-O2 -m32 -march=pentiumpro" } */
>>
>> No, we don't want -m32 in dg-options. Please write this part as:
>>
>> /* { dg-do compile { target ia32 } } */
>> /* { dg-options "-O2 -march=pentiumpro" } */
>
> Or
> /* { dg-do compile } */
> /* { dg-options "-O2" } */
> /* { dg-additional-options "-march=pentiumpro" { target ia32 } } */
> if there is nothing ia32 specific on the testcase, just that you want
> to use that -march option if you are compiling it as 32-bit.

In this case, you will need to add -mregparm=3 to
dg-additional-options to avoid "attribute ... ignored" awarning. There
are some examples in dg.target/i386/ testsuite directory.

Uros.