From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-494281-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 24222 invoked by alias); 18 Jan 2019 07:55:06 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 24194 invoked by uid 89); 18 Jan 2019 07:55:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=wei.william.xiao@gmail.com, sk:weiwil, sk:wei.wil, U*wei.william.xiao
X-HELO: mail-it1-f193.google.com
Received: from mail-it1-f193.google.com (HELO mail-it1-f193.google.com) (209.85.166.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Jan 2019 07:55:03 +0000
Received: by mail-it1-f193.google.com with SMTP id h193so4681959ita.5        for <gcc-patches@gcc.gnu.org>; Thu, 17 Jan 2019 23:55:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=C1rI5hwoRzxcYTAwbPM4V8NQJ3743pLWEBU5inxt57I=;        b=JSEk6tqLOAuOpyb47gk0knFtYzm//0pg028mDfeoS/wGgHtcz/q3b7xpnwgFK4d8CK         wftf5CfaWczoilQjwaOvm3ptQc1BHho/ln4nTEePO3+Qv2nCHtHwciDjjAhvW8J9AOvI         qZDLkzeGyRShb2W/pdC84nQZn9pyKeVTla240uonIpUUjZNUW5nS95g/Bo3fkWT7rdPW         GtZKiwt1TcnnyaTEQqEJpZqXIueEyMd6JWWWDtbmwxT2ZN/iX5qx0n7NM7L4BIyjhiw6         RbBgQkNxZHj0EK1+XrgPwzQ6PN5jYCapjpy+/VX+oXK04C1R+FH6nOrGG46GgYniqccZ         0I2Q==
MIME-Version: 1.0
References: <CAHFC=N=eTMgfHWL7fAkbeC6EChPj3q=UA9_Csro9e-Ju1zoThQ@mail.gmail.com> <CAFULd4bPwAVCAmWKXFt1m6GZcFxt+BAAF8V1sUZeEnPFbDku7w@mail.gmail.com> <20190115152050.GP30353@tucnak> <CAHFC=N=TVKQ5q2UhNTu7cZXBaKT8NgDaaj9JG04ufHny+ZO=xw@mail.gmail.com> <20190117130315.GH30353@tucnak> <CAHFC=NmTyDMuVg=Rnh6hT5E2k0W-MOihFtsH97h1wB+Tw9cXJQ@mail.gmail.com>
In-Reply-To: <CAHFC=NmTyDMuVg=Rnh6hT5E2k0W-MOihFtsH97h1wB+Tw9cXJQ@mail.gmail.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Fri, 18 Jan 2019 07:55:00 -0000
Message-ID: <CAFULd4ZGR__dF5KzT45+UJfm-Qh8n4v-jadSS4-Pba0ks1bz5g@mail.gmail.com>
Subject: Re: [PATCH] Read avx512vl-vfixupimms*-2.c testcases (PR target/88489)
To: Wei Xiao <wei.william.xiao@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>, "Lu, Hongjiu" <hongjiu.lu@intel.com>, 	"H. J. Lu" <hjl.tools@gmail.com>, M Kretz <kretz@kde.org>, 	"Guo, Xuepeng" <xuepeng.guo@intel.com>, "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, wei3.xiao@intel.com
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2019-01/txt/msg01050.txt.bz2

On Fri, Jan 18, 2019 at 3:42 AM Wei Xiao <wei.william.xiao@gmail.com> wrote:
>
> > > > For r267160, I'd expect you want to revert just the config/i386/ part and
> > > > keep the testcases, they should work even with the changes reverted, right?
> > > >
> > > The testcase part also need to be reverted since we have changed them
> > > according to the incorrect intrinsic list in SDM.
> >
> > I don't really understand this.
> >
> > The testcases succeed just fine for me in the current trunk with all the
> > reversions and test something the current state of the testsuite doesn't
> > check normally, in particular that the testcases run correctly even when
> > -mavx512vl is used.  As that misbehaved in the past, we should make sure we
> > don't break that again.
> >
>
> You're right. The testcases need to be kept to prevent regression.
>
> > Uros, is it ok to reapply this to current trunk?

Yes, please reapply the tests.

Thanks,
Uros.