From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3207 invoked by alias); 7 Jul 2011 13:05:32 -0000 Received: (qmail 3196 invoked by uid 22791); 7 Jul 2011 13:05:30 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_CX X-Spam-Check-By: sourceware.org Received: from mail-pw0-f47.google.com (HELO mail-pw0-f47.google.com) (209.85.160.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Jul 2011 13:05:12 +0000 Received: by pwi1 with SMTP id 1so703591pwi.20 for ; Thu, 07 Jul 2011 06:05:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.66.7 with SMTP id o7mr404121wfa.367.1310043911545; Thu, 07 Jul 2011 06:05:11 -0700 (PDT) Received: by 10.142.107.13 with HTTP; Thu, 7 Jul 2011 06:05:11 -0700 (PDT) In-Reply-To: References: <20110605195441.GA1225@intel.com> <20110705143920.GA25294@intel.com> Date: Thu, 07 Jul 2011 13:08:00 -0000 Message-ID: Subject: Re: PATCH [1/n] X32: Add initial -x32 support From: Uros Bizjak To: "H.J. Lu" Cc: GCC Patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00474.txt.bz2 On Thu, Jul 7, 2011 at 2:59 PM, H.J. Lu wrote: >>>> Hi Paolo, DJ, Nathanael, Alexandre, Ralf, >>>> >>>> Is the change >>>> . >>>> =A0 =A0 =A0 =A0* configure.ac: Support --enable-x32. >>>> =A0 =A0 =A0 =A0* configure: Regenerated. >>>> >>>> diff --git a/gcc/configure.ac b/gcc/configure.ac >>>> index 5f3641b..bddabeb 100644 >>>> --- a/gcc/configure.ac >>>> +++ b/gcc/configure.ac >>>> @@ -611,6 +611,11 @@ AC_ARG_ENABLE(multilib, >>>> =A0[], [enable_multilib=3Dyes]) >>>> =A0AC_SUBST(enable_multilib) >>>> >>>> +# With x32 support >>>> +AC_ARG_ENABLE(x32, >>>> +[ =A0--enable-x32 =A0 =A0 =A0 =A0 =A0 =A0enable x32 library support f= or multiple ABIs], >>> >>> Looks like a very very generic switch for a global configury ... we alr= eady >>> have --with-multilib-list (SH only), why not extend that to also work >>> for x86_64? >>> >>> Richard. >>> >>>> +[], [enable_x32=3Dno]) >>>> + >>>> =A0# Enable __cxa_atexit for C++. >>>> =A0AC_ARG_ENABLE(__cxa_atexit, >>>> =A0[AS_HELP_STRING([--enable-__cxa_atexit], [enable __cxa_atexit for C= ++])], >>>> >>>> OK? >>>> >>>> Thanks. >>>> >> >> Here is the updated patch to use --with-multilib-list=3Dx32. >> >> Paolo, DJ, Nathanael, Alexandre, Ralf, Is the configure.ac change >> >> --- >> =A0 =A0 =A0 =A0* configure.ac: Mention x86-64 for --with-multilib-list. >> =A0 =A0 =A0 =A0* configure: Regenerated. >> >> =A0 =A0 =A0 =A0* doc/install.texi: Document --with-multilib-list=3Dx32. >> >> diff --git a/gcc/configure.ac b/gcc/configure.ac >> index 5f3641b..a73f758 100644 >> --- a/gcc/configure.ac >> +++ b/gcc/configure.ac >> @@ -795,7 +795,7 @@ esac], >> =A0[enable_languages=3Dc]) >> >> =A0AC_ARG_WITH(multilib-list, >> -[AS_HELP_STRING([--with-multilib-list], [select multilibs (SH only)])], >> +[AS_HELP_STRING([--with-multilib-list], [select multilibs (SH and >> x86-64 only)])], >> =A0:, >> =A0with_multilib_list=3Ddefault) >> >> diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi >> index 49aac95..a5d266c 100644 >> --- a/gcc/doc/install.texi >> +++ b/gcc/doc/install.texi >> @@ -1049,8 +1049,10 @@ sysv, aix. >> =A0@item --with-multilib-list=3D@var{list} >> =A0@itemx --without-multilib-list >> =A0Specify what multilibs to build. >> -Currently only implemented for sh*-*-*. >> +Currently only implemented for sh*-*-* and x86-64-*-linux*. >> >> +@table @code >> +@item sh*-*-* >> =A0@var{list} is a comma separated list of CPU names. =A0These must be o= f the >> =A0form @code{sh*} or @code{m*} (in which case they match the compiler o= ption >> =A0for that processor). =A0The list should not contain any endian option= s - >> @@ -1082,6 +1084,12 @@ only little endian SH4AL: >> =A0--with-multilib-list=3Dsh4al,!mb/m4al >> =A0@end smallexample >> >> +@item x86-64-*-linux* >> +If @var{list} is @code{x32}, x32 run-time library will be enabled. =A0By >> +default, x32 run-time library is disabled. >> + >> +@end table >> + >> =A0@item --with-endian=3D@var{endians} >> =A0Specify what endians to use. >> =A0Currently only implemented for sh*-*-*. >> --- >> >> OK? >> >> Thanks. >> >> -- >> H.J. >> --- >> 2011-07-06 =A0H.J. Lu =A0 >> >> =A0 =A0 =A0 =A0* config.gcc: Support --with-multilib-list=3Dx32 for x86 = Linux >> =A0 =A0 =A0 =A0targets. >> >> =A0 =A0 =A0 =A0* configure.ac: Mention x86-64 for --with-multilib-list. >> =A0 =A0 =A0 =A0* configure: Regenerated. >> >> =A0 =A0 =A0 =A0* config/i386/gnu-user64.h (SPEC_64): Support x32. >> =A0 =A0 =A0 =A0(SPEC_32): Likewise. >> =A0 =A0 =A0 =A0(ASM_SPEC): Likewise. >> =A0 =A0 =A0 =A0(LINK_SPEC): Likewise. >> =A0 =A0 =A0 =A0(TARGET_THREAD_SSP_OFFSET): Likewise. >> =A0 =A0 =A0 =A0(TARGET_THREAD_SPLIT_STACK_OFFSET): Likewise. >> =A0 =A0 =A0 =A0(SPEC_X32): New. >> >> =A0 =A0 =A0 =A0* config/i386/i386.h (TARGET_X32): New. >> =A0 =A0 =A0 =A0(TARGET_LP64): New. >> =A0 =A0 =A0 =A0(LONG_TYPE_SIZE): Likewise. >> =A0 =A0 =A0 =A0(POINTER_SIZE): Likewise. >> =A0 =A0 =A0 =A0(POINTERS_EXTEND_UNSIGNED): Likewise. >> =A0 =A0 =A0 =A0(OPT_ARCH64): Support x32. >> =A0 =A0 =A0 =A0(OPT_ARCH32): Likewise. >> >> =A0 =A0 =A0 =A0* config/i386/i386.opt (mx32): New. >> >> =A0 =A0 =A0 =A0* config/i386/kfreebsd-gnu64.h (GNU_USER_LINK_EMULATIONX3= 2): New. >> =A0 =A0 =A0 =A0(GLIBC_DYNAMIC_LINKERX32): Likewise. >> =A0 =A0 =A0 =A0* config/i386/linux64.h (GNU_USER_LINK_EMULATIONX32): Lik= ewise. >> =A0 =A0 =A0 =A0(GLIBC_DYNAMIC_LINKERX32): Likewise. >> >> =A0 =A0 =A0 =A0* config/i386/t-linux-x32: New. >> >> =A0 =A0 =A0 =A0* config/linux.h (UCLIBC_DYNAMIC_LINKERX32): New. >> =A0 =A0 =A0 =A0(BIONIC_DYNAMIC_LINKERX32): Likewise. >> =A0 =A0 =A0 =A0(GNU_USER_DYNAMIC_LINKERX32): Likewise. >> >> =A0 =A0 =A0 =A0* doc/install.texi: Document --with-multilib-list=3Dx32. >> >> =A0 =A0 =A0 =A0* doc/invoke.texi: Document -mx32. >> > > Hi Uros, > > This new version only adds a comment to configure.ac. =A0OK to install? OK. Thanks, Uros.