From: Uros Bizjak <ubizjak@gmail.com>
To: Daniel Santos <daniel.santos@pobox.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Jan Hubicka <hubicka@ucw.cz>, "H.J. Lu" <hjl.tools@gmail.com>,
Martin Liska <mliska@suse.cz>,
Rainer Orth <ro@cebitec.uni-bielefeld.de>,
Mike Stump <mikestump@comcast.net>
Subject: Re: [PATCH v4 0/4] [i386] PR80969 Fix ICE with -mabi=ms -mavx512f
Date: Wed, 23 Aug 2017 13:53:00 -0000 [thread overview]
Message-ID: <CAFULd4ZN5oyaQZ9gtY8P5cJ5Xd1d+aE-F9z_okjOB255sArbDg@mail.gmail.com> (raw)
In-Reply-To: <6bbd474b-d6f9-eed0-8035-0dd8d4b9379d@pobox.com>
On Wed, Aug 23, 2017 at 12:34 AM, Daniel Santos <daniel.santos@pobox.com> wrote:
> I had to fix a few things for x32 compatibility and I this is ready
> now. H.J. tested on machine with avx512 (including x32) and I've tested
> both native x32 and normal x86_64 with m64, m32 and mx32 and all is
> well. I've made more changes to the tests so I'm just submitting a
> version 2 of the whole patch set.
>
> OK for trunk?
>
> 2017-08-22 Daniel Santos <daniel.santos@pobox.com>
>
> * config/i386/i386.h (ix86_frame::stack_realign_allocate_offset):
> Remove field.
> (ix86_frame::stack_realign_allocate): New field.
> (struct machine_frame_state): Modify comments.
> (machine_frame_state::sp_realigned_fp_end): New field.
> * config/i386/i386.c (ix86_compute_frame_layout): Rework stack frame
> layout calculation.
> (sp_valid_at): Add assertion to assure no attempt to access invalid
> offset of a realigned stack.
> (fp_valid_at): Likewise.
> (choose_baseaddr): Modify comments.
> (ix86_emit_outlined_ms2sysv_save): Adjust to changes in
> ix86_expand_prologue.
> (ix86_expand_prologue): Modify stack realignment and allocation.
> (ix86_expand_epilogue): Modify comments.
>
> 2017-08-22 Daniel Santos <daniel.santos@pobox.com>
>
> * gcc.target/i386/pr80969-1.c: New testcase.
> * gcc.target/i386/pr80969-2a.c: Likewise.
> * gcc.target/i386/pr80969-2.c: Likewise.
> * gcc.target/i386/pr80969-3.c: Likewise.
> * gcc.target/i386/pr80969-4a.c: Likewise.
> * gcc.target/i386/pr80969-4b.c: Likewise.
> * gcc.target/i386/pr80969-4.c: Likewise.
> * gcc.target/i386/pr80969-4.h: New header common to pr80969-4*.c
I went through the patchset one more time, and I didn't find anything
that would stick out. I have a comment in 4/4, but nothing critical.
IMO extensive testsuite would catch possible bug there, so
OK for mainline.
(But please stay around to fix any possible fallout...)
Thanks,
Uros.
prev parent reply other threads:[~2017-08-23 13:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 11:16 [PATCH 0/6] " Daniel Santos
2017-07-31 11:19 ` [PATCH 6/6] [i386, testsuite] Add tests, fix bug in check_avx2_hw_available Daniel Santos
2017-08-08 19:23 ` [PATCH 6/6 v2] " Daniel Santos
2017-07-31 11:19 ` [PATCH 5/6] [i386] Modify SP realignment in ix86_expand_prologue, et. al Daniel Santos
2017-08-02 23:28 ` [PATCH 5/6 v2] " Daniel Santos
2017-07-31 11:19 ` [PATCH 2/6] [i386] Remove ix86_frame::outlined_save_offset Daniel Santos
2017-07-31 13:53 ` Uros Bizjak
2017-07-31 11:19 ` [PATCH 4/6] [i386] Modify ix86_compute_frame_layout Daniel Santos
2017-07-31 11:19 ` [PATCH 3/6] [i386] Remove machine_function::call_ms2sysv_pad_out Daniel Santos
2017-07-31 13:59 ` Uros Bizjak
2017-07-31 11:19 ` [PATCH 1/6] [i386] Correct comments, add assertions to sp_valid_at and fp_valid_at Daniel Santos
2017-07-31 17:23 ` [PATCH 0/6] [i386] PR80969 Fix ICE with -mabi=ms -mavx512f Daniel Santos
2017-08-01 6:20 ` Uros Bizjak
2017-08-08 19:31 ` PING " Daniel Santos
2017-08-22 22:44 ` [PATCH v4 0/4] " Daniel Santos
2017-08-22 23:23 ` [PATCH 1/4] [i386] Correct comments, add assertions to sp_valid_at and fp_valid_at Daniel Santos
2017-08-23 3:51 ` [PATCH 4/4] [i386, testsuite] Add tests, fix bug in check_avx2_hw_available Daniel Santos
2017-08-23 13:46 ` Uros Bizjak
2017-08-24 1:32 ` Daniel Santos
2017-08-23 4:17 ` [PATCH 2/4] [i386] Modify ix86_compute_frame_layout Daniel Santos
2017-08-23 4:18 ` [PATCH 3/4] [i386] Modify SP realignment in ix86_expand_prologue, et. al Daniel Santos
2017-08-23 13:53 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4ZN5oyaQZ9gtY8P5cJ5Xd1d+aE-F9z_okjOB255sArbDg@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=daniel.santos@pobox.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=hubicka@ucw.cz \
--cc=mikestump@comcast.net \
--cc=mliska@suse.cz \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).