From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105029 invoked by alias); 23 Aug 2017 13:29:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 105015 invoked by uid 89); 23 Aug 2017 13:29:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-vk0-f43.google.com Received: from mail-vk0-f43.google.com (HELO mail-vk0-f43.google.com) (209.85.213.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Aug 2017 13:29:56 +0000 Received: by mail-vk0-f43.google.com with SMTP id j189so478438vka.0 for ; Wed, 23 Aug 2017 06:29:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nggIqEXESO5X1bmadN+DwV+/ap+BfHt1PBAxwyWvJGY=; b=X9Bc+2TyDYMJKOvH5HZAXkwgXlltQeGw/5wixBcGNhL4j180Sje/2PCgnsRfbXWlym AHKEFQlrDVU8g0eS75L/C0A0k1mzbT13trcTbu3SdJp4y9z6GDOxvDGnika0sEhM+Cl8 TaTv3RkLnj812TzWbTQwAiXaKmTLdFi0rVmhWl1Ctak+oQpTad7T1EyLyY2MWnYCQTJw N9jR9HasQA08S2MTRs9s13y3ZajvmhTN9CY/dczWLP3UfgkVWDwqqCO87hAneLmPPhR3 V9z/OkkZCVXFe8Obmf6U1xtdcO4w0uQwr4zj0t5TtV6pmcMdptiluRl6nrYBoYWPC4Rk Mt+g== X-Gm-Message-State: AHYfb5hRPBscQIGW+t7vJp0hER/ZzB4mGe/yS73Oeqq/R9u63eMEgeMi toAcNeNpmSLWsZbCxzvMdh7D9ZUt3A== X-Received: by 10.31.50.208 with SMTP id y199mr1818530vky.196.1503494994193; Wed, 23 Aug 2017 06:29:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.82.76 with HTTP; Wed, 23 Aug 2017 06:29:53 -0700 (PDT) In-Reply-To: <6bbd474b-d6f9-eed0-8035-0dd8d4b9379d@pobox.com> References: <8ac6dd17-e11c-a767-5d33-d3ec16b5b856@pobox.com> <6bbd474b-d6f9-eed0-8035-0dd8d4b9379d@pobox.com> From: Uros Bizjak Date: Wed, 23 Aug 2017 13:53:00 -0000 Message-ID: Subject: Re: [PATCH v4 0/4] [i386] PR80969 Fix ICE with -mabi=ms -mavx512f To: Daniel Santos Cc: gcc-patches , Jan Hubicka , "H.J. Lu" , Martin Liska , Rainer Orth , Mike Stump Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-08/txt/msg01366.txt.bz2 On Wed, Aug 23, 2017 at 12:34 AM, Daniel Santos wrote: > I had to fix a few things for x32 compatibility and I this is ready > now. H.J. tested on machine with avx512 (including x32) and I've tested > both native x32 and normal x86_64 with m64, m32 and mx32 and all is > well. I've made more changes to the tests so I'm just submitting a > version 2 of the whole patch set. > > OK for trunk? > > 2017-08-22 Daniel Santos > > * config/i386/i386.h (ix86_frame::stack_realign_allocate_offset): > Remove field. > (ix86_frame::stack_realign_allocate): New field. > (struct machine_frame_state): Modify comments. > (machine_frame_state::sp_realigned_fp_end): New field. > * config/i386/i386.c (ix86_compute_frame_layout): Rework stack frame > layout calculation. > (sp_valid_at): Add assertion to assure no attempt to access invalid > offset of a realigned stack. > (fp_valid_at): Likewise. > (choose_baseaddr): Modify comments. > (ix86_emit_outlined_ms2sysv_save): Adjust to changes in > ix86_expand_prologue. > (ix86_expand_prologue): Modify stack realignment and allocation. > (ix86_expand_epilogue): Modify comments. > > 2017-08-22 Daniel Santos > > * gcc.target/i386/pr80969-1.c: New testcase. > * gcc.target/i386/pr80969-2a.c: Likewise. > * gcc.target/i386/pr80969-2.c: Likewise. > * gcc.target/i386/pr80969-3.c: Likewise. > * gcc.target/i386/pr80969-4a.c: Likewise. > * gcc.target/i386/pr80969-4b.c: Likewise. > * gcc.target/i386/pr80969-4.c: Likewise. > * gcc.target/i386/pr80969-4.h: New header common to pr80969-4*.c I went through the patchset one more time, and I didn't find anything that would stick out. I have a comment in 4/4, but nothing critical. IMO extensive testsuite would catch possible bug there, so OK for mainline. (But please stay around to fix any possible fallout...) Thanks, Uros.