From: Uros Bizjak <ubizjak@gmail.com>
To: Hongtao Liu <crazylht@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Kirill Yukhin <kirill.yukhin@gmail.com>,
"H. J. Lu" <hjl.tools@gmail.com>,
Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH]i386: Optimize pmovskb on zero_extend of subreg HI of the result [PR98461]
Date: Mon, 4 Jan 2021 09:42:51 +0100 [thread overview]
Message-ID: <CAFULd4ZOFWfyyKwmQV38Wo8j3C_J_Ga2x58CfMrmGYj8sNT1_w@mail.gmail.com> (raw)
In-Reply-To: <CAMZc-bzSf6QTUii3kojG=zfYZMDNiq1mwUikmtWp-WUEPRe8gg@mail.gmail.com>
On Mon, Jan 4, 2021 at 8:52 AM Hongtao Liu <crazylht@gmail.com> wrote:
>
> On Mon, Jan 4, 2021 at 3:40 PM Uros Bizjak <ubizjak@gmail.com> wrote:
> >
> > On Mon, Jan 4, 2021 at 6:54 AM Hongtao Liu <crazylht@gmail.com> wrote:
> > >
> > > Hi:
> > > The following patch adds define_insn_and_split to optimize
> > >
> > > vpmovmskb %xmm0, %eax
> > > - movzwl %ax, %eax
> > > notl %eax
> > >
> > > Bootstrapped/regtested on x86_64-linux-gnu {,-m32}.
> > > Ok for trunk?
> > >
> > > gcc/ChangeLog
> > > PR target/98461
> > > * config/i386/sse.md (*sse2_pmovskb_zexthisi): New
> > > define_insn_and_split for zero_extend of subreg HI of pmovskb
> > > result.
> > >
> > > gcc/testsuite/ChangeLog
> > > * gcc.target/i386/sse-pr98461-2.c: New test.
> > > ---
> > > gcc/config/i386/sse.md | 11 +++++++++++
> > > gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c | 13 +++++++++++++
> > > 2 files changed, 24 insertions(+)
> > > create mode 100644 gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c
> > >
> > > diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
> > > index d84103807ff..4ed6b9ae476 100644
> > > --- a/gcc/config/i386/sse.md
> > > +++ b/gcc/config/i386/sse.md
> > > @@ -16099,6 +16099,17 @@ (define_insn "*sse2_pmovmskb_ext"
> > > (set_attr "prefix" "maybe_vex")
> > > (set_attr "mode" "SI")])
> > >
> > > +(define_insn_and_split "*sse2_pmovskb_zexthisi"
> > > + [(set (match_operand:SI 0 "register_operand")
> > > + (zero_extend:SI (subreg:HI (unspec:SI
> > > + [(match_operand:V16QI 1 "register_operand")]
> > > + UNSPEC_MOVMSK) 0)))]
> > > + "TARGET_SSE2"
> >
> > This needs ix86_pre_reload_split () in insn predicate.
> >
>
> Yes, there's subreg in the pattern.
Also the insn pattern does not have operand constraints.
> Assume patch is pre-approved with that change and
> regtested/bootstrapped on x86_64-linux-gnu{-m32,}.
LGTM with the above addition.
Uros.
next prev parent reply other threads:[~2021-01-04 8:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 5:56 Hongtao Liu
2021-01-04 7:40 ` Uros Bizjak
2021-01-04 7:54 ` Hongtao Liu
2021-01-04 8:42 ` Uros Bizjak [this message]
2021-01-04 8:49 ` Jakub Jelinek
2021-01-04 8:59 ` Hongtao Liu
2021-01-05 6:32 ` Hongtao Liu
2021-01-05 7:04 ` Uros Bizjak
2021-01-05 7:19 ` Uros Bizjak
2021-01-05 10:28 ` Hongtao Liu
2021-01-05 10:30 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4ZOFWfyyKwmQV38Wo8j3C_J_Ga2x58CfMrmGYj8sNT1_w@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=crazylht@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
--cc=kirill.yukhin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).