From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ubizjak@gmail.com>
Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com
 [IPv6:2607:f8b0:4864:20::832])
 by sourceware.org (Postfix) with ESMTPS id 357BD3858C27
 for <gcc-patches@gcc.gnu.org>; Mon,  4 Jan 2021 08:43:03 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 357BD3858C27
Received: by mail-qt1-x832.google.com with SMTP id 7so18030278qtp.1
 for <gcc-patches@gcc.gnu.org>; Mon, 04 Jan 2021 00:43:03 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=Kkf6x7aXRiCxjXBQaxVbIbVbwY9qX/klKfauNvcgEqk=;
 b=UNTMVDeXnvQl3Gb/pbz1cuaS7+wyRF/TKT0qcnbt/FOCbsdgL5cdirGs1TOSB+UBSn
 dKNB+MoAxE6B4o7DZw4MQW/oy6uy6Li6VJwaLHGOZvlZoYwBXjl0NO7KvOBzTgix+wjt
 /zCyZLALIQ4nTWKE2S17LbB5tmRKYCKZeS8wXR6JaDTXffAQ8wwVqIOW8waQjO60Grj8
 qzFziQBPCBsGL+zvM9polvA3kw3aE2kPf3YDxRWgVVvc40Zv7WH2LyHmTCGhw7r6tfA/
 nIcmjmRc2bH1IUouMicDK2ZyyiTpVyDfT2pHAxvpjkrpN4tUepukfA8woPaJIi/H0SyV
 8YRA==
X-Gm-Message-State: AOAM532s7TJ9qdnghjgGbz1gapJePlCexUjBQP8dii41RAI425NpX0AQ
 NF0eXMB4agJ2OzXyFQIyPvd+beFFopVWZDYoVXE=
X-Google-Smtp-Source: ABdhPJxAVZPhhK0KbJJ56HNjOK3mpe2TZ5zKrhARXiQVYGJUVMdd0QilX3EOsAcLwEnqPRhQ6/fbCWT16jWOSh2uUJ8=
X-Received: by 2002:ac8:5806:: with SMTP id g6mr70608623qtg.292.1609749782715; 
 Mon, 04 Jan 2021 00:43:02 -0800 (PST)
MIME-Version: 1.0
References: <CAMZc-bzvJp+bbZsrk2DxvR7Gb+TdAJVBMSr4MQ7DpMUCq_Y+Cg@mail.gmail.com>
 <CAFULd4ZOkrcdQy8HW-uW1t4PcVzkTh06JqGXz6Eep6Me3tkYQg@mail.gmail.com>
 <CAMZc-bzSf6QTUii3kojG=zfYZMDNiq1mwUikmtWp-WUEPRe8gg@mail.gmail.com>
In-Reply-To: <CAMZc-bzSf6QTUii3kojG=zfYZMDNiq1mwUikmtWp-WUEPRe8gg@mail.gmail.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Mon, 4 Jan 2021 09:42:51 +0100
Message-ID: <CAFULd4ZOFWfyyKwmQV38Wo8j3C_J_Ga2x58CfMrmGYj8sNT1_w@mail.gmail.com>
Subject: Re: [PATCH]i386: Optimize pmovskb on zero_extend of subreg HI of the
 result [PR98461]
To: Hongtao Liu <crazylht@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
 Kirill Yukhin <kirill.yukhin@gmail.com>, 
 "H. J. Lu" <hjl.tools@gmail.com>, Jakub Jelinek <jakub@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jan 2021 08:43:04 -0000

On Mon, Jan 4, 2021 at 8:52 AM Hongtao Liu <crazylht@gmail.com> wrote:
>
> On Mon, Jan 4, 2021 at 3:40 PM Uros Bizjak <ubizjak@gmail.com> wrote:
> >
> > On Mon, Jan 4, 2021 at 6:54 AM Hongtao Liu <crazylht@gmail.com> wrote:
> > >
> > > Hi:
> > >   The following patch adds define_insn_and_split to optimize
> > >
> > >        vpmovmskb       %xmm0, %eax
> > > -       movzwl  %ax, %eax
> > >         notl    %eax
> > >
> > >   Bootstrapped/regtested on x86_64-linux-gnu {,-m32}.
> > >   Ok for trunk?
> > >
> > > gcc/ChangeLog
> > >         PR target/98461
> > >         * config/i386/sse.md (*sse2_pmovskb_zexthisi): New
> > >         define_insn_and_split for zero_extend of subreg HI of pmovskb
> > >         result.
> > >
> > > gcc/testsuite/ChangeLog
> > >         * gcc.target/i386/sse-pr98461-2.c: New test.
> > > ---
> > >  gcc/config/i386/sse.md                         | 11 +++++++++++
> > >  gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c | 13 +++++++++++++
> > >  2 files changed, 24 insertions(+)
> > >  create mode 100644 gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c
> > >
> > > diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
> > > index d84103807ff..4ed6b9ae476 100644
> > > --- a/gcc/config/i386/sse.md
> > > +++ b/gcc/config/i386/sse.md
> > > @@ -16099,6 +16099,17 @@ (define_insn "*sse2_pmovmskb_ext"
> > >     (set_attr "prefix" "maybe_vex")
> > >     (set_attr "mode" "SI")])
> > >
> > > +(define_insn_and_split "*sse2_pmovskb_zexthisi"
> > > +  [(set (match_operand:SI 0 "register_operand")
> > > +       (zero_extend:SI (subreg:HI (unspec:SI
> > > +         [(match_operand:V16QI 1 "register_operand")]
> > > +          UNSPEC_MOVMSK) 0)))]
> > > +  "TARGET_SSE2"
> >
> > This needs ix86_pre_reload_split () in insn predicate.
> >
>
> Yes, there's subreg in the pattern.

Also the insn pattern does not have operand constraints.

> Assume patch is pre-approved with that change and
> regtested/bootstrapped on x86_64-linux-gnu{-m32,}.

LGTM with the above addition.

Uros.